fix: avoid panic when booleans and integers are compared.

Operators `==` and `!=` can be used for comparing two boolean values or an integer and a boolean. In some cases this type of expressions were causing a panic. For instance, in `pe.is_pe == pe.is_pe`.

Author: plusvic

lib/src/compiler/emit.rs

@@ -63,6 +63,11 @@ macro_rules! emit_operands {
             lhs_type = Type::Float;
         }
 
+        // If the left operand is bool, promote it from i32 to i64.
+        if lhs_type == Type::Bool {
+            $instr.unop(UnaryOp::I64ExtendUI32);
+        }
+
         emit_expr($ctx, $ir, rhs, $instr);
 
         // If the right operand is integer, but the left one is float,
@@ -72,6 +77,11 @@ macro_rules! emit_operands {
             rhs_type = Type::Float;
         }
 
+        // If the right operand is bool, promote it from i32 to i64.
+        if rhs_type == Type::Bool {
+            $instr.unop(UnaryOp::I64ExtendUI32);
+        }
+
         (lhs_type, rhs_type)
     }};
 }
@@ -104,7 +114,10 @@ macro_rules! emit_arithmetic_op {
 macro_rules! emit_comparison_op {
     ($ctx:ident, $ir:ident, $lhs:expr, $rhs:expr, $int_op:tt, $float_op:tt, $str_op:expr, $instr:ident) => {{
         match emit_operands!($ctx, $ir, $lhs, $rhs, $instr) {
-            (Type::Integer, Type::Integer) => {
+            (Type::Integer, Type::Integer)
+            | (Type::Bool, Type::Bool)
+            | (Type::Bool, Type::Integer)
+            | (Type::Integer, Type::Bool) => {
                 $instr.binop(BinaryOp::$int_op);
             }
             (Type::Float, Type::Float) => {

lib/src/tests/mod.rs

@@ -224,6 +224,17 @@ fn test_comparison_operations() {
     condition_true!("1.0 == 1");
     condition_true!("1.0 != 1.000000000000001");
     condition_true!("1.0 < 1.000000000000001");
+
+    #[cfg(feature = "test_proto2-module")]
+    condition_true!(
+        r#"test_proto2.array_bool[0] == test_proto2.array_bool[0]"#
+    );
+
+    #[cfg(feature = "test_proto2-module")]
+    condition_true!(r#"test_proto2.array_bool[0] == 0 + 0"#);
+
+    #[cfg(feature = "test_proto2-module")]
+    condition_true!(r#"2 - 1 == test_proto2.array_bool[1]"#);
 }
 
 #[test]