Merge pull request #3553 from VisActor/fix/indicator-switch-visible

Fix/indicator switch visible

Author: xile611

common/changes/@visactor/vchart/fix-indicator-switch-visible_2024-12-11-08-58.json

@@ -0,0 +1,11 @@
+{
+  "changes": [
+    {
+      "comment": "fix: fix indicator when change visible to be false, fix #3506\n\n",
+      "type": "none",
+      "packageName": "@visactor/vchart"
+    }
+  ],
+  "packageName": "@visactor/vchart",
+  "email": "[email protected]"
+}

packages/vchart/src/component/indicator/indicator.ts

@@ -209,7 +209,16 @@ export class Indicator<T extends IIndicatorSpec> extends BaseComponent<T> implem
     } as IndicatorAttributes;
   }
 
-  private _createOrUpdateIndicatorComponent(attrs: IndicatorAttributes): IndicatorComponents {
+  private _createOrUpdateIndicatorComponent(attrs: IndicatorAttributes) {
+    if (attrs.visible === false) {
+      // 按照vrender-component 的设置，只切换visible: false，并不会更新组件，所以强制删掉节点
+      if (this._indicatorComponent && this._indicatorComponent.parent) {
+        this._indicatorComponent.parent.removeChild(this._indicatorComponent);
+      }
+      this._indicatorComponent = null;
+      return;
+    }
+
     if (this._indicatorComponent) {
       if (!isEqual(attrs, this._cacheAttrs)) {
         this._indicatorComponent.setAttributes(attrs);
@@ -226,7 +235,6 @@ export class Indicator<T extends IIndicatorSpec> extends BaseComponent<T> implem
       );
     }
     this._cacheAttrs = attrs;
-    return this._indicatorComponent;
   }
 
   private _createText(