Skip to content

Commit 25d571a

Browse files
committed
diffName not overriden fixed
1 parent c91bb6f commit 25d571a

File tree

2 files changed

+7
-10
lines changed

2 files changed

+7
-10
lines changed

src/test-runs/test-runs.service.spec.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -340,7 +340,7 @@ describe('TestRunsService', () => {
340340

341341
expect(result).toStrictEqual({
342342
status: undefined,
343-
diffName: undefined,
343+
diffName: null,
344344
pixelMisMatchCount: undefined,
345345
diffPercent: undefined,
346346
isSameDimension: undefined,
@@ -362,7 +362,7 @@ describe('TestRunsService', () => {
362362

363363
expect(result).toStrictEqual({
364364
status: TestStatus.unresolved,
365-
diffName: undefined,
365+
diffName: null,
366366
pixelMisMatchCount: undefined,
367367
diffPercent: undefined,
368368
isSameDimension: false,
@@ -385,7 +385,7 @@ describe('TestRunsService', () => {
385385

386386
expect(result).toStrictEqual({
387387
status: TestStatus.ok,
388-
diffName: undefined,
388+
diffName: null,
389389
pixelMisMatchCount: 0,
390390
diffPercent: 0,
391391
isSameDimension: true,
@@ -411,7 +411,7 @@ describe('TestRunsService', () => {
411411
expect(saveImageMock).toHaveBeenCalledTimes(0);
412412
expect(result).toStrictEqual({
413413
status: TestStatus.ok,
414-
diffName: undefined,
414+
diffName: null,
415415
pixelMisMatchCount,
416416
diffPercent: 1.5,
417417
isSameDimension: true,

src/test-runs/test-runs.service.ts

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ export class TestRunsService {
8989

9090
const baseline = this.staticService.getImage(testRun.baselineName);
9191
const image = this.staticService.getImage(testRun.imageName);
92-
this.staticService.deleteImage(testRun.diffName);
92+
await this.staticService.deleteImage(testRun.diffName);
9393

9494
const diffResult = this.getDiff(baseline, image, testRun.diffTollerancePercent, testRun.ignoreAreas);
9595
return this.saveDiffResult(id, diffResult);
@@ -141,10 +141,7 @@ export class TestRunsService {
141141
async delete(id: string): Promise<TestRun> {
142142
const testRun = await this.findOne(id);
143143

144-
Promise.all([
145-
this.staticService.deleteImage(testRun.diffName),
146-
this.staticService.deleteImage(testRun.imageName),
147-
]);
144+
Promise.all([this.staticService.deleteImage(testRun.diffName), this.staticService.deleteImage(testRun.imageName)]);
148145

149146
return this.prismaService.testRun.delete({
150147
where: { id },
@@ -163,7 +160,7 @@ export class TestRunsService {
163160
getDiff(baseline: PNG, image: PNG, diffTollerancePercent: number, ignoreAreas: string): DiffResult {
164161
const result: DiffResult = {
165162
status: undefined,
166-
diffName: undefined,
163+
diffName: null,
167164
pixelMisMatchCount: undefined,
168165
diffPercent: undefined,
169166
isSameDimension: undefined,

0 commit comments

Comments
 (0)