fix: S3. Change name generation from Date.now to UUID (#331)

* fix: S3. Change name generation from Date.now to UUID

closes Visual-Regression-Tracker/Visual-Regression-Tracker#462

Author: pashidlos

.github/workflows/workflow.yml

@@ -59,9 +59,8 @@ jobs:
         run: docker compose -f docker-compose.yml -f docker-compose.ldap.yml down
 
       - name: SonarCloud Scan
-        uses: SonarSource/sonarcloud-github-action@master
+        uses: SonarSource/sonarqube-scan-action@v5
         env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           SONAR_TOKEN: ${{ secrets.SONARCLOUD_TOKEN }}
 
   test-migrations:

src/static/aws/s3.service.ts

@@ -4,6 +4,7 @@ import { Static } from '../static.interface';
 import { DeleteObjectCommand, GetObjectCommand, PutObjectCommand, S3Client } from '@aws-sdk/client-s3';
 import { Readable } from 'stream';
 import { getSignedUrl } from '@aws-sdk/s3-request-presigner';
+import { generateNewImageName } from '../utils';
 
 export class AWSS3Service implements Static {
   private readonly logger: Logger = new Logger(AWSS3Service.name);
@@ -26,7 +27,7 @@ export class AWSS3Service implements Static {
   }
 
   async saveImage(type: 'screenshot' | 'diff' | 'baseline', imageBuffer: Buffer): Promise<string> {
-    const imageName = `${Date.now()}.${type}.png`;
+    const imageName = generateNewImageName(type);
     try {
       await this.s3Client.send(
         new PutObjectCommand({

src/static/hdd/hdd.service.ts

@@ -2,15 +2,15 @@ import { Logger } from '@nestjs/common';
 import path from 'path';
 import { writeFileSync, readFileSync, unlink, mkdirSync, existsSync } from 'fs';
 import { PNG, PNGWithMetadata } from 'pngjs';
-import uuidAPIKey from 'uuid-apikey';
 import { Static } from '../static.interface';
 import { HDD_IMAGE_PATH } from './constants';
+import { generateNewImageName } from '../utils';
 
 export class HddService implements Static {
   private readonly logger: Logger = new Logger(HddService.name);
 
   generateNewImage(type: 'screenshot' | 'diff' | 'baseline'): { imageName: string; imagePath: string } {
-    const imageName = `${uuidAPIKey.create({ noDashes: true }).apiKey}.${type}.png`;
+    const imageName = generateNewImageName(type);
     return {
       imageName,
       imagePath: this.getImagePath(imageName),

src/static/utils.ts

@@ -1,7 +1,13 @@
+import uuidAPIKey from 'uuid-apikey';
+
 export function isHddStaticServiceConfigured() {
   return !process.env.STATIC_SERVICE || process.env.STATIC_SERVICE === 'hdd';
 }
 
 export function isS3ServiceConfigured() {
   return !process.env.STATIC_SERVICE || process.env.STATIC_SERVICE === 's3';
 }
+
+export function generateNewImageName(type: 'screenshot' | 'diff' | 'baseline'): string {
+  return `${uuidAPIKey.create({ noDashes: true }).apiKey}.${type}.png`;
+}