Run linter as part of CI, remove non used variables and fix from default command line

Author: paazmaya

.github/workflows/workflow.yml

@@ -18,6 +18,9 @@ jobs:
       - name: Install npm dependencies
         run: npm ci
 
+      - name: Static analysis
+        run: npm run lint
+
       - name: Unit tests
         run: npm run test:cov
 

package.json

@@ -13,7 +13,7 @@
     "start:dev": "nest start --watch",
     "start:debug": "nest start --debug --watch",
     "start:prod": "node dist/main",
-    "lint": "eslint \"{src,apps,libs,test}/**/*.ts\" --fix",
+    "lint": "eslint \"{src,apps,libs,test}/**/*.ts\"",
     "test": "jest --projects src",
     "test:watch": "jest --projects src --watch",
     "test:cov": "jest --projects src --coverage",

src/auth/auth.service.spec.ts

@@ -1,6 +1,5 @@
 import { Test, TestingModule } from '@nestjs/testing';
 import { AuthService } from './auth.service';
-import { UsersModule } from '../users/users.module';
 import { UsersService } from '../users/users.service';
 import { JwtService } from '@nestjs/jwt';
 

src/compare/libs/odiff/odiff.service.spec.ts

@@ -1,9 +1,8 @@
 import { TestingModule, Test } from '@nestjs/testing';
 import { TestStatus } from '@prisma/client';
-import { PNG } from 'pngjs';
 import { IgnoreAreaDto } from 'src/test-runs/dto/ignore-area.dto';
 import { StaticService } from '../../../shared/static/static.service';
-import { DIFF_DIMENSION_RESULT, EQUAL_RESULT, NO_BASELINE_RESULT } from '../consts';
+import { DIFF_DIMENSION_RESULT, NO_BASELINE_RESULT } from '../consts';
 import { OdiffService, DEFAULT_CONFIG, ignoreAreaToRegionMapper } from './odiff.service';
 import { OdiffConfig, OdiffIgnoreRegions } from './odiff.types';
 import { compare } from 'odiff-bin';
@@ -61,15 +60,6 @@ describe('parseConfig', () => {
 });
 
 describe('getDiff', () => {
-  const image = new PNG({
-    width: 20,
-    height: 20,
-  });
-  const anotherImage = new PNG({
-    width: 20,
-    height: 20,
-  });
-  anotherImage.data[0] = 1; // alterate pixel to have it different from 0
 
   it('no baseline', async () => {
     service = await initService({});

src/main.ts

@@ -2,7 +2,6 @@ import { NestFactory } from '@nestjs/core';
 import { AppModule } from './app.module';
 import { setupSwagger } from './swagger';
 import { Logger, ValidationPipe } from '@nestjs/common';
-import * as express from 'express';
 import { join } from 'path';
 import * as bodyParser from 'body-parser';
 import { readFileSync, existsSync } from 'fs';

src/shared/api-file.decorator.ts

@@ -2,7 +2,7 @@ import { ApiPropertyOptions, ApiProperty } from '@nestjs/swagger';
 
 export const ApiFile =
   (options?: ApiPropertyOptions): PropertyDecorator =>
-  (target: Object, propertyKey: string | symbol) => {
+  (target: any, propertyKey: string | symbol) => {
     if (options?.isArray) {
       ApiProperty({
         type: 'array',

src/shared/static/static.service.ts

@@ -45,7 +45,7 @@ export class StaticService {
 
   async deleteImage(imageName: string): Promise<boolean> {
     if (!imageName) return;
-    return new Promise((resolvePromise, reject) => {
+    return new Promise((resolvePromise) => {
       unlink(this.getImagePath(imageName), (err) => {
         if (err) {
           this.logger.error(err);

src/test-runs/dto/update-ignore-area.dto.ts

@@ -1,5 +1,4 @@
 import { ApiProperty } from '@nestjs/swagger';
-import { IsNotEmpty } from 'class-validator';
 import { IgnoreAreaDto } from './ignore-area.dto';
 
 export class UpdateIgnoreAreasDto {

src/test-runs/test-runs.service.spec.ts

@@ -117,7 +117,6 @@ describe('TestRunsService', () => {
   let service: TestRunsService;
   const imageBuffer = Buffer.from('Image');
   const ignoreAreas = [{ x: 1, y: 2, width: 10, height: 20 }];
-  const tempIgnoreAreas = [{ x: 3, y: 4, width: 30, height: 40 }];
 
   it('findOne', async () => {
     const id = 'some id';
@@ -298,8 +297,6 @@ describe('TestRunsService', () => {
   it('calculateDiff', async () => {
     const testRun: TestRun = generateTestRun();
     const testRunUpdateMock = jest.fn();
-    const baselineMock = 'baseline image';
-    const imageeMock = 'image';
     const deleteImageMock = jest.fn();
     const diffResult = {
       id: 'test',

src/test-variations/test-variations.service.spec.ts

@@ -562,7 +562,7 @@ describe('TestVariationsService', () => {
           id: 'baseline id 1',
           baselineName: 'image name 1',
           testVariationId: testVariationId,
-          testRunId: 'test run id 1',
+          testRunId: testRunId,
           userId: 'userId',
           createdAt: new Date(),
           updatedAt: new Date(),