Add NestJS plugin for ESLint to start catching issues before upgrade

fix

What about these?

Revert "What about these?"

This reverts commit 8338daa.

Author: paazmaya

.eslintrc.js

@@ -4,10 +4,11 @@ module.exports = {
     project: 'tsconfig.json',
     sourceType: 'module',
   },
-  plugins: ['@typescript-eslint/eslint-plugin'],
+  plugins: ['@typescript-eslint/eslint-plugin', '@darraghor/nestjs-typed'],
   extends: [
     'plugin:@typescript-eslint/eslint-recommended',
     'plugin:@typescript-eslint/recommended',
+    'plugin:@darraghor/nestjs-typed/recommended',
     'prettier',
   ],
   root: true,

package-lock.json

@@ -53,12 +53,13 @@
     "pixelmatch": "^5.3.0",
     "pngjs": "^7.0.0",
     "reflect-metadata": "^0.1.13",
-    "swagger-ui-express": "^4.6.3",
     "rimraf": "^5.0.1",
     "rxjs": "^7.8.1",
+    "swagger-ui-express": "^4.6.3",
     "uuid-apikey": "^1.5.3"
   },
   "devDependencies": {
+    "@darraghor/eslint-plugin-nestjs-typed": "^4.0.12",
     "@nestjs/cli": "^8.2.8",
     "@nestjs/schematics": "^8.0.11",
     "@nestjs/testing": "^8.4.7",

package.json

@@ -6,6 +6,7 @@ export const ApiFile =
     if (options?.isArray) {
       ApiProperty({
         type: 'array',
+        isArray: true,
         items: {
           type: 'file',
           properties: {

src/shared/api-file.decorator.ts

@@ -10,6 +10,8 @@ export class CreateTestRequestMultipartDto extends OmitType(CreateTestRequestDto
   'merge',
   'diffTollerancePercent',
 ]) {
+
+  /* eslint-disable @darraghor/nestjs-typed/all-properties-are-whitelisted, @darraghor/nestjs-typed/all-properties-have-explicit-defined */
   @ApiFile()
   image: Express.Multer.File;
 
@@ -25,6 +27,7 @@ export class CreateTestRequestMultipartDto extends OmitType(CreateTestRequestDto
   @Transform(({ value }) => value == 'true')
   merge?: boolean;
 
+  /* eslint-disable @darraghor/nestjs-typed/api-property-returning-array-should-set-array */
   @ApiPropertyOptional({ type: String })
   @IsOptional()
   @Type(() => String)

src/test-runs/dto/create-test-request-multipart.dto.ts

@@ -4,7 +4,9 @@ import { Type } from 'class-transformer';
 import { ValidateNested } from 'class-validator';
 
 export class UpdateIgnoreAreasDto {
-  @ApiProperty({ isArray: true })
+  @ApiProperty({type: String, isArray: true })
+  @Type(() => String)
+  @ValidateNested({ each: true })
   readonly ids: string[];
 
   @ApiProperty({ type: IgnoreAreaDto, isArray: true })

src/test-runs/dto/update-ignore-area.dto.ts

@@ -40,6 +40,7 @@ import { CurrentUser } from '../shared/current-user.decorator';
 import { RoleGuard } from '../auth/guards/role.guard';
 import { Roles } from '../shared/roles.decorator';
 
+/* eslint-disable @darraghor/nestjs-typed/injectable-should-be-provided */
 @ApiTags('test-runs')
 @Controller('test-runs')
 export class TestRunsController {

src/test-runs/test-runs.controller.ts

@@ -11,6 +11,7 @@ import { MergeParams } from './types';
 import { BaseTestVariationDto } from './dto/base-test-variation.dto';
 import { TestVariationDto } from './dto/test-variation.dto';
 
+/* eslint-disable @darraghor/nestjs-typed/injectable-should-be-provided */
 @ApiTags('test-variations')
 @Controller('test-variations')
 export class TestVariationsController {