test

Author: pashidlos

src/compare/libs/odiff/odiff.service.ts

@@ -27,8 +27,11 @@ export class OdiffService implements ImageComparator {
     this.hddService = this.staticService as unknown as HddService;
   }
 
-  parseConfig(configJson: string): OdiffConfig {
-    return parseConfig(configJson, DEFAULT_CONFIG, this.logger);
+  parseConfig(configInput: string | OdiffConfig): OdiffConfig {
+    if (typeof configInput === 'string') {
+      return parseConfig(configInput, DEFAULT_CONFIG, this.logger);
+    }
+    return { ...DEFAULT_CONFIG, ...configInput };
   }
 
   async getDiff(data: ImageCompareInput, config: OdiffConfig): Promise<DiffResult> {

src/compare/libs/pixelmatch/pixelmatch.service.spec.ts

@@ -8,6 +8,13 @@ import { PixelmatchConfig } from './pixelmatch.types';
 
 const mockPixelmatch = jest.fn();
 
+// Helper to create a Uint8Array for a PNG of given dimensions
+const createUint8ArrayForPng = (width: number, height: number): Uint8Array => {
+  const png = new PNG({ width, height });
+  // Access the underlying buffer and create a Uint8Array view
+  return new Uint8Array(png.data.buffer, png.data.byteOffset, png.data.byteLength);
+};
+
 const initService = async ({ getImageMock = jest.fn(), saveImageMock = jest.fn(), deleteImageMock = jest.fn() }) => {
   const module: TestingModule = await Test.createTestingModule({
     providers: [
@@ -129,6 +136,12 @@ describe('getDiff', () => {
     mockPixelmatch.mockReturnValueOnce(5);
     service = await initService({ saveImageMock, getImageMock });
 
+    const testConfig = {
+      allowDiffDimensions: true,
+      ignoreAntialiasing: true,
+      threshold: 0.1,
+    };
+
     const result = await service.getDiff(
       {
         baseline: 'image',
@@ -137,31 +150,18 @@ describe('getDiff', () => {
         ignoreAreas: [],
         saveDiffAsFile: true,
       },
-      {
-        allowDiffDimensions: true,
-        ignoreAntialiasing: true,
-        threshold: 0.1,
-      }
+      testConfig
     );
 
     expect(mockPixelmatch).toHaveBeenCalledWith(
-      new PNG({
-        width: 2,
-        height: 5,
-      }).data,
-      new PNG({
-        width: 2,
-        height: 5,
-      }).data,
-      new PNG({
-        width: 2,
-        height: 5,
-      }).data,
+      createUint8ArrayForPng(2, 5),
+      createUint8ArrayForPng(2, 5),
+      createUint8ArrayForPng(2, 5),
       2,
       5,
       {
-        includeAA: true,
-        threshold: 0.1,
+        includeAA: testConfig.ignoreAntialiasing,
+        threshold: testConfig.threshold,
       }
     );
     expect(saveImageMock).toHaveBeenCalledTimes(1);

src/compare/libs/pixelmatch/pixelmatch.service.ts

@@ -22,8 +22,11 @@ export class PixelmatchService implements ImageComparator {
     return pixelmatch;
   }
 
-  parseConfig(configJson: string): PixelmatchConfig {
-    return parseConfig(configJson, DEFAULT_CONFIG, this.logger);
+  parseConfig(configInput: string | PixelmatchConfig): PixelmatchConfig {
+    if (typeof configInput === 'string') {
+      return parseConfig(configInput, DEFAULT_CONFIG, this.logger);
+    }
+    return { ...DEFAULT_CONFIG, ...configInput };
   }
 
   async getDiff(data: ImageCompareInput, config: PixelmatchConfig): Promise<DiffResult> {