test

Author: pashidlos

src/builds/builds.controller.ts

@@ -89,10 +89,6 @@ export class BuildsController {
   @UseGuards(MixedGuard, RoleGuard)
   @Roles(Role.admin, Role.editor)
   update(@Param('id', new ParseUUIDPipe()) id: string, @Body() modifyBuildDto?: ModifyBuildDto): Promise<BuildDto> {
-    //In future, no or empty body will do nothing as this check will be removed. It will expect a proper body to perform any patch.
-    if (modifyBuildDto == null || Object.keys(modifyBuildDto).length === 0) {
-      modifyBuildDto = { isRunning: false };
-    }
     return this.buildsService.update(id, modifyBuildDto);
   }
 

test/builds.e2e-spec.ts

@@ -258,7 +258,7 @@ describe('Builds (e2e)', () => {
       const build = await buildsController.create({ project: project.id, branchName: 'develop' });
 
       return requestWithAuth(app, 'patch', `/builds/${build.id}`, user.token)
-        .send()
+        .send({isRunning: false})
         .expect(200)
         .expect((res) => {
           expect(res.body.isRunning).toBe(false);
@@ -269,7 +269,7 @@ describe('Builds (e2e)', () => {
       const build = await buildsController.create({ project: project.id, branchName: 'develop' });
 
       return requestWithApiKey(app, 'patch', `/builds/${build.id}`, user.apiKey)
-        .send()
+        .send({isRunning: false})
         .expect(200)
         .expect((res) => {
           expect(res.body.isRunning).toBe(false);