add e2e ldap tests

Author: nitschSB

.github/workflows/workflow.yml

@@ -40,6 +40,16 @@ jobs:
         if: always()
         run: docker compose down
 
+      - name: Run ldap containers
+        run: docker compose -f docker-compose.yml -f docker-compose.ldap.yml up -d
+
+      - name: Run ldap test
+        run: npm run test:ldap
+
+      - name: Stop ldap containers
+        if: always()
+        run: docker compose -f docker-compose.yml -f docker-compose.ldap.yml down
+
       - name: SonarCloud Scan
         uses: SonarSource/sonarcloud-github-action@master
         env:

docker-compose.ldap.yml

@@ -1,4 +1,3 @@
-version: "3.7"
 services:
   api:
     environment:

package.json

@@ -20,7 +20,8 @@
     "test:cov": "jest --projects src --coverage",
     "test:debug": "node --inspect-brk -r tsconfig-paths/register -r ts-node/register node_modules/.bin/jest --projects src --runInBand",
     "test:e2e": "jest --projects test",
-    "test:acceptance": "jest --projects test_acceptance"
+    "test:acceptance": "jest --projects test_acceptance",
+    "test:ldap": "jest --projects test_ldap"
   },
   "engines": {
     "node": ">=18.12.0"

src/users/ldap/ldapusers.service.ts

@@ -41,7 +41,7 @@ export class LdapUsersService implements Users {
       attributeMail: this.configService.getOrThrow<string>('LDAP_ATTRIBUTE_MAIL'),
       attributeFirstName: this.configService.getOrThrow<string>('LDAP_ATTRIBUTE_FIRST_NAME'),
       attributeLastName: this.configService.getOrThrow<string>('LDAP_ATTRIBUTE_LAST_NAME'),
-      tlsNoVerify: this.configService.get<boolean>('LDAP_TLS_NO_VERIFY', false),
+      tlsNoVerify: this.configService.get<string>('LDAP_TLS_NO_VERIFY', 'false').toLowerCase() === 'true',
     };
     this.ldapClient = new LdapClient({
       url: this.ldapConfig.url,

src/users/users.factory.ts

@@ -17,7 +17,7 @@ export class UsersFactoryService {
   ) {}
 
   getUsersService(): Users {
-    const serviceType = this.configService.get<boolean>('LDAP_ENABLED', false);
+    const serviceType = this.configService.get<string>('LDAP_ENABLED', 'false')?.toLowerCase() === 'true';
     switch (serviceType) {
       case true:
         this.logger.debug('users service type: LDAP');

test_ldap/jest.config.ts

@@ -0,0 +1,14 @@
+/** @returns {Promise<import('jest').Config>} */
+module.exports = async () => {
+  return {
+    displayName: 'Ldap',
+    roots: ['./'],
+    testTimeout: 30000,
+    testRegex: '.spec.ts$',
+    moduleFileExtensions: ['js', 'json', 'ts'],
+    transform: {
+      '^.+\\.(t|j)s$': 'ts-jest',
+    },
+    testEnvironment: 'node',
+  };
+};

test_ldap/ldap.spec.ts

@@ -0,0 +1,30 @@
+import axios from 'axios';
+import { UserLoginRequestDto } from 'src/users/dto/user-login-request.dto';
+import { UserLoginResponseDto } from 'src/users/dto/user-login-response.dto';
+
+axios.defaults.baseURL = 'http://localhost:4200';
+
+const loginData: UserLoginRequestDto = {
+  email: `[email protected]`,
+  password: 'password',
+};
+const wrongLoginData: UserLoginRequestDto = {
+  email: loginData.email,
+  password: 'wrongpassword',
+};
+
+describe('Ldap', () => {
+  test('Sucessful login', async () => {
+    const response = await axios.post<UserLoginResponseDto>('/users/login', loginData);
+
+    expect(response.status).toBe(201);
+    expect(response.data.token).toBeDefined();
+  });
+
+  test('Unsucessful login', async () => {
+    await axios.post<UserLoginResponseDto>('/users/login', wrongLoginData).catch((error) => {
+      expect(error.response.status).toBe(400);
+      expect(error.response.data.message).toContain('Invalid email or password.');
+    });
+  });
+});