Merge pull request #10 from Visual-Regression-Tracker/build-service-tests

Build service tests

Author: pashidlos

src/builds/builds.service.spec.ts

@@ -3,24 +3,164 @@ import { BuildsService } from './builds.service';
 import { PrismaService } from '../prisma/prisma.service';
 import { TestRunsService } from '../test-runs/test-runs.service';
 import { EventsGateway } from '../events/events.gateway';
+import { CreateBuildDto } from './dto/build-create.dto';
+import { Build, TestRun } from '@prisma/client';
+import { mocked } from 'ts-jest/utils';
+import { BuildDto } from './dto/build.dto';
+
+jest.mock('./dto/build.dto');
+
+const initService = async ({
+  buildFindManyMock = jest.fn(),
+  buildCreateMock = jest.fn(),
+  buildFindOneMock = jest.fn(),
+  buildDeleteMock = jest.fn(),
+  testRunDeleteMock = jest.fn(),
+  eventsBuildCreatedMock = jest.fn(),
+}) => {
+  const module: TestingModule = await Test.createTestingModule({
+    providers: [
+      BuildsService,
+      {
+        provide: PrismaService,
+        useValue: {
+          build: {
+            findMany: buildFindManyMock,
+            create: buildCreateMock,
+            findOne: buildFindOneMock,
+            delete: buildDeleteMock,
+          },
+        },
+      },
+      {
+        provide: TestRunsService,
+        useValue: {
+          delete: testRunDeleteMock,
+        },
+      },
+      {
+        provide: EventsGateway,
+        useValue: {
+          buildCreated: eventsBuildCreatedMock,
+        },
+      },
+    ],
+  }).compile();
+
+  return module.get<BuildsService>(BuildsService);
+};
 
 describe('BuildsService', () => {
   let service: BuildsService;
 
-  beforeEach(async () => {
-    const module: TestingModule = await Test.createTestingModule({
-      providers: [
-        BuildsService,
-        { provide: PrismaService, useValue: {} },
-        { provide: TestRunsService, useValue: {} },
-        { provide: EventsGateway, useValue: {} },
-      ],
-    }).compile();
-
-    service = module.get<BuildsService>(BuildsService);
+  const build: Build & {
+    testRuns: TestRun[];
+  } = {
+    id: 'a9385fc1-884d-4f9f-915e-40da0e7773d5',
+    number: null,
+    branchName: 'develop',
+    status: null,
+    projectId: 'e0a37894-6f29-478d-b13e-6182fecc715e',
+    updatedAt: new Date(),
+    createdAt: new Date(),
+    userId: null,
+    testRuns: [
+      {
+        id: '10fb5e02-64e0-4cf5-9f17-c00ab3c96658',
+        imageName: '1592423768112.screenshot.png',
+        diffName: null,
+        diffPercent: null,
+        diffTollerancePercent: 1,
+        pixelMisMatchCount: null,
+        status: 'new',
+        buildId: '146e7a8d-89f0-4565-aa2c-e61efabb0afd',
+        testVariationId: '3bc4a5bc-006e-4d43-8e4e-eaa132627fca',
+        updatedAt: new Date(),
+        createdAt: new Date(),
+        name: 'ss2f77',
+        browser: 'chromium',
+        device: null,
+        os: null,
+        viewport: '1800x1600',
+        baselineName: null,
+        ignoreAreas: '[]',
+      },
+    ],
+  };
+
+  const buildDto: BuildDto = {
+    id: 'a9385fc1-884d-4f9f-915e-40da0e7773d5',
+    number: null,
+    branchName: 'develop',
+    status: 'new',
+    projectId: 'e0a37894-6f29-478d-b13e-6182fecc715e',
+    updatedAt: new Date(),
+    createdAt: new Date(),
+    userId: null,
+    passedCount: 0,
+    unresolvedCount: 0,
+    failedCount: 0,
+  };
+
+  it('findMany', async () => {
+    const buildFindManyMock = jest.fn().mockResolvedValueOnce([build]);
+    const projectId = 'someId';
+    mocked(BuildDto).mockReturnValueOnce(buildDto);
+    service = await initService({ buildFindManyMock });
+
+    const result = await service.findMany(projectId);
+
+    expect(buildFindManyMock).toHaveBeenCalledWith({
+      include: { testRuns: true },
+      orderBy: { createdAt: 'desc' },
+      where: { projectId },
+    });
+    expect(result).toEqual([buildDto]);
   });
 
-  it('should be defined', () => {
-    expect(service).toBeDefined();
+  it('create', async () => {
+    const createBuildDto: CreateBuildDto = {
+      branchName: 'branchName',
+      projectId: 'projectId',
+    };
+    const buildCreateMock = jest.fn().mockResolvedValueOnce(build);
+    const eventsBuildCreatedMock = jest.fn();
+    mocked(BuildDto).mockReturnValueOnce(buildDto);
+    service = await initService({ buildCreateMock, eventsBuildCreatedMock });
+
+    const result = await service.create(createBuildDto);
+
+    expect(buildCreateMock).toHaveBeenCalledWith({
+      data: {
+        branchName: createBuildDto.branchName,
+        project: {
+          connect: {
+            id: createBuildDto.projectId,
+          },
+        },
+      },
+    });
+    expect(eventsBuildCreatedMock).toHaveBeenCalledWith(buildDto);
+    expect(result).toBe(buildDto);
+  });
+
+  it('delete', async () => {
+    const buildFindOneMock = jest.fn().mockResolvedValueOnce(build);
+    const buildDeleteMock = jest.fn();
+    const testRunDeleteMock = jest.fn();
+    service = await initService({ buildFindOneMock, buildDeleteMock, testRunDeleteMock });
+
+    await service.remove(build.id);
+
+    expect(buildFindOneMock).toHaveBeenCalledWith({
+      where: { id: build.id },
+      include: {
+        testRuns: true,
+      },
+    });
+    expect(testRunDeleteMock).toHaveBeenCalledWith(build.testRuns[0].id);
+    expect(buildDeleteMock).toHaveBeenCalledWith({
+      where: { id: build.id },
+    });
   });
 });

src/builds/builds.service.ts

@@ -36,9 +36,6 @@ export class BuildsService {
           },
         },
       },
-      include: {
-        testRuns: true,
-      },
     });
     const buildDto = new BuildDto(build);
     this.eventsGateway.buildCreated(buildDto);
@@ -53,11 +50,7 @@ export class BuildsService {
       },
     });
 
-    try {
-      await Promise.all(build.testRuns.map(testRun => this.testRunsService.delete(testRun.id)));
-    } catch (err) {
-      console.log(err);
-    }
+    await Promise.all(build.testRuns.map(testRun => this.testRunsService.delete(testRun.id)));
 
     return this.prismaService.build.delete({
       where: { id },