e2e tests added

Author: pashidlos

src/builds/builds.controller.ts

@@ -1,7 +1,7 @@
 import { Controller, Get, UseGuards, Post, Body, Param, ParseUUIDPipe, Delete, Query, Patch } from '@nestjs/common';
 import { BuildsService } from './builds.service';
 import { JwtAuthGuard } from '../auth/guards/auth.guard';
-import { ApiBearerAuth, ApiTags, ApiParam, ApiSecurity, ApiQuery, ApiResponse } from '@nestjs/swagger';
+import { ApiBearerAuth, ApiTags, ApiSecurity, ApiResponse } from '@nestjs/swagger';
 import { CreateBuildDto } from './dto/build-create.dto';
 import { ApiGuard } from '../auth/guards/api.guard';
 import { Build } from '@prisma/client';
@@ -13,7 +13,6 @@ export class BuildsController {
   constructor(private buildsService: BuildsService) {}
 
   @Get()
-  @ApiQuery({ name: 'projectId', required: true })
   @ApiResponse({ type: [BuildDto] })
   @ApiBearerAuth()
   @UseGuards(JwtAuthGuard)
@@ -22,7 +21,6 @@ export class BuildsController {
   }
 
   @Delete(':id')
-  @ApiParam({ name: 'id', required: true })
   @ApiBearerAuth()
   @UseGuards(JwtAuthGuard)
   remove(@Param('id', new ParseUUIDPipe()) id: string): Promise<Build> {
@@ -37,7 +35,7 @@ export class BuildsController {
     return this.buildsService.create(createBuildDto);
   }
 
-  @Patch()
+  @Patch(':id')
   @ApiResponse({ type: BuildDto })
   @ApiSecurity('api_key')
   @UseGuards(ApiGuard)

test/builds.e2e-spec.ts

@@ -52,12 +52,13 @@ describe('Builds (e2e)', () => {
       };
       return requestWithApiKey(app, 'post', '/builds', createBuildDto, user.apiKey)
         .expect(201)
-        .expect(res => {
+        .expect((res) => {
           expect(res.body.projectId).toBe(project.id);
           expect(res.body.branchName).toBe(createBuildDto.branchName);
           expect(res.body.failedCount).toBe(0);
           expect(res.body.passedCount).toBe(0);
           expect(res.body.unresolvedCount).toBe(0);
+          expect(res.body.isRunning).toBe(true);
         });
     });
 
@@ -68,15 +69,16 @@ describe('Builds (e2e)', () => {
       };
       return requestWithApiKey(app, 'post', '/builds', createBuildDto, user.apiKey)
         .expect(201)
-        .expect(res => {
+        .expect((res) => {
           expect(res.body.projectId).toBe(project.id);
           expect(res.body.branchName).toBe(createBuildDto.branchName);
           expect(res.body.failedCount).toBe(0);
           expect(res.body.passedCount).toBe(0);
           expect(res.body.unresolvedCount).toBe(0);
+          expect(res.body.isRunning).toBe(true);
         });
     });
-    
+
     it('404', () => {
       const createBuildDto: CreateBuildDto = {
         branchName: 'branchName',
@@ -100,7 +102,7 @@ describe('Builds (e2e)', () => {
 
       return requestWithAuth(app, 'get', `/builds?projectId=${project.id}`, {}, user.token)
         .expect(200)
-        .expect(res => {
+        .expect((res) => {
           expect(JSON.stringify(res.body)).toEqual(JSON.stringify([build]));
         });
     });
@@ -123,4 +125,23 @@ describe('Builds (e2e)', () => {
       return requestWithAuth(app, 'delete', `/builds/${build.id}`, {}, '').expect(401);
     });
   });
+
+  describe('PATCH /', () => {
+    it('200', async () => {
+      const build = await buildsService.create({ project: project.id, branchName: 'develop' });
+
+      return requestWithApiKey(app, 'patch', `/builds/${build.id}`, {}, user.apiKey)
+        .expect(200)
+        .expect((res) => {
+          expect(res.body.projectId).toBe(project.id);
+          expect(res.body.isRunning).toBe(false);
+        });
+    });
+
+    it('401', async () => {
+      const build = await buildsService.create({ project: project.id, branchName: 'develop' });
+
+      return requestWithAuth(app, 'patch', `/builds/${build.id}`, {}, '').expect(401);
+    });
+  });
 });

test/preconditions.ts

@@ -14,7 +14,7 @@ export const generateUser = (
 
 export const requestWithAuth = (
   app: INestApplication,
-  method: 'post' | 'get' | 'put' | 'delete',
+  method: 'post' | 'get' | 'put' | 'delete' | 'patch',
   url: string,
   body = {},
   token: string
@@ -26,15 +26,11 @@ export const requestWithAuth = (
 
 export const requestWithApiKey = (
   app: INestApplication,
-  method: 'post' | 'get' | 'put' | 'delete',
+  method: 'post' | 'get' | 'put' | 'delete' | 'patch',
   url: string,
   body = {},
   apiKey: string
-): Test =>
-  request(app.getHttpServer())
-    [method](url)
-    .set('apiKey', apiKey)
-    .send(body);
+): Test => request(app.getHttpServer())[method](url).set('apiKey', apiKey).send(body);
 
 export const haveUserLogged = async (usersService: UsersService) => {
   const password = '123456';