Performance issue while approving whole build #246

Author: pashidlos

src/builds/builds.controller.ts

@@ -83,7 +83,7 @@ export class BuildsController {
   approve(
     @Param('id', new ParseUUIDPipe()) id: string,
     @Query('merge', new ParseBoolPipe()) merge: boolean
-  ): Promise<BuildDto> {
+  ): Promise<void> {
     return this.buildsService.approve(id, merge);
   }
 }

src/builds/builds.service.spec.ts

@@ -317,6 +317,5 @@ describe('BuildsService', () => {
       },
     });
     expect(testRunApproveMock).toHaveBeenCalledWith(build.testRuns[0].id, true);
-    expect(service.findOne).toHaveBeenCalledWith('someId');
   });
 });

src/builds/builds.service.ts

@@ -123,7 +123,7 @@ export class BuildsService {
     });
   }
 
-  async approve(id: string, merge: boolean): Promise<BuildDto> {
+  async approve(id: string, merge: boolean): Promise<void> {
     const build = await this.prismaService.build.findUnique({
       where: { id },
       include: {
@@ -137,8 +137,8 @@ export class BuildsService {
       },
     });
 
-    await Promise.all(build.testRuns.map((testRun) => this.testRunsService.approve(testRun.id, merge)));
-
-    return this.findOne(id);
+    for(const testRun of build.testRuns) {
+      await this.testRunsService.approve(testRun.id, merge)
+    }
   }
 }

test/builds.e2e-spec.ts

@@ -212,8 +212,9 @@ describe('Builds (e2e)', () => {
         false
       );
 
-      const result = await buildsService.approve(build.id, false);
+      await buildsService.approve(build.id, false);
 
+      const result = await buildsService.findOne(build.id);
       expect(result).toEqual({ ...build, status: 'passed', passedCount: 1, merge: false });
     });
 
@@ -227,8 +228,9 @@ describe('Builds (e2e)', () => {
         true
       );
 
-      const result = await buildsService.approve(build.id, true);
+      await buildsService.approve(build.id, true);
 
+      const result = await buildsService.findOne(build.id);
       expect(result).toEqual({ ...build, status: 'passed', passedCount: 1, merge: true });
     });
   });