getDiff produces error in case odiff lib

[oleg-rd]

If image comparison library is set to odiff, there is an error from getDiff method of OdiffService:

ERROR TypeError: this.hddService.generateNewImage is not a function
    at OdiffService.getDiff (/dist/compare/libs/odiff/odiff.service.js:46:38)
    at CompareService.getDiff (/dist/compare/compare.service.js:30:27)
    at async TestRunsService.calculateDiff (/dist/test-runs/test-runs.service.js:149:28)
    at async TestRunsService.postTestRun (/dist/test-runs/test-runs.service.js:71:33)

I think it was introduced in scope of the changes of this pull request. Based on my understanding, now hddService field in OdiffService class references to StaticService object and this guy doesn't have generateNewImage function. Not sure what would be the best way to address this - neither adding this function to the Static interface nor exposing staticService field from StaticService looks as a right way to go.

@pashidlos could you take a look?

backend version: 5.0.11
ui version: 5.0.4

[pashidlos]

@oleg-rd thanks for the request
do you use aws as a static service?
originally I suppose to throw exception as there is no way to pass image but only real path to it
and if static service real type is AWS than this error make sense
https://github.com/Visual-Regression-Tracker/backend/blob/master/src/compare/libs/odiff/odiff.service.ts#L29

to use aws with odiff we might do the do the flowing workaround:

• download images from aws
• save them to file
• get diff as file
• upload to aws

unfortunately it might slow the process down

[oleg-rd]

@pashidlos yeah, I've seen that check in constructor, but in my case STATIC_SERVICE is set to hdd

[pashidlos]

@oleg-rd should be fixed in next release