Skip to content

Commit c54a263

Browse files
authored
TestRun list. Next/Prev buttons ignores sorting (#224)
* TestRun list. Next/Prev buttons ignores sorting closes Visual-Regression-Tracker/Visual-Regression-Tracker#286 * Update Header.spec.tsx
1 parent d95b959 commit c54a263

23 files changed

+159
-119
lines changed

package-lock.json

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"private": true,
55
"dependencies": {
66
"@material-ui/core": "^4.11.2",
7-
"@material-ui/data-grid": "^4.0.0-alpha.34",
7+
"@material-ui/data-grid": "^4.0.0-alpha.35",
88
"@material-ui/icons": "^4.11.2",
99
"@material-ui/lab": "^4.0.0-alpha.57",
1010
"@testing-library/jest-dom": "^5.11.1",

src/App.jsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { SnackbarProvider } from "notistack";
33
import { Box } from "@material-ui/core";
44
import Header from "./components/Header";
55
import {
6-
AuthProvider,
6+
UserProvider,
77
ProjectProvider,
88
BuildProvider,
99
TestRunProvider,
@@ -14,7 +14,7 @@ import Router from "./Router";
1414
function App() {
1515
return (
1616
<SnackbarProvider maxSnack={3}>
17-
<AuthProvider>
17+
<UserProvider>
1818
<ProjectProvider>
1919
<BuildProvider>
2020
<TestRunProvider>
@@ -29,7 +29,7 @@ function App() {
2929
</TestRunProvider>
3030
</BuildProvider>
3131
</ProjectProvider>
32-
</AuthProvider>
32+
</UserProvider>
3333
</SnackbarProvider>
3434
);
3535
}

src/_test/test.moun.helper.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import React from "react";
22
import { mount } from "@cypress/react";
33
import {
44
ProjectProvider,
5-
AuthProvider,
5+
UserProvider,
66
BuildProvider,
77
TestRunProvider,
88
} from "../contexts";
@@ -23,13 +23,13 @@ export const mountVrtComponent = ({
2323
<MemoryRouter {...memoryRouterProps}>
2424
<Route path={path}>
2525
<SnackbarProvider>
26-
<AuthProvider>
26+
<UserProvider>
2727
<ProjectProvider>
2828
<BuildProvider>
2929
<TestRunProvider>{component}</TestRunProvider>
3030
</BuildProvider>
3131
</ProjectProvider>
32-
</AuthProvider>
32+
</UserProvider>
3333
</SnackbarProvider>
3434
</Route>
3535
</MemoryRouter>,

src/components/Header.spec.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
import React from "react";
33
import { mount } from "@cypress/react";
44
import Header from "./Header";
5-
import { AuthProvider } from "../contexts";
5+
import { UserProvider } from "../contexts";
66
import { BrowserRouter } from "react-router-dom";
77
import { haveUserLogged } from "../_test/precondition.helper";
88
import { TEST_USER } from "../_test/test.data.helper";
@@ -13,9 +13,9 @@ describe("Header", () => {
1313
localStorage.clear();
1414
mount(
1515
<BrowserRouter>
16-
<AuthProvider>
16+
<UserProvider>
1717
<Header />
18-
</AuthProvider>
18+
</UserProvider>
1919
</BrowserRouter>
2020
);
2121

@@ -26,9 +26,9 @@ describe("Header", () => {
2626
haveUserLogged(TEST_USER);
2727
mount(
2828
<BrowserRouter>
29-
<AuthProvider>
29+
<UserProvider>
3030
<Header />
31-
</AuthProvider>
31+
</UserProvider>
3232
</BrowserRouter>
3333
);
3434

src/components/Header.tsx

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,14 @@ import {
99
MenuItem,
1010
} from "@material-ui/core";
1111
import { Link } from "react-router-dom";
12-
import { useAuthState, useAuthDispatch, logout } from "../contexts";
12+
import { useUserDispatch, useUserState, logout } from "../contexts";
1313
import { routes } from "../constants";
1414
import logo from "../static/logo.png";
15-
import { Role } from "../types";
1615

1716
const Header: FunctionComponent = () => {
1817
const [menuRef, setMenuRef] = React.useState<null | HTMLElement>(null);
19-
const { loggedIn, user } = useAuthState();
20-
const authDispatch = useAuthDispatch();
18+
const { loggedIn, user } = useUserState();
19+
const authDispatch = useUserDispatch();
2120

2221
const handleMenuClose = () => {
2322
setMenuRef(null);
@@ -33,7 +32,7 @@ const Header: FunctionComponent = () => {
3332
open={!!menuRef}
3433
onClose={handleMenuClose}
3534
>
36-
{user?.role === Role.admin && (
35+
{user?.role === "admin" && (
3736
<MenuItem
3837
component={Link}
3938
to={routes.USER_LIST_PAGE}

src/components/LoginForm.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import {
88
CardActions,
99
Typography,
1010
} from "@material-ui/core";
11-
import { useAuthDispatch, login } from "../contexts";
11+
import { useUserDispatch, login } from "../contexts";
1212
import { routes } from "../constants";
1313
import { useSnackbar } from "notistack";
1414
import { TextValidator, ValidatorForm } from "react-material-ui-form-validator";
@@ -17,7 +17,7 @@ const LoginForm = () => {
1717
const { enqueueSnackbar } = useSnackbar();
1818
const [email, setEmail] = useState("");
1919
const [password, setPassword] = useState("");
20-
const dispatch = useAuthDispatch();
20+
const dispatch = useUserDispatch();
2121

2222
const handleSubmit = (event: FormEvent) => {
2323
event.preventDefault();

src/components/PrivateRoute.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
import React from "react";
22
import { Redirect, Route, RouteProps } from "react-router-dom";
3-
import { useAuthState } from "../contexts";
3+
import { useUserState } from "../contexts";
44
import { routes } from "../constants";
55

66
const PrivateRoute: React.FunctionComponent<RouteProps> = ({
77
component: Component,
88
...rest
99
}) => {
10-
const { loggedIn } = useAuthState();
10+
const { loggedIn } = useUserState();
1111
if (!Component) {
1212
return null;
1313
}

src/components/RegisterForm.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import {
66
CardContent,
77
CardActions,
88
} from "@material-ui/core";
9-
import { useAuthDispatch, login } from "../contexts";
9+
import { useUserDispatch, login } from "../contexts";
1010
import { usersService } from "../services";
1111
import { useSnackbar } from "notistack";
1212
import { TextValidator, ValidatorForm } from "react-material-ui-form-validator";
@@ -17,7 +17,7 @@ const RegisterForm = () => {
1717
const [firstName, setFirstName] = useState("");
1818
const [lastName, setLastName] = useState("");
1919
const [password, setPassword] = useState("");
20-
const dispatch = useAuthDispatch();
20+
const dispatch = useUserDispatch();
2121

2222
const handleSubmit = (event: FormEvent) => {
2323
event.preventDefault();

src/components/ArrowButtons.tsx renamed to src/components/TestDetailsDialog/ArrowButtons.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@ import { IconButton, makeStyles, Tooltip } from "@material-ui/core";
22
import { NavigateNext, NavigateBefore } from "@material-ui/icons";
33
import React from "react";
44
import { useHotkeys } from "react-hotkeys-hook";
5-
import { useTestRunDispatch, selectTestRun } from "../contexts";
6-
import { TestRun } from "../types";
5+
import { useTestRunDispatch, selectTestRun } from "../../contexts";
6+
import { TestRun } from "../../types";
77

88
const useStyles = makeStyles((theme) => ({
99
button: {

0 commit comments

Comments
 (0)