Skip to content

Commit 2a49bc3

Browse files
authored
Updated code to use the new Enum values (#8)
* Added unit tests Updated switch statement Update version * Changed unit tests * Corrected test Track_UnexpectedStatusThrownIfNotSoftAssert * Simnplified the Track Unit unit tests * Minor change * Adde curly brackets
1 parent 1051591 commit 2a49bc3

File tree

3 files changed

+25
-8
lines changed

3 files changed

+25
-8
lines changed

VisualRegressionTracker/VisualRegressionTracker.cs

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,9 @@ protected async Task<TestRunResult> SubmitTestRun(
151151
"new" => TestRunStatus.New,
152152
"ok" => TestRunStatus.Ok,
153153
"unresolved" => TestRunStatus.Unresolved,
154+
"failed" => TestRunStatus.Failed,
155+
"approved" => TestRunStatus.Approved,
156+
"autoApproved" => TestRunStatus.AutoApproved,
154157
_ => throw new VisualRegressionTrackerError("Unexpected status")
155158
};
156159

@@ -200,6 +203,11 @@ public async Task<TestRunResult> Track(
200203

201204
var result = await SubmitTestRun(dto, cancellationToken).ConfigureAwait(false);
202205

206+
if (result.Status == TestRunStatus.AutoApproved)
207+
{
208+
return result;
209+
}
210+
203211
if (!config.EnableSoftAssert && result.Status != TestRunStatus.Ok)
204212
{
205213
throw new VisualRegressionTrackerError(result.Status switch

VisualRegressionTracker/VisualRegressionTracker.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<PropertyGroup>
33
<TargetFramework>net5.0</TargetFramework>
44
<PackageId>VisualRegressionTracker</PackageId>
5-
<Version>4.7.2</Version>
5+
<Version>4.7.3</Version>
66
<Authors>Daniel Crowe</Authors>
77
<Company>Visual Regression Tracker</Company>
88
<PackageLicenseExpression>Apache-2.0</PackageLicenseExpression>

tests/VisualRegressionTracker.Tests/VisualRegressionTrackerTests.cs

Lines changed: 16 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -322,9 +322,11 @@ await Assert.ThrowsAsync<VisualRegressionTrackerError>(async () => {
322322
}
323323

324324
[Theory]
325-
[InlineData("new", "No baseline: Url1")]
326-
[InlineData("unresolved", "Difference found: Url1")]
327-
public async Task Track_ThrowsIfNotOk(string status, string expectedMessage)
325+
[InlineData(false, "approved", "Unexpected status")]
326+
[InlineData(false, "failed", "Unexpected status")]
327+
[InlineData(false, "new", "No baseline: Url1")]
328+
[InlineData(false, "unresolved", "Difference found: Url1")]
329+
public async Task Track_ThrowsVisualRegressionTrackerError(bool enableSoftAssert, string status, string expectedMessage)
328330
{
329331
await Start();
330332

@@ -346,6 +348,7 @@ public async Task Track_ThrowsIfNotOk(string status, string expectedMessage)
346348
HttpStatusCode.Created,
347349
responseDto
348350
);
351+
config.EnableSoftAssert = enableSoftAssert;
349352

350353
var ex = await Assert.ThrowsAsync<VisualRegressionTrackerError>(async () =>
351354
{
@@ -356,9 +359,15 @@ public async Task Track_ThrowsIfNotOk(string status, string expectedMessage)
356359
}
357360

358361
[Theory]
359-
[InlineData("new", TestRunStatus.New)]
360-
[InlineData("unresolved", TestRunStatus.Unresolved)]
361-
public async Task Track_DoesntThrowIfSoftAssert(string status, TestRunStatus expectedStatus)
362+
[InlineData(true, "approved", TestRunStatus.Approved)]
363+
[InlineData(false, "autoApproved", TestRunStatus.AutoApproved)]
364+
[InlineData(true, "autoApproved", TestRunStatus.AutoApproved)]
365+
[InlineData(true, "failed", TestRunStatus.Failed)]
366+
[InlineData(true, "new", TestRunStatus.New)]
367+
[InlineData(false, "ok", TestRunStatus.Ok)]
368+
[InlineData(true, "ok", TestRunStatus.Ok)]
369+
[InlineData(true, "unresolved", TestRunStatus.Unresolved)]
370+
public async Task Track_ReturnStatus(bool enableSoftAssert, string status, TestRunStatus expectedStatus)
362371
{
363372
await Start();
364373

@@ -381,7 +390,7 @@ public async Task Track_DoesntThrowIfSoftAssert(string status, TestRunStatus exp
381390
responseDto
382391
);
383392

384-
config.EnableSoftAssert = true;
393+
config.EnableSoftAssert = enableSoftAssert;
385394
var result = await vrt.Track("image name", "image base 64");
386395

387396
Assert.Equal(expectedStatus, result.Status);

0 commit comments

Comments
 (0)