Comments, renames, AddComponent paths

arthurkehrwald · arthurkehrwald · commit 1d97adf92739 · 2025-03-30T14:51:58.000+02:00
diff --git a/Editor/Inspector/MpfEventSoundInspector.cs b/Editor/Inspector/MpfEventSoundInspector.cs
@@ -17,7 +17,7 @@
 
 namespace VisualPinball.Engine.Mpf.Unity.Editor
 {
-    [CustomEditor(typeof(MpfEventSound)), CanEditMultipleObjects]
+    [CustomEditor(typeof(EventSound)), CanEditMultipleObjects]
     public class MpfEventSoundInspector : SoundComponentInspector
     {
         [SerializeField]
diff --git a/Editor/Inspector/MpfModeSoundInspector.cs b/Editor/Inspector/MpfModeSoundInspector.cs
@@ -17,7 +17,7 @@
 
 namespace VisualPinball.Engine.Mpf.Unity.Editor
 {
-    [CustomEditor(typeof(MpfModeSound)), CanEditMultipleObjects]
+    [CustomEditor(typeof(ModeSound)), CanEditMultipleObjects]
     public class MpfModeSoundInspector : BinaryEventSoundInspector
     {
         [SerializeField]
diff --git a/Runtime/MediaController/Messages/Trigger/MpfEventListener.cs b/Runtime/MediaController/Messages/Trigger/MpfEventListener.cs
@@ -14,9 +14,11 @@
 
 namespace VisualPinball.Engine.Mpf.Unity.MediaController.Messages.Trigger
 {
+    /// <summary>
+    /// Provides an event handler for arbitrary MPF events
+    /// </summary>
     public class MpfEventListener : IDisposable
     {
-        [SerializeField]
         private string _eventName;
 
         private BcpInterface _bcpInterface;
diff --git a/Runtime/MediaController/Sound/EventSound.cs b/Runtime/MediaController/Sound/EventSound.cs
@@ -16,8 +16,8 @@
 
 namespace VisualPinball.Engine.Mpf.Unity.MediaController.Sound
 {
-    [AddComponentMenu("Visual Pinball/Sound/Mpf Event Sound")]
-    public class MpfEventSound : EventSoundComponent<MpfEventListener, EventArgs>
+    [AddComponentMenu("Pinball/Sound/MPF Event Sound")]
+    public class EventSound : EventSoundComponent<MpfEventListener, EventArgs>
     {
         [SerializeField]
         private string _eventName;
diff --git a/Runtime/MediaController/Sound/EventSound.cs.meta b/Runtime/MediaController/Sound/EventSound.cs.meta
diff --git a/Runtime/MediaController/Sound/ModeSound.cs b/Runtime/MediaController/Sound/ModeSound.cs
@@ -15,8 +15,8 @@
 
 namespace VisualPinball.Engine.Mpf.Unity.MediaController.Sound
 {
-    [AddComponentMenu("Visual Pinball/Sound/Mpf Mode Sound")]
-    public class MpfModeSound : BinaryEventSoundComponent<ModeMonitor, bool>
+    [AddComponentMenu("Pinball/Sound/MPF Mode Sound")]
+    public class ModeSound : BinaryEventSoundComponent<ModeMonitor, bool>
     {
         [SerializeField]
         private string _modeName;
diff --git a/Runtime/MediaController/Sound/ModeSound.cs.meta b/Runtime/MediaController/Sound/ModeSound.cs.meta
diff --git a/Runtime/MediaController/Text/CurrentPlayerText.cs b/Runtime/MediaController/Text/CurrentPlayerText.cs
@@ -9,11 +9,13 @@
 // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 // SOFTWARE.
 
+using UnityEngine;
 using VisualPinball.Engine.Mpf.Unity.MediaController.Messages;
 using VisualPinball.Engine.Mpf.Unity.MediaController.Messages.PlayerTurnStart;
 
 namespace VisualPinball.Engine.Mpf.Unity.MediaController.Text
 {
+    [AddComponentMenu("Pinball/MPF Media Controller/MPF Current Player Text")]
     public class CurrentPlayerText : MonitoredVariableText<int, PlayerTurnStartMessage>
     {
         protected override MonitorBase<int, PlayerTurnStartMessage> CreateMonitor(
diff --git a/Runtime/MediaController/Text/MachineVariable/FloatMachineVariableText.cs b/Runtime/MediaController/Text/MachineVariable/FloatMachineVariableText.cs
@@ -9,7 +9,10 @@
 // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 // SOFTWARE.
 
+using UnityEngine;
+
 namespace VisualPinball.Engine.Mpf.Unity.MediaController.Text
 {
+    [AddComponentMenu("Pinball/MPF Media Controller/MPF Machine Variable Text (Float)")]
     public class FloatMachineVariableText : MachineVariableText<float> { }
 }
diff --git a/Runtime/MediaController/Text/MachineVariable/IntMachineVariableText.cs b/Runtime/MediaController/Text/MachineVariable/IntMachineVariableText.cs
@@ -9,7 +9,10 @@
 // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 // SOFTWARE.
 
+using UnityEngine;
+
 namespace VisualPinball.Engine.Mpf.Unity.MediaController.Text
 {
+    [AddComponentMenu("Pinball/MPF Media Controller/MPF Machine Variable Text (Int)")]
     public class IntMachineVariableText : MachineVariableText<int> { }
 }
diff --git a/Runtime/MediaController/Text/MachineVariable/StringMachineVariableText.cs b/Runtime/MediaController/Text/MachineVariable/StringMachineVariableText.cs
@@ -9,7 +9,10 @@
 // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 // SOFTWARE.
 
+using UnityEngine;
+
 namespace VisualPinball.Engine.Mpf.Unity.MediaController.Text
 {
+    [AddComponentMenu("Pinball/MPF Media Controller/MPF Machine Variable Text (String)")]
     public class StringMachineVariableText : MachineVariableText<string> { }
 }
diff --git a/Runtime/MediaController/Text/PlayerCountText.cs b/Runtime/MediaController/Text/PlayerCountText.cs
@@ -9,11 +9,13 @@
 // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 // SOFTWARE.
 
+using UnityEngine;
 using VisualPinball.Engine.Mpf.Unity.MediaController.Messages;
 using VisualPinball.Engine.Mpf.Unity.MediaController.Messages.PlayerAdded;
 
 namespace VisualPinball.Engine.Mpf.Unity.MediaController.Text
 {
+    [AddComponentMenu("Pinball/MPF Media Controller/MPF Player Count Text")]
     public class PlayerCountText : MonitoredVariableText<int, PlayerAddedMessage>
     {
         protected override MonitorBase<int, PlayerAddedMessage> CreateMonitor(
diff --git a/Runtime/MediaController/Text/PlayerVariable/FloatPlayerVariableText.cs b/Runtime/MediaController/Text/PlayerVariable/FloatPlayerVariableText.cs
@@ -9,7 +9,10 @@
 // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 // SOFTWARE.
 
+using UnityEngine;
+
 namespace VisualPinball.Engine.Mpf.Unity.MediaController.Text
 {
+    [AddComponentMenu("Pinball/MPF Media Controller/MPF Player Variable Text (Float)")]
     public class FloatPlayerVariableText : PlayerVariableText<float> { }
 }
diff --git a/Runtime/MediaController/Text/PlayerVariable/IntPlayerVariableText.cs b/Runtime/MediaController/Text/PlayerVariable/IntPlayerVariableText.cs
@@ -9,7 +9,10 @@
 // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 // SOFTWARE.
 
+using UnityEngine;
+
 namespace VisualPinball.Engine.Mpf.Unity.MediaController.Text
 {
+    [AddComponentMenu("Pinball/MPF Media Controller/MPF Player Variable Text (Int)")]
     public class IntPlayerVariableText : PlayerVariableText<int> { }
 }
diff --git a/Runtime/MediaController/Text/PlayerVariable/StringPlayerVariableText.cs b/Runtime/MediaController/Text/PlayerVariable/StringPlayerVariableText.cs
@@ -9,7 +9,10 @@
 // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 // SOFTWARE.
 
+using UnityEngine;
+
 namespace VisualPinball.Engine.Mpf.Unity.MediaController.Text
 {
+    [AddComponentMenu("Pinball/MPF Media Controller/MPF Player Variable Text (String)")]
     public class StringPlayerVariableText : PlayerVariableText<string> { }
 }
diff --git a/Runtime/MpfGamelogicEngine.cs b/Runtime/MpfGamelogicEngine.cs
@@ -29,6 +29,7 @@ namespace VisualPinball.Engine.Mpf.Unity
     /// Allows the Mission Pinball Framework to drive VPE by sending switch changes to MPF
     /// and applying changes to coils, lights and hardware rules requested by MPF.
     /// </summary>
+    [AddComponentMenu("Pinball/Gamelogic Engine/MPF Game Logic")]
     public class MpfGamelogicEngine : MonoBehaviour, IGamelogicEngine
     {
         [SerializeField]

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@`
`17`	`17`
`18`	`18`	`namespace VisualPinball.Engine.Mpf.Unity.Editor`
`19`	`19`	`{`
`20`		`- [CustomEditor(typeof(MpfEventSound)), CanEditMultipleObjects]`
	`20`	`+ [CustomEditor(typeof(EventSound)), CanEditMultipleObjects]`
`21`	`21`	`public class MpfEventSoundInspector : SoundComponentInspector`
`22`	`22`	`{`
`23`	`23`	`[SerializeField]`
Original file line number	Diff line number	Diff line change
`@@ -14,9 +14,11 @@`
`14`	`14`
`15`	`15`	`namespace VisualPinball.Engine.Mpf.Unity.MediaController.Messages.Trigger`
`16`	`16`	`{`
	`17`	`+ /// <summary>`
	`18`	`+ /// Provides an event handler for arbitrary MPF events`
	`19`	`+ /// </summary>`
`17`	`20`	`public class MpfEventListener : IDisposable`
`18`	`21`	`{`
`19`		`- [SerializeField]`
`20`	`22`	`private string _eventName;`
`21`	`23`
`22`	`24`	`private BcpInterface _bcpInterface;`
Original file line number	Diff line number	Diff line change
`@@ -16,8 +16,8 @@`
`16`	`16`
`17`	`17`	`namespace VisualPinball.Engine.Mpf.Unity.MediaController.Sound`
`18`	`18`	`{`
`19`		`- [AddComponentMenu("Visual Pinball/Sound/Mpf Event Sound")]`
`20`		`- public class MpfEventSound : EventSoundComponent<MpfEventListener, EventArgs>`
	`19`	`+ [AddComponentMenu("Pinball/Sound/MPF Event Sound")]`
	`20`	`+ public class EventSound : EventSoundComponent<MpfEventListener, EventArgs>`
`21`	`21`	`{`
`22`	`22`	`[SerializeField]`
`23`	`23`	`private string _eventName;`
Original file line number	Diff line number	Diff line change
`@@ -15,8 +15,8 @@`
`15`	`15`
`16`	`16`	`namespace VisualPinball.Engine.Mpf.Unity.MediaController.Sound`
`17`	`17`	`{`
`18`		`- [AddComponentMenu("Visual Pinball/Sound/Mpf Mode Sound")]`
`19`		`- public class MpfModeSound : BinaryEventSoundComponent<ModeMonitor, bool>`
	`18`	`+ [AddComponentMenu("Pinball/Sound/MPF Mode Sound")]`
	`19`	`+ public class ModeSound : BinaryEventSoundComponent<ModeMonitor, bool>`
`20`	`20`	`{`
`21`	`21`	`[SerializeField]`
`22`	`22`	`private string _modeName;`
Original file line number	Diff line number	Diff line change
`@@ -9,11 +9,13 @@`
`9`	`9`	`// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE`
`10`	`10`	`// SOFTWARE.`
`11`	`11`
	`12`	`+using UnityEngine;`
`12`	`13`	`using VisualPinball.Engine.Mpf.Unity.MediaController.Messages;`
`13`	`14`	`using VisualPinball.Engine.Mpf.Unity.MediaController.Messages.PlayerTurnStart;`
`14`	`15`
`15`	`16`	`namespace VisualPinball.Engine.Mpf.Unity.MediaController.Text`
`16`	`17`	`{`
	`18`	`+ [AddComponentMenu("Pinball/MPF Media Controller/MPF Current Player Text")]`
`17`	`19`	`public class CurrentPlayerText : MonitoredVariableText<int, PlayerTurnStartMessage>`
`18`	`20`	`{`
`19`	`21`	`protected override MonitorBase<int, PlayerTurnStartMessage> CreateMonitor(`
Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,10 @@`
`9`	`9`	`// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE`
`10`	`10`	`// SOFTWARE.`
`11`	`11`
	`12`	`+using UnityEngine;`
	`13`	`+`
`12`	`14`	`namespace VisualPinball.Engine.Mpf.Unity.MediaController.Text`
`13`	`15`	`{`
	`16`	`+ [AddComponentMenu("Pinball/MPF Media Controller/MPF Machine Variable Text (Float)")]`
`14`	`17`	`public class FloatMachineVariableText : MachineVariableText<float> { }`
`15`	`18`	`}`