Merge pull request #10 from VisualStudioEX3/develop

José Miguel Sánchez Fernández · web-flow · commit 1df1605bab0b · 2021-04-01T03:35:22.000+02:00
Fixes build configuration and supress warnings.
diff --git a/DIV2.Format.Exporter.Tests/DIV2.Format.Exporter.Tests.csproj b/DIV2.Format.Exporter.Tests/DIV2.Format.Exporter.Tests.csproj
@@ -1,9 +1,15 @@
-<Project Sdk="Microsoft.NET.Sdk">
+﻿<Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
     <TargetFramework>netcoreapp3.1</TargetFramework>
 
     <IsPackable>false</IsPackable>
+
+    <Platforms>x64</Platforms>
+  </PropertyGroup>
+
+  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'">
+    <PlatformTarget>x64</PlatformTarget>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/DIV2.Format.Exporter.sln b/DIV2.Format.Exporter.sln
@@ -20,12 +20,11 @@ Global
 	GlobalSection(ProjectConfigurationPlatforms) = postSolution
 		{D809DD2D-A865-4395-805E-18BCBD1E0594}.Debug|x64.ActiveCfg = Debug|x64
 		{D809DD2D-A865-4395-805E-18BCBD1E0594}.Debug|x64.Build.0 = Debug|x64
-		{D809DD2D-A865-4395-805E-18BCBD1E0594}.Release|x64.ActiveCfg = Release|Any CPU
-		{D809DD2D-A865-4395-805E-18BCBD1E0594}.Release|x64.Build.0 = Release|Any CPU
-		{0490E65E-02FF-44BC-A874-27E47FDE9FE5}.Debug|x64.ActiveCfg = Debug|Any CPU
-		{0490E65E-02FF-44BC-A874-27E47FDE9FE5}.Debug|x64.Build.0 = Debug|Any CPU
-		{0490E65E-02FF-44BC-A874-27E47FDE9FE5}.Release|x64.ActiveCfg = Release|Any CPU
-		{0490E65E-02FF-44BC-A874-27E47FDE9FE5}.Release|x64.Build.0 = Release|Any CPU
+		{D809DD2D-A865-4395-805E-18BCBD1E0594}.Release|x64.ActiveCfg = Release|x64
+		{D809DD2D-A865-4395-805E-18BCBD1E0594}.Release|x64.Build.0 = Release|x64
+		{0490E65E-02FF-44BC-A874-27E47FDE9FE5}.Debug|x64.ActiveCfg = Debug|x64
+		{0490E65E-02FF-44BC-A874-27E47FDE9FE5}.Release|x64.ActiveCfg = Release|x64
+		{0490E65E-02FF-44BC-A874-27E47FDE9FE5}.Release|x64.Build.0 = Release|x64
 	EndGlobalSection
 	GlobalSection(SolutionProperties) = preSolution
 		HideSolutionNode = FALSE
diff --git a/DIV2.Format.Exporter/DIV2.Format.Exporter.csproj b/DIV2.Format.Exporter/DIV2.Format.Exporter.csproj
@@ -10,7 +10,7 @@
     <RepositoryUrl>https://github.com/VisualStudioEX3/DIV2.Format.Exporter</RepositoryUrl>
     <RepositoryType>GitHub</RepositoryType>
     <PackageTags>DIV DIV2 DIVGamesStudio DIVGamesStudio2 Games Graphics Tool Retro Windows Linux Mac</PackageTags>
-    <Platforms>AnyCPU;x64</Platforms>
+    <Platforms>x64</Platforms>
     <Version>1.0.1</Version>
     <NeutralLanguage>en</NeutralLanguage>
     <PackageReleaseNotes>- Updated ImageSharp to version 1.0.3.
@@ -22,23 +22,12 @@
     <PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>
   </PropertyGroup>
 
-  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
-    <PlatformTarget>AnyCPU</PlatformTarget>
-    <Optimize>false</Optimize>
-    <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
-  </PropertyGroup>
-
   <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">
     <PlatformTarget>AnyCPU</PlatformTarget>
     <Optimize>false</Optimize>
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
   </PropertyGroup>
 
-  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
-    <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
-    <DocumentationFile>D:\Projects\dotNET projects\DIV2.Format.Exporter\DIV2.Format.Exporter\DIV2.Format.Exporter.xml</DocumentationFile>
-  </PropertyGroup>
-
   <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'">
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
     <DocumentationFile>D:\Projects\dotNET projects\DIV2.Format.Exporter\DIV2.Format.Exporter\DIV2.Format.Exporter.xml</DocumentationFile>
diff --git a/DIV2.Format.Exporter/ExtensionMethods/StringExtensions.cs b/DIV2.Format.Exporter/ExtensionMethods/StringExtensions.cs
@@ -62,6 +62,8 @@ public static byte[] GetASCIIZString(this string text, int length)
             return buffer.ToByteArray();
         }
 
+
+#pragma warning disable CS0419 // Ambiguous reference in cref attribute
         /// <summary>
         /// Returns a secure hash code for this string.
         /// </summary>
@@ -72,6 +74,7 @@ public static int GetSecureHashCode(this string text)
         {
             return HashGenerator.CalculateHashCode(text);
         } 
+#pragma warning restore CS0419 // Ambiguous reference in cref attribute
         #endregion
     }
 }
diff --git a/DIV2.Format.Exporter/Interfaces/IAssetFile.cs b/DIV2.Format.Exporter/Interfaces/IAssetFile.cs
@@ -1,10 +1,12 @@
 ﻿namespace DIV2.Format.Exporter.Interfaces
 {
+#pragma warning disable CS1591 // Missing XML comment for publicly visible type or member
     public interface IAssetFile : IFormatValidable, ISerializableAsset
     {
         #region Methods & Functions
         bool Validate(string filename);
         void Save(string filename); 
         #endregion
     }
+#pragma warning restore CS1591 // Missing XML comment for publicly visible type or member
 }
diff --git a/DIV2.Format.Exporter/Interfaces/IFormatValidable.cs b/DIV2.Format.Exporter/Interfaces/IFormatValidable.cs
@@ -1,9 +1,11 @@
 ﻿namespace DIV2.Format.Exporter.Interfaces
 {
+#pragma warning disable CS1591 // Missing XML comment for publicly visible type or member
     public interface IFormatValidable
     {
         #region Methods & Functions
         bool Validate(byte[] buffer);
         #endregion
     }
+#pragma warning restore CS1591 // Missing XML comment for publicly visible type or member
 }
diff --git a/DIV2.Format.Exporter/Interfaces/ISerializableAsset.cs b/DIV2.Format.Exporter/Interfaces/ISerializableAsset.cs
@@ -2,11 +2,13 @@
 
 namespace DIV2.Format.Exporter.Interfaces
 {
+#pragma warning disable CS1591 // Missing XML comment for publicly visible type or member
     public interface ISerializableAsset
     {
         #region Methods & Functions
         byte[] Serialize();
         void Write(BinaryWriter stream);
         #endregion
     }
+#pragma warning restore CS1591 // Missing XML comment for publicly visible type or member
 }

Original file line number	Diff line number	Diff line change
`@@ -62,6 +62,8 @@ public static byte[] GetASCIIZString(this string text, int length)`
`62`	`62`	`return buffer.ToByteArray();`
`63`	`63`	`}`
`64`	`64`
	`65`	`+`
	`66`	`+#pragma warning disable CS0419 // Ambiguous reference in cref attribute`
`65`	`67`	`/// <summary>`
`66`	`68`	`/// Returns a secure hash code for this string.`
`67`	`69`	`/// </summary>`
`@@ -72,6 +74,7 @@ public static int GetSecureHashCode(this string text)`
`72`	`74`	`{`
`73`	`75`	`return HashGenerator.CalculateHashCode(text);`
`74`	`76`	`}`
	`77`	`+#pragma warning restore CS0419 // Ambiguous reference in cref attribute`
`75`	`78`	`#endregion`
`76`	`79`	`}`
`77`	`80`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,10 +1,12 @@`
`1`	`1`	`namespace DIV2.Format.Exporter.Interfaces`
`2`	`2`	`{`
	`3`	`+#pragma warning disable CS1591 // Missing XML comment for publicly visible type or member`
`3`	`4`	`public interface IAssetFile : IFormatValidable, ISerializableAsset`
`4`	`5`	`{`
`5`	`6`	`#region Methods & Functions`
`6`	`7`	`bool Validate(string filename);`
`7`	`8`	`void Save(string filename);`
`8`	`9`	`#endregion`
`9`	`10`	`}`
	`11`	`+#pragma warning restore CS1591 // Missing XML comment for publicly visible type or member`
`10`	`12`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,9 +1,11 @@`
`1`	`1`	`namespace DIV2.Format.Exporter.Interfaces`
`2`	`2`	`{`
	`3`	`+#pragma warning disable CS1591 // Missing XML comment for publicly visible type or member`
`3`	`4`	`public interface IFormatValidable`
`4`	`5`	`{`
`5`	`6`	`#region Methods & Functions`
`6`	`7`	`bool Validate(byte[] buffer);`
`7`	`8`	`#endregion`
`8`	`9`	`}`
	`10`	`+#pragma warning restore CS1591 // Missing XML comment for publicly visible type or member`
`9`	`11`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2,11 +2,13 @@`
`2`	`2`
`3`	`3`	`namespace DIV2.Format.Exporter.Interfaces`
`4`	`4`	`{`
	`5`	`+#pragma warning disable CS1591 // Missing XML comment for publicly visible type or member`
`5`	`6`	`public interface ISerializableAsset`
`6`	`7`	`{`
`7`	`8`	`#region Methods & Functions`
`8`	`9`	`byte[] Serialize();`
`9`	`10`	`void Write(BinaryWriter stream);`
`10`	`11`	`#endregion`
`11`	`12`	`}`
	`13`	`+#pragma warning restore CS1591 // Missing XML comment for publicly visible type or member`
`12`	`14`	`}`