Merge pull request #792 from johncbaur/VIX-3827

VIX-3827 Suppressed exception on Fixture clone

Author: jeffu231

src/Vixen.Modules/App/ColorGradients/ColorGradient.cs

@@ -287,13 +287,22 @@ public ColorGradient(ColorGradient other)
 		public ColorGradient(Color staticColor)
 			: this()
 		{
+			if (staticColor == null)
+			{
+				throw new ArgumentNullException(nameof(staticColor));
+			}
 			_colors.Clear();
 			_colors.Add(new ColorPoint(staticColor, 0));
 		}
 
 		public ColorGradient(IEnumerable<Color> colors)
 			: this()
 		{
+			if (colors == null)
+			{
+				throw new ArgumentNullException(nameof(colors));
+			}
+
 			_colors.Clear();
 			foreach (Color c in colors) {
 				_colors.Add(new ColorPoint(c, 0));
@@ -878,6 +887,11 @@ public object Clone()
 		/// <param name="other"></param>
 		public void CloneFrom(ColorGradient other)
 		{
+			if (other == null)
+			{
+				throw new ArgumentNullException(nameof(other));
+			}
+			
 			CloneDataFrom(other);
 
 			// grab all the library-linking details as well
@@ -891,6 +905,11 @@ public void CloneFrom(ColorGradient other)
 		/// <param name="other"></param>
 		public void CloneDataFrom(ColorGradient other)
 		{
+			if (other == null)
+			{
+				throw new ArgumentNullException(nameof(other));
+			}
+
 			_colors = new PointList<ColorPoint>();
 			foreach (ColorPoint cp in other.Colors) {
 				_colors.Add(new ColorPoint(cp));

src/Vixen.Modules/Effect/Fixture/FixtureEffect/Data/FixtureFunctionData.cs

@@ -22,7 +22,8 @@ public FixtureFunctionData()
 			FunctionIdentity = FunctionIdentity.Custom;
 			FunctionName = String.Empty;
 			Range = new Curve(new PointPairList(new[] { 0.0, 100.0 }, new[] { 0.0, 0.0 }));
-			TimelineColor = System.Drawing.Color.White;	
+			TimelineColor = System.Drawing.Color.White;
+			Color = new App.ColorGradients.ColorGradient();
 		}
 
 		#endregion
@@ -108,7 +109,7 @@ public FixtureFunctionData CreateInstanceForClone()
 		[OnDeserialized]
 		public void OnDeserialized(StreamingContext c)
 		{
-			//Ensure Color is populated
+			// Ensure Color is populated
 			Color ??= new App.ColorGradients.ColorGradient();
 		}