Merge pull request #760 from johncbaur/VIX-3673

jeffu231 · web-flow · commit 45bea7944467 · 2025-11-20T21:17:26.000-06:00
VIX-3763 Fixing Candle Flicker to stay within the user selected bounds
diff --git a/src/Vixen.Modules/Effect/Candle/CandleModule.cs b/src/Vixen.Modules/Effect/Candle/CandleModule.cs
@@ -284,7 +284,12 @@ private void _RenderCandleOnElements(List<IElementNode> elements)
 
 		private float _GenerateStartingLevel()
 		{
-			return (float) _r.NextDouble();
+			float startingLevel = (float)_r.NextDouble();
+
+			startingLevel = Math.Max(startingLevel, _data.MinLevel);
+			startingLevel = Math.Min(startingLevel, _data.MaxLevel);
+
+			return startingLevel;
 		}
 
 		private float _GenerateStateLength()

Original file line number	Diff line number	Diff line change
`@@ -284,7 +284,12 @@ private void _RenderCandleOnElements(List<IElementNode> elements)`
`284`	`284`
`285`	`285`	`private float _GenerateStartingLevel()`
`286`	`286`	`{`
`287`		`- return (float) _r.NextDouble();`
	`287`	`+ float startingLevel = (float)_r.NextDouble();`
	`288`	`+`
	`289`	`+ startingLevel = Math.Max(startingLevel, _data.MinLevel);`
	`290`	`+ startingLevel = Math.Min(startingLevel, _data.MaxLevel);`
	`291`	`+`
	`292`	`+ return startingLevel;`
`288`	`293`	`}`
`289`	`294`
`290`	`295`	`private float _GenerateStateLength()`