Merge pull request #128 from djsell/signed

add num_traits::Signed impl

Author: VoidStarKat

CHANGELOG.md

@@ -8,6 +8,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - `min` and `max` incorrectly propagate `NaN` values when `self` is `NaN`. Fixes [#126],
   by [@mgottscho].
 
+### Added
+- New `num-traits` implementations: `Signed` for `f16` and `bf16`.
+
 ## [2.6.0] - 2024-04-08 <a name="2.6.0"></a>
 ### Changed
 - Fixed some incorrect minimum supported versions of dependencies that weren't caught due to

README.md

@@ -39,7 +39,7 @@ See the [crate documentation](https://docs.rs/half/) for more details.
   dependency on the [`serde`](https://crates.io/crates/serde) crate.
 
 - **`num-traits`** — Enable `ToPrimitive`, `FromPrimitive`, `ToBytes`, `FromBytes`, `Num`, `Float`,
-  `FloatCore` and `Bounded` trait implementations from the
+  `FloatCore`, `Signed`, and `Bounded` trait implementations from the
   [`num-traits`](https://crates.io/crates/num-traits) crate.
 
 - **`bytemuck`** — Enable `Zeroable` and `Pod` trait implementations from the

src/lib.rs

@@ -89,7 +89,7 @@
 //!
 //! - **`num-traits`** — Adds support for the [`num-traits`] crate by implementing [`ToPrimitive`],
 //!   [`FromPrimitive`], [`ToBytes`], `FromBytes`, [`AsPrimitive`], [`Num`], [`Float`],
-//!   [`FloatCore`], and [`Bounded`] traits for both [`struct@f16`] and [`struct@bf16`].
+//!   [`FloatCore`], [`Signed`], and [`Bounded`] traits for both [`struct@f16`] and [`struct@bf16`].
 //!
 //! - **`bytemuck`** — Adds support for the [`bytemuck`] crate by implementing [`Zeroable`] and
 //!   [`Pod`] traits for both [`struct@f16`] and [`struct@bf16`].
@@ -149,6 +149,7 @@
 [`Num`]: ::num_traits::Num
 [`Float`]: ::num_traits::Float
 [`FloatCore`]: ::num_traits::float::FloatCore
+[`Signed`]: ::num_traits::Signed
 [`Bounded`]: ::num_traits::Bounded"
 )]
 #![cfg_attr(

src/num_traits.rs

@@ -1548,3 +1548,37 @@ impl FromBytes for bf16 {
         Self::from_ne_bytes(*bytes)
     }
 }
+
+macro_rules! impl_signed {
+    ($ty:ty) => {
+        impl ::num_traits::Signed for $ty {
+            #[inline]
+            fn abs(&self) -> Self {
+                ::num_traits::float::Float::abs(*self)
+            }
+
+            #[inline]
+            fn abs_sub(&self, other: &Self) -> Self {
+                ::num_traits::float::Float::abs_sub(*self, *other)
+            }
+
+            #[inline]
+            fn signum(&self) -> Self {
+                ::num_traits::float::Float::signum(*self)
+            }
+
+            #[inline]
+            fn is_positive(&self) -> bool {
+                ::num_traits::float::Float::is_sign_positive(*self)
+            }
+
+            #[inline]
+            fn is_negative(&self) -> bool {
+                ::num_traits::float::Float::is_sign_negative(*self)
+            }
+        }
+    };
+}
+
+impl_signed!(f16);
+impl_signed!(bf16);