Skip to content

Commit e7a4291

Browse files
author
Vlad Balin
committed
Hotfix: comparator : null setting doesn't clear the comparator in the subclass
1 parent 9087cc6 commit e7a4291

File tree

7 files changed

+7
-7
lines changed

7 files changed

+7
-7
lines changed

dist/index.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/index.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/collection/index.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/collection/index.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/collection/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ export class Collection< R extends Record = Record> extends Transactional implem
9090
this.prototype._itemEvents = eventsMap;
9191
}
9292

93-
if( definition.comparator ) this.prototype.comparator = definition.comparator;
93+
if( definition.comparator !== void 0 ) this.prototype.comparator = definition.comparator;
9494

9595
Transactional.onDefine.call( this, definition );
9696
}

tests/typescript/dist/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2880,7 +2880,7 @@ var Collection = (function (_super) {
28802880
eventsMap.addEventsMap(definition.itemEvents);
28812881
this.prototype._itemEvents = eventsMap;
28822882
}
2883-
if (definition.comparator)
2883+
if (definition.comparator !== void 0)
28842884
this.prototype.comparator = definition.comparator;
28852885
Transactional.onDefine.call(this, definition);
28862886
};

tests/typescript/dist/index.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)