Skip to content

Commit 20dbae7

Browse files
committed
Simple Check for Valid Inbound Message:
- Just checing if a message ID is set. - TODO: Should perhaps validate that it's a server request / id is from the reqeust data.
1 parent 96afa7e commit 20dbae7

File tree

2 files changed

+18
-1
lines changed

2 files changed

+18
-1
lines changed

src/Message/InboundMessage.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,11 @@ public function getMessageId()
9191
return $this['messageId'];
9292
}
9393

94+
public function isValid()
95+
{
96+
return (bool) $this->getMessageId();
97+
}
98+
9499
public function getBody()
95100
{
96101
if($this->getRequest()){

test/Message/InboundMessageTest.php

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,22 @@ public function testConstructionWithId()
2727
*/
2828
public function testCanCreateWithServerRequest($request)
2929
{
30-
$request = $this->getServerRequest('inbound-get');
3130
$message = new InboundMessage($request);
3231
}
3332

33+
public function testCanCheckValid()
34+
{
35+
$request = $this->getServerRequest();
36+
$message = new InboundMessage($request);
37+
38+
$this->assertTrue($message->isValid());
39+
40+
$request = $this->getServerRequest('http://example.com', 'GET', 'invalid');
41+
$message = new InboundMessage($request);
42+
43+
$this->assertFalse($message->isValid());
44+
}
45+
3446
/**
3547
* Can access expected params via getters.
3648
* @dataProvider getRequests

0 commit comments

Comments
 (0)