Cnam guarding because we sometimes get missing fields, up to developer to determine what to do with it.

Author: SecondeJK

src/Insights/CnamTrait.php

@@ -14,23 +14,23 @@
 trait CnamTrait
 {
 
-    public function getCallerName()
+    public function getCallerName(): ?string
     {
-        return $this->data['caller_name'];
+        return $this->data['caller_name'] ?? null;
     }
 
-    public function getFirstName()
+    public function getFirstName(): ?string
     {
-        return $this->data['first_name'];
+        return $this->data['first_name'] ?? null;
     }
 
-    public function getLastName()
+    public function getLastName(): ?string
     {
-        return $this->data['last_name'];
+        return $this->data['last_name'] ?? null;
     }
 
-    public function getCallerType()
+    public function getCallerType(): ?string
     {
-        return $this->data['caller_type'];
+        return $this->data['caller_type'] ?? null;
     }
 }

test/Insights/CnamTraitTest.php

@@ -16,34 +16,59 @@
 class CnamTraitTest extends VonageTestCase
 {
     /**
-     * @dataProvider cnamProvider
      *
      * @param $cnam
      * @param $inputData
      */
-    public function testObjectAccess($cnam, $inputData): void
+    public function testObjectAccess(): void
     {
+        $inputData = [
+            'first_name' => 'Tony',
+            'last_name' => 'Tiger',
+            'caller_name' => 'Tony Tiger Esq',
+            'caller_type' => 'consumer'
+        ];
+
+        $cnam = new Cnam('14155550100');
+        $cnam->fromArray($inputData);
+
         $this->assertEquals($inputData['first_name'], $cnam->getFirstName());
         $this->assertEquals($inputData['last_name'], $cnam->getLastName());
         $this->assertEquals($inputData['caller_name'], $cnam->getCallerName());
         $this->assertEquals($inputData['caller_type'], $cnam->getCallerType());
     }
 
-    public function cnamProvider(): array
+    public function testCanHandleNullFields(): void
     {
-        $r = [];
-
-        $input1 = [
+        $inputData = [
             'first_name' => 'Tony',
             'last_name' => 'Tiger',
             'caller_name' => 'Tony Tiger Esq',
             'caller_type' => 'consumer'
         ];
 
-        $cnam1 = new Cnam('14155550100');
-        $cnam1->fromArray($input1);
-        $r['cnam-1'] = [$cnam1, $input1];
+        $inputFirstname = $inputData;
+        unset($inputFirstname['first_name']);
+        $firstName = new Cnam('14155550100');
+        $firstName->fromArray($inputFirstname);
+        $this->assertEquals(null, $firstName->getFirstName());
+
+        $inputLastName = $inputData;
+        unset($inputLastName['last_name']);
+        $lastName = new Cnam('14155550100');
+        $lastName->fromArray($inputLastName);
+        $this->assertEquals(null, $lastName->getLastName());
+
+        $inputCallerName = $inputData;
+        unset($inputCallerName['caller_name']);
+        $callerName = new Cnam('14155550100');
+        $callerName->fromArray($inputCallerName);
+        $this->assertEquals(null, $callerName->getCallerName());
 
-        return $r;
+        $inputCallerType = $inputData;
+        unset($inputCallerType['caller_type']);
+        $callerType = new Cnam('14155550100');
+        $callerType->fromArray($inputCallerType);
+        $this->assertEquals(null, $callerType->getCallerType());
     }
 }