Explicitly set the sub if required (#286)

Author: dragonmantank

src/Client/Credentials/Keypair.php

@@ -88,6 +88,12 @@ public function generateJwt(array $claims = []): Token
             $builder->withClaim('application_id', $this->credentials['application']);
         }
 
+        if (isset($claims['sub'])) {
+            $builder->relatedTo($claims['sub']);
+
+            unset($claims['sub']);
+        }
+
         if (!empty($claims)) {
             foreach ($claims as $claim => $value) {
                 $builder->withClaim($claim, $value);

test/Client/Credentials/KeypairTest.php

@@ -92,6 +92,39 @@ public function testAdditionalClaims(): void
         $this->assertEquals(900, $payload['nbf']);
     }
 
+    /**
+     * @link https://github.com/Vonage/vonage-php-sdk-core/issues/276
+     */
+    public function testExampleConversationJWTWorks()
+    {
+        $credentials = new Keypair($this->key, $this->application);
+        $claims = [
+            'exp' => strtotime(date('Y-m-d', strtotime('+24 Hours'))),
+            'sub' => 'apg-cs',
+            'acl' => [
+                'paths' => [
+                    '/*/users/**' => (object) [],
+                    '/*/conversations/**' => (object) [],
+                    '/*/sessions/**' => (object) [],
+                    '/*/devices/**' => (object) [],
+                    '/*/image/**' => (object) [],
+                    '/*/media/**' => (object) [],
+                    '/*/applications/**' => (object) [],
+                    '/*/push/**' => (object) [],
+                    '/*/knocking/**' => (object) [],
+                    '/*/legs/**' => (object) [],
+                ]
+            ],
+        ];
+
+        $jwt = $credentials->generateJwt($claims);
+        [, $payload] = $this->decodeJWT($jwt->toString());
+
+        $this->assertArrayHasKey('exp', $payload);
+        $this->assertEquals($claims['exp'], $payload['exp']);
+        $this->assertEquals($claims['sub'], $payload['sub']);
+    }
+
     /**
      * @param $jwt
      */