add conversion method, SMS tests, refactoring

Author: maxkahan

http_client/CHANGES.md

@@ -1,2 +1,5 @@
-# 0.1.0
-- Initial upload
+# 1.0.0
+- Initial upload
+
+# 1.1.0
+- Add support for signature authentication

http_client/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "vonage-http-client"
-version = "1.0.0"
+version = "1.1.0"
 description = "An HTTP client for making requests to Vonage APIs."
 readme = "README.md"
 authors = [{ name = "Vonage", email = "[email protected]" }]

http_client/src/vonage_http_client/auth.py

@@ -1,7 +1,6 @@
 import hashlib
 import hmac
 from base64 import b64encode
-
 from time import time
 from typing import Literal, Optional
 
@@ -111,8 +110,7 @@ def sign_params(self, params: dict) -> str:
 
     @validate_call
     def check_signature(self, params: dict) -> bool:
-        """
-        Checks the signature hash of the given parameters.
+        """Checks the signature hash of the given parameters.
 
         Args:
             params (dict): The parameters to check the signature for.

http_client/src/vonage_http_client/http_client.py

@@ -1,3 +1,4 @@
+from json import JSONDecodeError
 from logging import getLogger
 from platform import python_version
 from typing import Literal, Optional, Union
@@ -167,7 +168,10 @@ def _parse_response(self, response: Response) -> Union[dict, None]:
         if 200 <= response.status_code < 300:
             if response.status_code == 204:
                 return None
-            return response.json()
+            try:
+                return response.json()
+            except JSONDecodeError:
+                return None
         if response.status_code >= 400:
             logger.warning(
                 f'Http Response Error! Status code: {response.status_code}; content: {repr(response.text)}; from url: {response.url}'

number_insight_v2/README.md

@@ -8,10 +8,10 @@ It includes classes for making fraud check requests and handling the responses.
 First, import the necessary classes and create an instance of the `NumberInsightV2` class:
 
 ```python
-from vonage_http_client.http_client import HttpClient
+from vonage_http_client.http_client import HttpClient, Auth
 from number_insight_v2 import NumberInsightV2, FraudCheckRequest
 
-http_client = HttpClient(api_host='your_api_host', api_key='your_api_key', api_secret='your_api_secret')
+http_client = HttpClient(Auth(api_key='your_api_key', api_secret='your_api_secret'))
 number_insight = NumberInsightV2(http_client)
 ```
 

pants.toml

@@ -12,6 +12,8 @@ backend_packages = [
   "pants.backend.experimental.python",
 ]
 
+pants_ignore.add = ['!_test_scripts/']
+
 [anonymous-telemetry]
 enabled = false
 

sms/BUILD

@@ -12,5 +12,5 @@ python_distribution(
     ],
     provides=python_artifact(),
     generate_setup=False,
-    repositories=['@testpypi'],
+    repositories=['@pypi'],
 )

sms/CHANGES.md

@@ -0,0 +1,2 @@
+# 1.0.0
+- Initial upload

sms/README.md

@@ -1,5 +1,24 @@
 # Vonage SMS Package
 
-This package contains the code to use Vonage's SMS API with Python.
+This package contains the code to use Vonage's SMS API in Python.
+
+It includes a method for sending SMS messages and returns an `SmsResponse` class to handle the response.
 
 ## Usage
+
+It is recommended to use this as part of the main `vonage` package. The examples below assume you've created an instance of the `vonage.Vonage` class called `vonage_client`.
+
+### Send an SMS
+
+Create an `SmsMessage` object, then pass into the `Sms.send` method.
+
+```python
+from vonage_sms import SmsMessage, SmsResponse
+
+message = SmsMessage(to='1234567890', from_='Acme Inc.', text='Hello, World!')
+response: SmsResponse = vonage_client.sms.send(message)
+
+print(response.model_dump(exclude_unset=True))
+```
+
+

sms/pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = 'vonage-sms'
-version = '0.1.0'
+version = '1.0.0'
 description = 'Vonage SMS package'
 readme = "README.md"
 authors = [{ name = "Vonage", email = "[email protected]" }]