updating NCCO info (#253)

* updating NCCO info

* updating ncco builder tests

Author: maxkahan

README.md

@@ -402,6 +402,11 @@ response = client.voice.create_call({
 pprint(response)
 ```
 
+### Note on from_ parameter in connect action
+
+When using the `connect` action, use the parameter `from_` to specify the recipient (as `from` is a reserved keyword in Python!)
+
+
 ## Verify API
 
 ### Search for a Verification request

src/vonage/ncco_builder/ncco.py

@@ -42,7 +42,7 @@ class Conversation(Action):
         while preserving the communication context.
         Using conversation with the same name reuses the same persisted conversation."""
 
-        action = Field('notify', const=True)
+        action = Field('conversation', const=True)
         name: str
         musicOnHoldUrl: Optional[Union[List[str], str]]
         startOnEnter: Optional[bool]

tests/test_ncco_builder/ncco_samples/ncco_action_samples.py

@@ -4,11 +4,11 @@
 
 record_add_split = '{"action": "record", "split": "conversation", "channels": 4}'
 
-conversation_basic = '{"action": "notify", "name": "my_conversation"}'
+conversation_basic = '{"action": "conversation", "name": "my_conversation"}'
 
-conversation_full = '{"action": "notify", "name": "my_conversation", "musicOnHoldUrl": ["http://example.com/music.mp3"], "startOnEnter": true, "endOnExit": true, "record": true, "canSpeak": ["asdf", "qwer"], "canHear": ["asdf"]}'
+conversation_full = '{"action": "conversation", "name": "my_conversation", "musicOnHoldUrl": ["http://example.com/music.mp3"], "startOnEnter": true, "endOnExit": true, "record": true, "canSpeak": ["asdf", "qwer"], "canHear": ["asdf"]}'
 
-conversation_mute_option = '{"action": "notify", "name": "my_conversation", "mute": true}'
+conversation_mute_option = '{"action": "conversation", "name": "my_conversation", "mute": true}'
 
 connect_phone = '{"action": "connect", "endpoint": [{"type": "phone", "number": "447000000000", "dtmfAnswer": "1p2p3p#**903#", "onAnswer": {"url": "https://example.com/answer", "ringbackTone": "http://example.com/ringbackTone.wav"}}]}'
 

tests/test_ncco_builder/ncco_samples/ncco_builder_samples.py

@@ -71,7 +71,7 @@
 
 insane_ncco = [
     {'action': 'record', 'eventUrl': ['http://example.com/events']},
-    {'action': 'notify', 'name': 'my_conversation'},
+    {'action': 'conversation', 'name': 'my_conversation'},
     {
         'action': 'connect',
         'endpoint': [{'number': '447000000000', 'type': 'phone'}],