added random_from_number to voice.py and added new test (#198)

* added random_from_number to voice.py and added new test

* Adding changes to the test

* added dictionary in voice.py and fixed test

* Remove Python version 3.4

Author: geekchick

.github/workflows/build.yml

@@ -7,7 +7,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python: ["3.4", "3.5", "3.6", "3.7", "3.8"]
+        python: ["3.5", "3.6", "3.7", "3.8"]
         os: ["ubuntu-latest", "macos-latest", "windows-latest"]
         exclude:
           - os: "windows-latest"

src/vonage/voice.py

@@ -18,7 +18,24 @@ def __init__(
             print('Error: {error_message}'.format(error_message=str(e)))
 
     # Creates a new call session
-    def create_call(self, params=None, **kwargs):
+    def create_call(self, params, **kwargs):
+        """
+            Adding Random From Number Feature for the Voice API, 
+            if set to `True`, the from number will be randomly selected 
+            from the pool of numbers available to the application making 
+            the call.
+
+            :param params is a dictionry that holds the 'from' and 'random_from_number'
+            
+        """
+        if not params:
+            params = kwargs
+
+            key = 'from'
+            if key not in params:
+                params['random_from_number'] = True
+
+
         return self._jwt_signed_post("/v1/calls", params or kwargs)
 
     # Get call history paginated. Pass start and end dates to filter the retrieved information

tests/test_voice.py

@@ -2,6 +2,7 @@
 import time
 
 import jwt
+import requests
 
 import vonage
 from util import *
@@ -14,7 +15,21 @@ def test_create_call(voice, dummy_data):
     params = {
         "to": [{"type": "phone", "number": "14843331234"}],
         "from": {"type": "phone", "number": "14843335555"},
-        "answer_url": ["https://example.com/answer"],
+        "answer_url": ["https://example.com/answer"]
+    }
+
+    assert isinstance(voice.create_call(params), dict)
+    assert request_user_agent() == dummy_data.user_agent
+    assert request_content_type() == "application/json"
+
+@responses.activate
+def test_params_with_random_number(voice, dummy_data):
+    stub(responses.POST, "https://api.nexmo.com/v1/calls")
+
+    params = {
+        "to": [{"type": "phone", "number": "14843331234"}],
+        "random_from_number":True,
+        "answer_url": ["https://example.com/answer"]
     }
 
     assert isinstance(voice.create_call(params), dict)