v1.2.2

Switches the `-c`/`--command` flag from `StringSlice` to `StringArray` to prevent splitting commands on commas, ensuring single quoted commands (e.g., PowerShell `Select-Object`) are preserved as intended. Updates CLI, tests, documentation, and version to v1.2.2; adds release notes and improves robustness for Windows shell usage.

Author: VoxDroid

CHANGELOG.md

@@ -3,6 +3,13 @@
 
 All notable changes to this project will be documented in this file.
 
+## v1.2.2 - 2026-01-17
+
+- Bugfix: Preserve comma-containing commands passed via a single `-c` flag (e.g., PowerShell `Select-Object` usage such as `Get-ComputerInfo | Select-Object OsName, OsVersion, OsArchitecture`). The CLI no longer splits a single `-c` value on commas — instead we use repeatable `-c` flags (`StringArray`) and ensure a single quoted `-c` is preserved literally.
+- Internal: Switch `-c` command flags from `StringSlice` (which splits on commas) to `StringArray` to avoid unintended splitting; update retrieval functions accordingly and add unit tests to validate behavior.
+- Tests: Add `TestSaveCommand_PreservesCommasInFlag` and update save-related tests to be robust across Windows-style inputs and quoting edge cases.
+- Docs: Update `docs/cli.md` and add release notes for v1.2.2 describing the change and upgrade guidance.
+
 ## v1.2.1 - 2026-01-17
 
 - CLI: **save** — Enhanced the `krnr save` command to better handle shell quoting mistakes by joining or merging split command arguments (e.g., when shells split embedded quotes) and heuristically reinserting `/C:"pattern"` quoting for common `findstr` usages. Adds robust argument splitting via `github.com/kballard/go-shellquote` and new unit tests.

RELEASE_NOTES/GITHUB_v1.2.2.md

@@ -0,0 +1,15 @@
+# v1.2.2 — 2026-01-17
+
+Patch release focusing on a robustness fix for the `save` command.
+
+What’s changed
+
+- Preserve comma-containing commands passed via a single `-c` flag (PowerShell `Select-Object` usage). A single quoted `-c` will now be stored as a single command and is no longer split on commas.
+- Internal: switched the repeatable command flag to `StringArray` to avoid unintended splitting and added tests to cover the behavior.
+
+Upgrade notes
+
+- No DB schema changes are required.
+- When using Windows shells, prefer quoting `-c` values fully (e.g., `-c 'Get-ComputerInfo | Select-Object OsName, OsVersion, OsArchitecture'`) to avoid shell-level tokenization issues.
+
+Thanks to contributors and maintainers for quick turnaround on this fix.

cmd/edit.go

@@ -19,7 +19,7 @@ var editCmd = &cobra.Command{
 	Args:  cobra.ExactArgs(1),
 	RunE: func(cmd *cobra.Command, args []string) error {
 		name := args[0]
-		cmdsFlags, _ := cmd.Flags().GetStringSlice("command")
+		cmdsFlags, _ := cmd.Flags().GetStringArray("command")
 
 		dbConn, err := db.InitDB()
 		if err != nil {
@@ -89,6 +89,6 @@ var editCmd = &cobra.Command{
 }
 
 func init() {
-	editCmd.Flags().StringSliceP("command", "c", []string{}, "Replace commands non-interactively (use multiple times)")
+	editCmd.Flags().StringArrayP("command", "c", []string{}, "Replace commands non-interactively (use multiple times)")
 	rootCmd.AddCommand(editCmd)
 }

cmd/save.go

@@ -23,7 +23,7 @@ Note: When using Windows shells, be sure to properly quote embedded double-quote
 	RunE: func(cmd *cobra.Command, args []string) error {
 		name := args[0]
 		desc, _ := cmd.Flags().GetString("description")
-		cmds, _ := cmd.Flags().GetStringSlice("command")
+		cmds, _ := cmd.Flags().GetStringArray("command")
 		// If the user accidentally allowed the shell to split a quoted
 		// command into multiple positionals, join the remaining args into a
 		// single command. If exactly one `-c` was provided, merge the
@@ -161,7 +161,7 @@ func normalizeFindstrCArgs(s string) string {
 
 func init() {
 	saveCmd.Flags().StringP("description", "d", "", "Description for the command set")
-	saveCmd.Flags().StringSliceP("command", "c", []string{}, "Command to add to the set (can be repeated)")
+	saveCmd.Flags().StringArrayP("command", "c", []string{}, "Command to add to the set (can be repeated)")
 	saveCmd.Flags().StringP("author", "a", "", "Author name for this command set (overrides stored whoami)")
 	saveCmd.Flags().StringP("author-email", "e", "", "Author email for this command set (optional)")
 	rootCmd.AddCommand(saveCmd)

cmd/save_cli_test.go

@@ -54,7 +54,7 @@ func TestSaveWithSplitArgs_MergeIntoSingle(t *testing.T) {
 	// the flag parser returning a single command element and the CLI args
 	// holding the remaining tokens.
 	local := &cobra.Command{RunE: saveCmd.RunE, Args: saveCmd.Args}
-	local.Flags().StringSliceP("command", "c", []string{}, "Command to add to the set (can be repeated)")
+	local.Flags().StringArrayP("command", "c", []string{}, "Command to add to the set (can be repeated)")
 	if err := local.Flags().Set("command", "systeminfo | findstr /C:"); err != nil {
 		t.Fatalf("set flag: %v", err)
 	}
@@ -86,3 +86,41 @@ func TestSaveWithSplitArgs_MergeIntoSingle(t *testing.T) {
 		t.Fatalf("expected merged and normalized command %q, got %q", expected, cs.Commands[0].Command)
 	}
 }
+
+func TestSaveCommand_PreservesCommasInFlag(t *testing.T) {
+	_ = setupTempDB(t)
+	// Ensure no pre-existing set with the same name
+	dbConn, err := db.InitDB()
+	if err != nil {
+		t.Fatalf("InitDB(): %v", err)
+	}
+	defer func() { _ = dbConn.Close() }()
+	r2 := registry.NewRepository(dbConn)
+	_ = r2.DeleteCommandSet("PS-preserve-comma")
+
+	// Simulate: krnr save PS-preserve-comma -c "Get-ComputerInfo | Select-Object OsName, OsVersion, OsArchitecture"
+	rootCmd.SetArgs([]string{"save", "PS-preserve-comma", "-c", "Get-ComputerInfo | Select-Object OsName, OsVersion, OsArchitecture"})
+	if err := rootCmd.Execute(); err != nil {
+		t.Fatalf("save failed: %v", err)
+	}
+
+	// Verify the command set exists and the command was preserved as a single entry
+	cs, err := r2.GetCommandSetByName("PS-preserve-comma")
+	if err != nil {
+		t.Fatalf("GetCommandSetByName: %v", err)
+	}
+	if cs == nil {
+		t.Fatalf("expected saved command set 'PS-preserve-comma' in DB")
+	}
+	expected := "Get-ComputerInfo | Select-Object OsName, OsVersion, OsArchitecture"
+	found := false
+	for _, c := range cs.Commands {
+		if c.Command == expected {
+			found = true
+			break
+		}
+	}
+	if !found {
+		t.Fatalf("expected preserved command %q to be present in commands, got: %+v", expected, cs.Commands)
+	}
+}

cmd/save_test.go

@@ -2,7 +2,6 @@ package cmd
 
 import (
 	"bytes"
-	"strings"
 	"testing"
 
 	"github.com/spf13/cobra"
@@ -24,10 +23,13 @@ func TestSaveCommand_SavesCommands(t *testing.T) {
 	// use a fresh command with its own FlagSet to avoid global flag state
 	local := &cobra.Command{RunE: saveCmd.RunE, Args: saveCmd.Args}
 	local.Flags().StringP("description", "d", "", "Description for the command set")
-	local.Flags().StringSliceP("command", "c", []string{}, "Command to add to the set (can be repeated)")
+	local.Flags().StringArrayP("command", "c", []string{}, "Command to add to the set (can be repeated)")
 	local.Flags().StringP("author", "a", "", "Author name for this command set (overrides stored whoami)")
 	local.Flags().StringP("author-email", "e", "", "Author email for this command set (optional)")
-	if err := local.Flags().Set("command", "echo save1,echo save2"); err != nil {
+	if err := local.Flags().Set("command", "echo save1"); err != nil {
+		t.Fatalf("set flag: %v", err)
+	}
+	if err := local.Flags().Set("command", "echo save2"); err != nil {
 		t.Fatalf("set flag: %v", err)
 	}
 
@@ -70,12 +72,14 @@ func runSaveWithInput(t *testing.T, initialName string, stdin string, commands [
 
 	local := &cobra.Command{RunE: saveCmd.RunE, Args: saveCmd.Args}
 	local.Flags().StringP("description", "d", "", "Description for the command set")
-	local.Flags().StringSliceP("command", "c", []string{}, "Command to add to the set (can be repeated)")
+	local.Flags().StringArrayP("command", "c", []string{}, "Command to add to the set (can be repeated)")
 	local.Flags().StringP("author", "a", "", "Author name for this command set (overrides stored whoami)")
 	local.Flags().StringP("author-email", "e", "", "Author email for this command set (optional)")
 	local.SetIn(bytes.NewBufferString(stdin))
-	if err := local.Flags().Set("command", strings.Join(commands, ",")); err != nil {
-		t.Fatalf("set flag: %v", err)
+	for _, c := range commands {
+		if err := local.Flags().Set("command", c); err != nil {
+			t.Fatalf("set flag: %v", err)
+		}
 	}
 
 	if err := local.RunE(local, []string{initialName}); err != nil {

docs/cli.md

@@ -16,7 +16,7 @@ Author metadata:
 - `--author-email` (`-e`) optionally sets the author email.
 - If `--author` is not provided, `krnr save` will use the stored `whoami` identity if present.
 
-Quoting & save behavior: The `save` command (v1.2.1) is more tolerant of common shell quoting mistakes. When leftover tokens are detected (for example, when shells split quoted arguments), `save` will join leftover tokens into a single `-c` command or merge them into an existing single `-c` value when appropriate. For simple `findstr /C:` patterns it will attempt to reinsert expected quotes so the saved command better matches user intent. Prefer providing command values as a single quoted `-c` when possible; see `docs/releases/v1.2.1.md` for details.
+Quoting & save behavior: The `save` command (v1.2.2) is more tolerant of common shell quoting mistakes. When leftover tokens are detected (for example, when shells split quoted arguments), `save` will join leftover tokens into a single `-c` command or merge them into an existing single `-c` value when appropriate. For simple `findstr /C:` patterns it will attempt to reinsert expected quotes so the saved command better matches user intent. Prefer providing command values as a single quoted `-c` when possible; see `docs/releases/v1.2.2.md` for details.
 
 ## whoami
 

docs/releases/v1.2.2.md

@@ -0,0 +1,12 @@
+# v1.2.2 - 2026-01-17
+
+This patch release fixes a subtle behavior where comma-containing commands (common in PowerShell cmdlets like `Select-Object`) could be split into multiple saved commands when supplied via a single `-c` flag. The CLI now preserves a single quoted `-c` value exactly (it no longer splits on commas).
+
+Highlights
+
+- Fix: Preserve comma-containing `-c` values (e.g., `Get-ComputerInfo | Select-Object OsName, OsVersion, OsArchitecture`) as a single saved command.
+- Internal: Use `StringArray` for the repeatable `-c`/`--command` flag to avoid unintended comma splitting caused by `StringSlice`.
+- Tests: Added unit tests to assert preservation of comma-containing commands and improved save-related tests to be robust to shell tokenization edge cases.
+- Docs: Updated `docs/cli.md` and `CHANGELOG.md` to document the fix and provide upgrade guidance.
+
+Upgrade guidance: Simply upgrade to v1.2.2; no DB schema changes are required. When using Windows shells, prefer quoting `-c` values fully (e.g., `-c 'Get-ComputerInfo | Select-Object OsName, OsVersion, OsArchitecture'`) to avoid any shell-level splitting. If you rely on previously-split behavior, re-save the affected command sets after upgrading.

internal/version/version.go

@@ -3,4 +3,4 @@ package version
 
 // Version is set at build time via -ldflags "-X github.com/VoxDroid/krnr/internal/version.Version=<value>"
 // The default is a development placeholder.
-var Version = "v1.2.1"
+var Version = "v1.2.2"