fix: Should not replace the arugments if no minecraftArguments provided

ci010 · ci010 · commit ddcfe62a0d19 · 2024-02-14T16:58:43.000+08:00
diff --git a/packages/core/version.ts b/packages/core/version.ts
@@ -726,7 +726,7 @@ export namespace Version {
     }
     const parsed: Version = JSON.parse(versionString)
     // if we legacy version json don't have argument, but have minecraftArugments
-    const legacyVersionJson = !parsed.arguments
+    const legacyVersionJson = !parsed.arguments && !!parsed.minecraftArguments
     const libraries = Version.resolveLibraries(parsed.libraries || [], platform)
     const args = {
       jvm: [] as Version.LaunchArgument[],

Original file line number	Diff line number	Diff line change
`@@ -726,7 +726,7 @@ export namespace Version {`
`726`	`726`	`}`
`727`	`727`	`const parsed: Version = JSON.parse(versionString)`
`728`	`728`	`// if we legacy version json don't have argument, but have minecraftArugments`
`729`		`- const legacyVersionJson = !parsed.arguments`
	`729`	`+ const legacyVersionJson = !parsed.arguments && !!parsed.minecraftArguments`
`730`	`730`	`const libraries = Version.resolveLibraries(parsed.libraries \|\| [], platform)`
`731`	`731`	`const args = {`
`732`	`732`	`jvm: [] as Version.LaunchArgument[],`