[fix] 67 - make tabs permission optional

Author: Vulpelo

.gitignore

@@ -1,4 +1,5 @@
 *.zip
 manifest.json
 .vscode/
-node_modules/
+node_modules/
+build

Readme.md

@@ -23,28 +23,30 @@ Also allows you to hide "Shorts" tab.
 
 ## Installation
 
-### Firefox 
+For firefox install from [Mozilla Add-ons](https://addons.mozilla.org/en-US/firefox/addon/hide-youtube-shorts/) webpage
 
-Install from [Mozilla Add-ons](https://addons.mozilla.org/en-US/firefox/addon/hide-youtube-shorts/) webpage
+For chrome install from [Chrome web store](https://chrome.google.com/webstore/detail/hide-shorts-for-youtube/ankepacjgoajhjpenegknbefpmfffdic) webpage
 
-or add the Add-on temporarily:
-1. Download the project
-2. Rename 'manifest-firefox.json' file to 'manifest.json'
-3. In Firefox browser go to the debugging page by typing in url <b>[about:debugging#/runtime/this-firefox](about:debugging#/runtime/this-firefox)</b>
-4. Click on <b>Load Temporary Add-on...</b>
-5. Select a file (eg. 'manifest.json' file) inside of downloaded git project. Or you can ZIP contents of the project and select it instead.
+## Debugging
 
-### Google Chrome
+Prepare files for chrome and firefox versions by running `npm run prepare` command. This will create new directories `./build/hys-c` (for chrome) `./build/hys-f` (for firefox) with respected files.
 
-Install from [Chrome web store](https://chrome.google.com/webstore/detail/hide-shorts-for-youtube/ankepacjgoajhjpenegknbefpmfffdic) webpage
+You can also run `npm run zip` command to prepare and create zip archives for both chrome and firefox versions. Both will be placed in `./build` directory
+
+### Firefox 
+
+Add the Add-on temporarily:
+1. In Firefox browser go to the debugging page by typing in url <b>[about:debugging#/runtime/this-firefox](about:debugging#/runtime/this-firefox)</b>
+2. Click on <b>Load Temporary Add-on...</b>
+3. Select a file `./build/hys-f/manifest.json` file. Or you can ZIP contents of the project and select it instead.
+
+### Google Chrome
 
-or add the Add-on manually:
-1. Download the project
-2. Rename 'manifest-chrome.json' file to 'manifest.json'
-3. In Chrome browser go to the Extensions page (or type in url <b>[chrome://extensions/](chrome://extensions/)</b>)
-4. Enable the <b>Developer Mode</b>
-5. Click the <b>Load unpacked</b> button
-6. Select the directory of downloaded git project.
+Add the Add-on manually:
+1. In Chrome browser go to the Extensions page (or type in url <b>[chrome://extensions/](chrome://extensions/)</b>)
+2. Enable the <b>Developer Mode</b>
+3. Click the <b>Load unpacked</b> button
+4. Select built directory `./build/hys-c`.
 
 ## License
 

manifest-chrome.json

@@ -1,13 +1,15 @@
 {
     "manifest_version": 3,
-    "version": "1.9.0",
+    "version": "1.9.1",
     "name": "__MSG_extensionName__",
     "description": "__MSG_extensionDescription__",
     "icons": {
       "64": "icons/hideshort-64.png"
     },
-    "permissions" : [
-      "storage",
+    "permissions": [
+      "storage"
+    ],
+    "optional_permissions": [
       "tabs"
     ],
     "content_scripts": [
@@ -23,7 +25,7 @@
       }
     ],
     "background": {
-      "service_worker": "./src/background/background-chrome.js",
+      "service_worker": "./src/background/background.js",
       "type": "module"
     },
     "default_locale": "en",

manifest-firefox.json

@@ -1,13 +1,15 @@
 {
     "manifest_version": 2,
-    "version": "1.9.0",
+    "version": "1.9.1",
     "name": "__MSG_extensionName__",
     "description": "__MSG_extensionDescription__",
     "icons": {
       "64": "icons/hideshort-64.png"
     },
-    "permissions" : [
-      "storage",
+    "permissions": [
+      "storage"
+    ],
+    "optional_permissions": [
       "tabs"
     ],
     "content_scripts": [
@@ -23,7 +25,15 @@
       }
     ],
     "background": {
-      "scripts": [ "./src/background/background-firefox.js" ]
+      "scripts": [ "./src/background/background.js" ]
+    },
+    "browser_specific_settings": {
+      "gecko": {
+        "id": "{88ebde3a-4581-4c6b-8019-2a05a9e3e938}",
+        "data_collection_permissions": {
+          "required": ["none"]
+        }
+      }
     },
     "default_locale": "en",
     "browser_action": {

package.json

@@ -1,11 +1,18 @@
 {
   "scripts": {
-    "test": "jest",
-    "zip-firefox": "cp manifest-firefox.json manifest.json; zip -r hide-youtube-shorts-firefox.zip _locales/* icons/* src/* manifest.json LICENCE.md Readme.md; rm manifest.json",
-    "zip-chrome": "cp manifest-chrome.json manifest.json; zip -r hide-youtube-shorts-chrome.zip _locales/* icons/* src/* manifest.json LICENCE.md Readme.md; rm manifest.json",
+    "prepare-firefox": "mkdir -p ./build/hys-f; cp -r manifest-firefox.json _locales icons src LICENCE.md Readme.md ./build/hys-f; mv ./build/hys-f/src/background/background-firefox.js ./build/hys-f/src/background/background.js; mv ./build/hys-f/src/menu/permissions-firefox.js ./build/hys-f/src/menu/permissions.js; mv ./build/hys-f/manifest-firefox.json ./build/hys-f/manifest.json; find ./build/hys-f -name \"*-chrome.js\" -type f -delete",
+    "prepare-chrome": "mkdir -p ./build/hys-c; cp -r manifest-chrome.json _locales icons src LICENCE.md Readme.md ./build/hys-c; mv ./build/hys-c/src/background/background-chrome.js ./build/hys-c/src/background/background.js; mv ./build/hys-c/src/menu/permissions-chrome.js ./build/hys-c/src/menu/permissions.js; mv ./build/hys-c/manifest-chrome.json ./build/hys-c/manifest.json; find ./build/hys-c -name \"*-firefox.js\" -type f -delete",
+    "prepare": "npm run prepare-firefox; npm run prepare-chrome",
+
+    "zip-firefox": "npm run prepare-firefox; cd ./build/hys-f; zip -r ../hide-youtube-shorts-firefox.zip ./**; cd -",
+    "zip-chrome": "npm run prepare-chrome; cd ./build/hys-c; zip -r ../hide-youtube-shorts-chrome.zip ./**; cd -",
     "zip": "npm run zip-firefox; npm run zip-chrome;",
+
+    "clean": "rm -r ./build",
+
     "firefox-lint": "web-ext lint",
-    "debug-android": "web-ext run -t firefox-android"
+    "debug-android": "web-ext run -t firefox-android",
+    "test": "jest"
   },
   "devDependencies": {
     "jest": "^30.1.2",

src/menu/permissions-chrome.js

@@ -0,0 +1,13 @@
+function shortsInOriginalVideoPlayerCheckboxPermission(e) {
+    if (e.target.checked) {
+        chrome.permissions.request(
+            {permissions: ['tabs']},
+            (granted) => {
+                chrome.storage.local.set({ shortsInOriginalVideoPlayer: granted });
+            });
+    } 
+    else {
+        chrome.permissions.remove({permissions: ['tabs']});
+        chrome.storage.local.set({ shortsInOriginalVideoPlayer: false });
+    }
+}

src/menu/permissions-firefox.js

@@ -0,0 +1,12 @@
+function shortsInOriginalVideoPlayerCheckboxPermission(e) {
+    if (e.target.checked) {
+        browser.permissions.request({permissions: ['tabs']})
+            .then((granted) => {
+                chrome.storage.local.set({ shortsInOriginalVideoPlayer: granted });
+            });
+    } 
+    else {
+        browser.permissions.remove({permissions: ['tabs']});
+        chrome.storage.local.set({ shortsInOriginalVideoPlayer: false });
+    }
+}

src/menu/popup.html

@@ -162,6 +162,7 @@ <h2>Hide Youtube-Shorts</h2>
                 <span style="text-align: right;" id="ext-version"></span>
             </a>
         </div>
+        <script src="permissions.js"></script>
         <script src="popup.js"></script>
     </body>
 </html>

src/menu/popup.js

@@ -67,7 +67,7 @@ window.onload = function () {
         if (value.shortsInOriginalVideoPlayer != undefined)
             shortsInOriginalVideoPlayerInputCheckbox.checked = value.shortsInOriginalVideoPlayer;
         shortsInOriginalVideoPlayerInputCheckbox.addEventListener("input", function (e) {
-            chrome.storage.local.set({ shortsInOriginalVideoPlayer: e.target.checked });
+            shortsInOriginalVideoPlayerCheckboxPermission(e)
         })
 
         // timeout