Naming idea for "groups" before release

[nickexe]

@Vysp3r
Just a quick naming suggestion — I noticed the top-level "groups" field in the runners.json structure.
Since it mainly holds collections of compatibility tools like Proton, Wine, DXVK, etc., maybe a more descriptive name like compat_layers or compat_tools could help make the purpose a bit clearer?

Totally up to you of course! I figured I'd bring it up now since the format hasn't been finalized or released yet, and it's always easier to make naming changes early on than later down the line.

[Vysp3r]

i can for sure change that.
i don't really care so I don't mind.

[Vysp3r]

hmmm i dont know what to do with this.

should i call Proton/Wine/DXVK compatibility tool and Proton-GE/Proton-CachyOS runner?

i just want to have one way of calling things across the app before I push the update.

[nickexe]

If we want a consistent naming convention, I suggest using "compatibility layer".
In the JSON, we can abbreviate it as 'compact_layers'.

[Vysp3r]

What about for Proton-GE and such?
I call them runners in the top bar so should I ensure it's called like that everywhere in the map?
I think that would cause user some confusion in the games tab if i replace compatibility tool with runner.

[nickexe]

I'm just proposing a change to the naming of the groups section in runners.json, suggesting a more semantically meaningful term to replace "groups." Everything else remains unchanged -
for example, Proton-GE is still referred to as a runner, and users won’t notice any visible differences.
Below is the complete file with my suggested naming adjustment applied:

{
    "version": 1,
    "compat_layers": [
        {
            "title": "Proton",
            "description": "Compatibility tools by Valve for running Windows software on Linux.",
            "runners": [
                {
                    "title": "Proton-GE",
                    "description": "Steam compatibility tool for running Windows games with improvements over Valve's default Proton.",
                    "endpoint": "https://api.github.com/repos/GloriousEggroll/proton-ge-custom/releases",
                    "asset_position": 1,
                    "directory_name_formats": [
                        {
                            "launcher": "default",
                            "directory_name_format": "$release_name"
                        },
                        {
                            "launcher": "Steam",
                            "directory_name_format": "&$release_name:.:Proton-$release_name:$release_name"
                        },
                        {
                            "launcher": "Bottles",
                            "directory_name_format": "_$release_name"
                        },
                        {
                            "launcher": "Heroic Games Launcher",
                            "directory_name_format": "Proton-$release_name"
                        }
                    ],
                    "support_latest": true,
                    "type": "github"
                },
                {
                    "title": "Proton-CachyOS",
                    "description": "Steam compatibility tool from the CachyOS Linux distribution for running Windows games with improvements over Valve's default Proton.",
                    "endpoint": "https://api.github.com/repos/CachyOS/proton-cachyos/releases",
                    "asset_position": 1,
                    "asset_position_hwcaps_condition": "x86_64_v3:3",
                    "directory_name_formats": [
                        {
                            "launcher": "default",
                            "directory_name_format": "$title $release_name"
                        }
                    ],
                    "type": "github"
                },
                {
                    "title": "Proton-EM",
                    "description": "Steam compatibility tool for running Windows games with improvements over Valve's default Proton. By Etaash Mathamsetty adding FSR4 support and wine wayland tweaks.",
                    "endpoint": "https://api.github.com/repos/Etaash-mathamsetty/Proton/releases",
                    "asset_position": 1,
                    "directory_name_formats": [
                        {
                            "launcher": "default",
                            "directory_name_format": "$release_name"
                        }
                    ],
                    "type": "github"
                },
                {
                    "title": "Proton-Sarek",
                    "description": "Steam compatibility tool based on Proton-GE with modifications for very old GPUs, with DXVK.",
                    "endpoint": "https://api.github.com/repos/pythonlover02/Proton-Sarek/releases",
                    "asset_position": 1,
                    "directory_name_formats": [
                        {
                            "launcher": "default",
                            "directory_name_format": "$release_name"
                        }
                    ],
                    "request_asset_exclude": [
                        "Sarek9-13"
                    ],
                    "type": "github"
                },
                {
                    "title": "Proton-Sarek (Async)",
                    "description": "Steam compatibility tool based on Proton-GE with modifications for very old GPUs, with DXVK-Async.",
                    "endpoint": "https://api.github.com/repos/pythonlover02/Proton-Sarek/releases",
                    "asset_position": 0,
                    "directory_name_formats": [
                        {
                            "launcher": "default",
                            "directory_name_format": "$release_name-async"
                        }
                    ],
                    "request_asset_exclude": [
                        "Sarek9-13"
                    ],
                    "type": "github"
                },
                {
                    "title": "Proton-Tkg",
                    "description": "Custom Proton build for running Windows games, based on Wine-tkg.",
                    "endpoint": "https://api.github.com/repos/Frogging-Family/wine-tkg-git/actions/workflows/29873769/runs",
                    "asset_position": 0,
                    "directory_name_formats": [
                        {
                            "launcher": "default",
                            "directory_name_format": "$title-$release_name"
                        }
                    ],
                    "directory_name_format": "$title-$release_name",
                    "url_template": "https://nightly.link/Frogging-Family/wine-tkg-git/actions/runs/{id}/proton-tkg-build.zip",
                    "type": "github-action"
                },
                {
                    "title": "Proton-GE RTSP",
                    "description": "Steam compatibility tool based on Proton-GE with additional patches to improve RTSP codecs for VRChat.",
                    "endpoint": "https://api.github.com/repos/SpookySkeletons/proton-ge-rtsp/releases",
                    "asset_position": 0,
                    "directory_name_formats": [
                        {
                            "launcher": "default",
                            "directory_name_format": "$title $release_name"
                        }
                    ],
                    "type": "github"
                },
                {
                    "title": "NorthstarProton",
                    "description": "Custom Proton build for running the Northstar client for Titanfall 2.",
                    "endpoint": "https://api.github.com/repos/cyrv6737/NorthstarProton/releases",
                    "asset_position": 0,
                    "directory_name_formats": [
                        {
                            "launcher": "default",
                            "directory_name_format": "$title $release_name"
                        }
                    ],
                    "type": "github"
                },
                {
                    "title": "Luxtorpeda",
                    "description": "Luxtorpeda provides Linux-native game engines for certain Windows-only games.",
                    "endpoint": "https://api.github.com/repos/luxtorpeda-dev/luxtorpeda/releases",
                    "asset_position": 0,
                    "directory_name_formats": [
                        {
                            "launcher": "default",
                            "directory_name_format": "$title $release_name"
                        }
                    ],
                    "type": "github"
                },
                {
                    "title": "Roberta",
                    "description": "Steam compatibility tool for running adventure games using ScummVM for Linux.",
                    "endpoint": "https://api.github.com/repos/dreamer/roberta/releases",
                    "asset_position": 0,
                    "directory_name_formats": [
                        {
                            "launcher": "default",
                            "directory_name_format": "$title $release_name"
                        }
                    ],
                    "type": "github"
                },
                {
                    "title": "Boxtron",
                    "description": "Steam compatibility tool for running DOS games using DOSBox for Linux.",
                    "endpoint": "https://api.github.com/repos/dreamer/boxtron/releases",
                    "asset_position": 0,
                    "directory_name_formats": [
                        {
                            "launcher": "default",
                            "directory_name_format": "$title $release_name"
                        }
                    ],
                    "type": "github"
                }
            ]
        },
        {
            "title": "Wine",
            "description": "Compatibility tools for running Windows software on Linux.",
            "runners": [
                {
                    "title": "Wine-Vanilla (Kron4ek)",
                    "description": "Wine build compiled from the official WineHQ sources.",
                    "endpoint": "https://api.github.com/repos/Kron4ek/Wine-Builds/releases",
                    "asset_position": 1,
                    "directory_name_formats": [
                        {
                            "launcher": "default",
                            "directory_name_format": "wine-$release_name-amd64"
                        }
                    ],
                    "request_asset_exclude": [
                        "proton",
                        ".0."
                    ],
                    "type": "github"
                },
                {
                    "title": "Wine-Staging (Kron4ek)",
                    "description": "Wine build with the Staging patchset.",
                    "endpoint": "https://api.github.com/repos/Kron4ek/Wine-Builds/releases",
                    "asset_position": 2,
                    "directory_name_formats": [
                        {
                            "launcher": "default",
                            "directory_name_format": "wine-$release_name-staging-amd64"
                        }
                    ],
                    "request_asset_exclude": [
                        "proton",
                        ".0."
                    ],
                    "type": "github"
                },
                {
                    "title": "Wine-Staging-Tkg (Kron4ek)",
                    "description": "Wine build with the Staging patchset and many other useful patches.",
                    "endpoint": "https://api.github.com/repos/Kron4ek/Wine-Builds/releases",
                    "asset_position": 3,
                    "directory_name_formats": [
                        {
                            "launcher": "default",
                            "directory_name_format": "wine-$release_name-staging-tkg-amd64"
                        }
                    ],
                    "request_asset_exclude": [
                        "proton",
                        ".0."
                    ],
                    "type": "github"
                },
                {
                    "title": "Wine-Proton (Kron4ek)",
                    "description": "Wine build modified by Valve and other contributors.",
                    "endpoint": "ttps://api.github.com/repos/Kron4ek/Wine-Builds/releases",
                    "asset_position": 1,
                    "directory_name_formats": [
                        {
                            "launcher": "default",
                            "directory_name_format": "wine-$release_name-amd64-wow64"
                        }
                    ],
                    "request_asset_filter": [
                        "proton"
                    ],
                    "type": "github"
                }
            ]
        },
        {
            "title": "DXVK",
            "description": "Vulkan-based implementation of Direct3D 8, 9, 10 and 11 for Linux/Wine.",
            "runners": [
                {
                    "title": "DXVK (doitsujin)",
                    "description": "",
                    "endpoint": "https://api.github.com/repos/doitsujin/dxvk/releases",
                    "asset_position": 0,
                    "directory_name_formats": [
                        {
                            "launcher": "default",
                            "directory_name_format": "!$release_name:v:dxvk-"
                        }
                    ],
                    "type": "github"
                },
                {
                    "title": "DXVK (Sarek)",
                    "description": "DXVK Builds that work with pre-Vulkan 1.3 versions",
                    "endpoint": "https://api.github.com/repos/pythonlover02/DXVK-Sarek/releases",
                    "asset_position": 1,
                    "directory_name_formats": [
                        {
                            "launcher": "default",
                            "directory_name_format": "sarek-$release_name"
                        }
                    ],
                    "type": "github"
                },
                {
                    "title": "DXVK Async (Sarek)",
                    "description": "DXVK Async Builds that work with pre-Vulkan 1.3 versions",
                    "endpoint": "https://api.github.com/repos/pythonlover02/DXVK-Sarek/releases",
                    "asset_position": 0,
                    "directory_name_formats": [
                        {
                            "launcher": "default",
                            "directory_name_format": "sarek-async-$release_name"
                        }
                    ],
                    "type": "github"
                },
                {
                    "title": "DXVK GPL+Async (Ph42oN)",
                    "description": "",
                    "endpoint": "https://gitlab.com/api/v4/projects/Ph42oN%2Fdxvk-gplasync/releases",
                    "asset_position": 0,
                    "directory_name_formats": [
                        {
                            "launcher": "default",
                            "directory_name_format": "dxvk-gplasync-$release_name"
                        }
                    ],
                    "type": "gitlab"
                }
            ]
        },
        {
            "title": "VKD3D",
            "description": "Variant of Wine's VKD3D which aims to implement the full Direct3D 12 API on top of Vulkan.",
            "runners": [
                {
                    "title": "VKD3D-Proton",
                    "description": "",
                    "endpoint": "https://api.github.com/repos/HansKristian-Work/vkd3d-proton/releases",
                    "asset_position": 0,
                    "directory_name_formats": [
                        {
                            "launcher": "default",
                            "directory_name_format": "!$release_name:v:vkd3d-proton-"
                        }
                    ],
                    "type": "github"
                },
                {
                    "title": "VKD3D-Lutris",
                    "description": "",
                    "endpoint": "https://api.github.com/repos/lutris/vkd3d/releases",
                    "asset_position": 0,
                    "directory_name_formats": [
                        {
                            "launcher": "default",
                            "directory_name_format": "$release_name"
                        },
                        {
                            "launcher": "Heroic Games Launcher",
                            "directory_name_format": "!$release_name:v:vkd3d-lutris-"
                        }
                    ],
                    "type": "github"
                }
            ]
        }
    ],
    "launchers": [
        {
            "title": "Steam",
            "runners": [
                {
                    "title": "Proton",
                    "directory": "/compatibilitytools.d"
                }
            ]
        },
        {
            "title": "Lutris",
            "runners": [
                {
                    "title": "Proton",
                    "directory": "/runners/proton"
                },
                {
                    "title": "Wine",
                    "directory": "/runners/wine"
                },
                {
                    "title": "DXVK",
                    "directory": "/runtime/dxvk"
                },
                {
                    "title": "VKD3D",
                    "directory": "/runtime/vkd3d"
                }
            ]
        },
        {
            "title": "Heroic Games Launcher",
            "runners": [
                {
                    "title": "Proton",
                    "directory": "/tools/proton"
                },
                {
                    "title": "Wine",
                    "directory": "/tools/wine"
                }
            ]
        },
        {
            "title": "Bottles",
            "runners": [
                {
                    "title": "Proton",
                    "directory": "/runners"
                },
                {
                    "title": "DXVK",
                    "directory": "/dxvk"
                }
            ]
        },
        {
            "title": "WineZGUI",
            "runners": [
                {
                    "title": "Wine",
                    "directory": "/Runners"
                }
            ]
        }
    ]
}

[Vysp3r]

I'll do that after washing my car and then we might finally be able to push this update lol.

[Vysp3r]

@nickexe Everything looks good on my side.
I will test again, but if you could also test that would help me a lot!

[Vysp3r]

I found a possible source of issue.

If you have Proton-GE Latest installed and it's checking for an update and you close the application it will mess it up.

I will add a warning when the application is checking for updates when you try to close it.

After that if they force exit and something fuck up it's their problem.

[Vysp3r]

I've implemented what I talked about.

[Vysp3r]

flathub/com.vysp3r.ProtonPlus#70

Why the hell does it now throw an error for Proton-GE Latest.

Do you also have that problem?

Message: 21:39:33.536: filesystem.vala:121: Can’t recursively copy directory

[nickexe]

Are you saying the problematic one is the Flatpak version?

[Vysp3r]

Yes, it seems like the move_directory function is not working when running under Flatpak.

I'll try to put the old code when I am free today and see if that works.

[Vysp3r]

@nickexe The icons do not work in the Flatpak version and WineZGUI doesn't show up either.

This is really stupid.

[nickexe]

Do you mean the ones that were later changed to be loaded using from_icon_name for the launcher icon?

[Vysp3r]

[Vysp3r]

Closing since it's done.