Removed @internal jsdoc comments because we made symbols unique

Author: W4G1

deno.jsonc

@@ -25,6 +25,12 @@
     // "noUnusedParameters": true,
     "checkJs": true,
     "lib": ["deno.window", "deno.worker" /*, "deno.unstable"*/]
+  },
+  "lint": {
+    "rules": {
+      "include": [],
+      "exclude": ["no-explicit-any", "no-unused-vars"]
+    }
   }
   // "unstable": ["raw-imports", "worker-options", "cron"]
 }

scripts/build.ts

@@ -211,6 +211,8 @@ await Deno.writeTextFile(
 try {
   await Deno.copyFile("LICENSE.md", path.join(OUT_DIR, "LICENSE.md"));
   await Deno.copyFile("README.md", path.join(OUT_DIR, "README.md"));
-} catch (e) {}
+} catch (e) {
+  console.error(e);
+}
 
 console.log("[Build] Success!");

src/lib/json_buffer.ts

@@ -510,8 +510,8 @@ class SharedJsonBufferImpl<T extends Proxyable> extends Serializable {
       if (ptr === 0) return undefined;
 
       // Standard resolution
-      let curr = ptr;
-      let type = this._u32[curr >> 2]!;
+      const curr = ptr;
+      const type = this._u32[curr >> 2]!;
       if (type !== TYPE_MOVED) {
         this.s_len = this._u32[(curr + 8) >> 2]!;
         this.s_start = curr + 12;
@@ -1332,9 +1332,6 @@ class SharedJsonBufferImpl<T extends Proxyable> extends Serializable {
     }
   }
 
-  /**
-   * @internal
-   */
   [toSerialized]() {
     return {
       value: this.buffer,
@@ -1343,9 +1340,6 @@ class SharedJsonBufferImpl<T extends Proxyable> extends Serializable {
     };
   }
 
-  /**
-   * @internal
-   */
   static override [toDeserialized](
     data: ReturnType<
       SharedJsonBufferImpl<any>[typeof toSerialized]

src/lib/lib.ts

@@ -1,14 +1,14 @@
 import { getCallerLocation } from "./caller_location.ts";
 import { patchDynamicImports } from "./patch_import.ts";
 import { WorkerPool } from "./pool.ts";
-import type { JoinHandle, Result, ThreadTask } from "./types.ts";
+import type { JoinHandle, Result, ThreadTask, UserFunction } from "./types.ts";
 import { checkMoveArgs } from "./check_move_args.ts";
 
 export * from "./sync/mod.ts";
 export { SharedJsonBuffer } from "./json_buffer.ts";
 
 let globalPool: WorkerPool | null = null;
-const functionIdCache = new WeakMap<Function, string>();
+const functionIdCache = new WeakMap<UserFunction, string>();
 let globalConfig = { maxWorkers: navigator.hardwareConcurrency || 4 };
 
 export function initRuntime(config: { maxWorkers: number }) {
@@ -64,7 +64,7 @@ export function spawn(arg1: any, arg2?: any): JoinHandle<any> {
   >();
 
   let args: any[] = [];
-  let fn: Function;
+  let fn: UserFunction;
 
   // Runtime Logic: Keeps checking for the Symbol
   if (arg1 && Object.prototype.hasOwnProperty.call(arg1, moveTag)) {

src/lib/sync/condvar.ts

@@ -70,19 +70,13 @@ export class Condvar extends Serializable {
     Atomics.notify(this.#atomic, 0, Infinity);
   }
 
-  /**
-   * @internal
-   */
   [toSerialized]() {
     return {
       value: this.#atomic.buffer,
       transfer: [],
     };
   }
 
-  /**
-   * @internal
-   */
   static override [toDeserialized](
     obj: ReturnType<Condvar[typeof toSerialized]>["value"],
   ) {

src/lib/sync/mpmc.ts

@@ -37,9 +37,6 @@ class ChannelInternals<T> extends Serializable {
     super();
   }
 
-  /**
-   * @internal
-   */
   [toSerialized]() {
     const itemsSer = serialize(this.items);
     const sendLockSer = serialize(this.sendLock);
@@ -208,9 +205,6 @@ export class Sender<T> extends Serializable implements Disposable {
     this.disposed = true;
   }
 
-  /**
-   * @internal
-   */
   [toSerialized]() {
     if (this.disposed) {
       throw new Error("Cannot move a disposed Sender");
@@ -221,9 +215,6 @@ export class Sender<T> extends Serializable implements Disposable {
     return serialize(this.internals);
   }
 
-  /**
-   * @internal
-   */
   static override [toDeserialized](
     obj: ReturnType<Sender<any>[typeof toSerialized]>["value"],
   ) {
@@ -368,9 +359,6 @@ export class Receiver<T> extends Serializable implements Disposable {
     }
   }
 
-  /**
-   * @internal
-   */
   [toSerialized]() {
     if (this.disposed) {
       throw new Error("Cannot move a disposed Receiver");
@@ -383,9 +371,6 @@ export class Receiver<T> extends Serializable implements Disposable {
     return serialize(this.internals);
   }
 
-  /**
-   * @internal
-   */
   static override [toDeserialized](
     obj: ReturnType<Receiver<any>[typeof toSerialized]>["value"],
   ) {

src/lib/sync/mutex.ts

@@ -25,9 +25,6 @@ export class MutexGuard<T extends SharedMemoryView | void>
   implements Disposable {
   #data: T;
   #released = false;
-  /**
-   * @internal
-   */
   [INTERNAL_MUTEX_CONTROLLER]!: MutexController;
 
   constructor(data: T, controller: MutexController) {
@@ -134,9 +131,6 @@ export class Mutex<T extends SharedMemoryView | void = void>
     return new MutexGuard(this.#data, this.#createController());
   }
 
-  /**
-   * @internal
-   */
   [toSerialized]() {
     let serializedData;
     let transfer: Transferable[] = [];
@@ -156,9 +150,6 @@ export class Mutex<T extends SharedMemoryView | void = void>
     };
   }
 
-  /**
-   * @internal
-   */
   static override [toDeserialized](
     obj: ReturnType<Mutex<any>[typeof toSerialized]>["value"],
   ) {

src/lib/sync/rwlock.ts

@@ -29,9 +29,6 @@ export class RwLockReadGuard<T extends SharedMemoryView | void>
   implements Disposable {
   #data: T;
   #released = false;
-  /**
-   * @internal
-   */
   [INTERNAL_RWLOCK_CONTROLLER]!: RwLockController;
 
   constructor(data: T, controller: RwLockController) {
@@ -251,9 +248,6 @@ export class RwLock<T extends SharedMemoryView | void = void>
     }
   }
 
-  /**
-   * @internal
-   */
   [toSerialized]() {
     let serializedData;
     let transfer: Transferable[] = [];
@@ -273,9 +267,6 @@ export class RwLock<T extends SharedMemoryView | void = void>
     };
   }
 
-  /**
-   * @internal
-   */
   static override [toDeserialized](
     obj: ReturnType<RwLock<any>[typeof toSerialized]>["value"],
   ) {

src/lib/sync/semaphore.ts

@@ -65,9 +65,6 @@ export class Semaphore extends Serializable {
    * [1]: waiters (The number of threads currently waiting)
    */
   #state: Int32Array<SharedArrayBuffer>;
-  /**
-   * @internal
-   */
   [INTERNAL_SEMAPHORE_CONTROLLER]!: SemaphoreController;
 
   constructor(initialCount: number, _buffer?: SharedArrayBuffer) {
@@ -178,19 +175,13 @@ export class Semaphore extends Serializable {
     }
   }
 
-  /**
-   * @internal
-   */
   [toSerialized]() {
     return {
       value: this.#state.buffer,
       transfer: [],
     };
   }
 
-  /**
-   * @internal
-   */
   static override [toDeserialized](buffer: SharedArrayBuffer) {
     return new Semaphore(0, buffer);
   }

src/lib/types.ts

@@ -52,3 +52,7 @@ export type WorkerTaskPayload = {
 export type WorkerResponsePayload =
   | { type: "RESULT"; taskId: number; result: Envelope }
   | { type: "ERROR"; taskId: number; error: string; stack?: string };
+
+export type UserFunction = (
+  ...args: unknown[]
+) => Promise<unknown> | unknown;