Skip to content

Commit b67711f

Browse files
authored
Merge pull request #129 from majguo/reference-to-new-base-image
Reference to new base images
2 parents 660d798 + 440d27c commit b67711f

File tree

6 files changed

+16
-13
lines changed

6 files changed

+16
-13
lines changed

.github/workflows/package.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ on:
44
# Allows you to run this workflow using GitHub APIs
55
# PERSONAL_ACCESS_TOKEN=<GITHUB_PERSONAL_ACCESS_TOKEN>
66
# REPO_NAME=WASdev/azure.websphere-traditional.cluster
7-
# curl --verbose -XPOST -u "WASdev:${PERSONAL_ACCESS_TOKEN}" -H "Accept: application/vnd.github.everest-preview+json" -H "Content-Type: application/json" https://api.github.com/repos/${REPO_NAME}/actions/workflows/package.yaml/dispatches --data '{"ref": "master"}'
7+
# curl --verbose -XPOST -u "WASdev:${PERSONAL_ACCESS_TOKEN}" -H "Accept: application/vnd.github.everest-preview+json" -H "Content-Type: application/json" https://api.github.com/repos/${REPO_NAME}/actions/workflows/package.yaml/dispatches --data '{"ref": "main"}'
88
repository_dispatch:
99
types: [package]
1010
# sample request

README.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
# Related Repositories
22

3-
* [Base images deployed by this Azure application](https://github.com/WASdev/azure.websphere-traditional.image)
4-
* [tWAS on VMs, Single server](https://github.com/WASdev/azure.websphere-traditional.singleserver)
3+
* Base images deployed by this Azure application
4+
* [twas-nd](https://github.com/WASdev/azure.websphere-traditional.image/tree/main/twas-nd)
5+
* [ihs](https://github.com/WASdev/azure.websphere-traditional.image/tree/main/ihs)
6+
* [WebSphere traditional single server](https://github.com/WASdev/azure.websphere-traditional.singleserver)
57
* [Liberty on ARO](https://github.com/WASdev/azure.liberty.aro)
68
* [Liberty on AKS](https://github.com/WASdev/azure.liberty.aks)
79

docs/howto-update-for-was-fixpack.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ Please follow sections below in order to update the solution for next tWAS fixpa
55
## Updating the image
66

77
1. Which file to update for WAS version?
8-
* For `twas-nd` image, update the following properties in file [`virtualimage.properties`](https://github.com/WASdev/azure.websphere-traditional.image/blob/master/twas-nd/src/main/scripts/virtualimage.properties#L14-L15), e.g.:
8+
* For `twas-nd` image, update the following properties in file [`virtualimage.properties`](https://github.com/WASdev/azure.websphere-traditional.image/blob/main/twas-nd/src/main/scripts/virtualimage.properties#L14-L15), e.g.:
99

1010
```bash
1111
WAS_ND_TRADITIONAL=com.ibm.websphere.ND.v90
@@ -14,7 +14,7 @@ Please follow sections below in order to update the solution for next tWAS fixpa
1414

1515
Note: only the major version should be specified, the minor version should not be hard-coded as the Installation Manager will intelligently install the latest available minor version.
1616

17-
* For `ihs` image, update the following properties in file [`virtualimage.properties`](https://github.com/WASdev/azure.websphere-traditional.image/blob/master/ihs/src/main/scripts/virtualimage.properties#L22-L25), e.g.:
17+
* For `ihs` image, update the following properties in file [`virtualimage.properties`](https://github.com/WASdev/azure.websphere-traditional.image/blob/main/ihs/src/main/scripts/virtualimage.properties#L22-L25), e.g.:
1818

1919
```bash
2020
IBM_HTTP_SERVER=com.ibm.websphere.IHS.v90
@@ -63,14 +63,14 @@ Please follow sections below in order to update the solution for next tWAS fixpa
6363
Note: Currently Graham Charters has privilege to update the image in marketplace, contact him for more information.
6464
6565
1. Do we need to update the solution every time we do the image update?
66-
* Yes. That's because image versions of [`twas-nd`](https://github.com/WASdev/azure.websphere-traditional.cluster/blob/master/pom.xml#L51) and [`ihs`](https://github.com/WASdev/azure.websphere-traditional.cluster/blob/master/pom.xml#L57) are explicitely referenced in the tWAS solutoin. Make sure correct image versions are specified in the `pom.xml` of the solution code.
66+
* Yes. That's because image versions of [`twas-nd`](https://github.com/WASdev/azure.websphere-traditional.cluster/blob/main/pom.xml#L51) and [`ihs`](https://github.com/WASdev/azure.websphere-traditional.cluster/blob/main/pom.xml#L57) are explicitely referenced in the tWAS solution. Make sure correct image versions are specified in the `pom.xml` of the solution code.
6767

6868
## Updating and publishing the solution code
6969

7070
Note: The steps included in this section are also applied to release new features / bug fixes which have no changes to the images.
7171

7272
1. How to update the version of the solution?
73-
* Increase the [version number](https://github.com/WASdev/azure.websphere-traditional.cluster/blob/master/pom.xml#L23) which is specified in the `pom.xml`
73+
* Increase the [version number](https://github.com/WASdev/azure.websphere-traditional.cluster/blob/main/pom.xml#L23) which is specified in the `pom.xml`
7474
* Also update the `twasnd.image.version` and `ihs.image.version` (obtained from publish step)
7575

7676
1. How to run CI/CD?
@@ -96,7 +96,7 @@ Note: The steps included in this section are also applied to release new feature
9696
1. Create a [release](https://github.com/WASdev/azure.websphere-traditional.cluster/releases) for this GA code and tag with the pom.xml version number.
9797

9898
1. How to test the solution, what testcases to run?
99-
1. Wait until the soluton offer is in `Publisher signoff` (aka "preview") stage;
99+
1. Wait until the solution offer is in `Publisher signoff` (aka "preview") stage;
100100
1. Run test cases defined in [twas-solution-test-cases.pdf](twas-solution-test-cases.pdf). Note: use "preview link" for each test case.
101101

102102
## What needs to be cleaned up from test env and how to clean them up?

pom.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020

2121
<groupId>com.ibm.websphere.azure</groupId>
2222
<artifactId>azure.websphere-traditional.cluster</artifactId>
23-
<version>1.3.26</version>
23+
<version>1.3.27</version>
2424

2525
<parent>
2626
<groupId>com.microsoft.azure.iaas</groupId>
@@ -48,12 +48,12 @@
4848
<!-- This is the twas-nd "Plan ID" of the plan within the "Azure Virtual Machine" offer -->
4949
<twasnd.image.sku>2021-04-27-twas-cluster-base-image</twasnd.image.sku>
5050
<!-- This is the twas-nd "Disk version" of the VM image of the plan within the "Azure Virtual Machine" offer -->
51-
<twasnd.image.version>9.0.20210930</twasnd.image.version>
51+
<twasnd.image.version>9.0.20211220</twasnd.image.version>
5252
<!-- This is the ihs "Offer ID" of the "Azure Virtual Machine" offer type -->
5353
<ihs.image.offer>2021-06-03-ihs-base-image</ihs.image.offer>
5454
<!-- This is the ihs "Plan ID" of the plan within the "Azure Virtual Machine" offer -->
5555
<ihs.image.sku>2021-06-03-ihs-base-image</ihs.image.sku>
5656
<!-- This is the ihs "Disk version" of the VM image of the plan within the "Azure Virtual Machine" offer -->
57-
<ihs.image.version>9.0.20210930</ihs.image.version>
57+
<ihs.image.version>9.0.20211220</ihs.image.version>
5858
</properties>
5959
</project>

src/main/arm/mainTemplate.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -668,6 +668,7 @@
668668
}
669669
},
670670
{
671+
"condition": "[parameters('configureIHS')]",
671672
"type": "Microsoft.Resources/deployments",
672673
"apiVersion": "${azure.apiVersion}",
673674
"name": "ihsVMCreated",

src/main/resources/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
- Content that required to create an Azure applicatoin offer from [Commerical Marketplace Overview](https://partner.microsoft.com/en-us/dashboard/commercial-marketplace/overview) -> New Offer > Azure Application
44
- See [Azure applicatoin offer](https://docs.microsoft.com/en-us/azure/marketplace/cloud-partner-portal/azure-applications/cpp-azure-app-offer) for details
5-
- When submitting the offer, use content from [this directory](https://github.com/WASdev/azure.websphere-traditional.cluster/tree/master/src/main/resources) (To-Be-Changed), but apply the changes in this file on top
5+
- When submitting the offer, use content from [this directory](https://github.com/WASdev/azure.websphere-traditional.cluster/tree/main/src/main/resources) (To-Be-Changed), but apply the changes in this file on top
66

77
## New offer
88

@@ -104,7 +104,7 @@
104104

105105
#### Store logos
106106

107-
- [marketing-artifacts](https://github.com/WASdev/azure.websphere-traditional.cluster/tree/master/src/main/resources/marketing-artifacts)
107+
- [marketing-artifacts](https://github.com/WASdev/azure.websphere-traditional.cluster/tree/main/src/main/resources/marketing-artifacts)
108108
- Small: 48*48
109109
- Medium: 90*90
110110
- Large: 216*216

0 commit comments

Comments
 (0)