Add features.sh to download features using featureUtility (#467)

* Add features.sh

* Update file paths and add non-optimal build message

* Update README.md

* Add non-optimal build error message for kernel images only

* Update README.md

* Remove extra env vars

* Update 22.0.0.9

* Revert 22.0.0.8

* Revert 22.0.0.8

* Update test-pet-clinic

* Update test-stock-quote

* Update test-stock-trader

* Revert removal of deprecated features

* Update configure.sh

* Re-add missing files

* Fix line spacing

* Run installUtility if features.sh was not run, update test-pet-clinic

* Suppress non-optimal build error message on full images

* Suppress non-optimal build error message on full images 2

* Move features.sh changes to 22.0.0.10

* Revert 22.0.0.9 changes

* Re-add missing Dockerfiles

* Move configure-liberty.sh into build stage, re-add missing files

* Move configure-liberty.sh into build stage, re-add missing files

* Update call to configure-liberty.sh

* Add features-installed.sh override in full images

* Override features-installed.sh in 22.0.0.9 full images

* Update comments

* Undo chmod

* Fix folder permission

* Update cleanup of configure-liberty.log artifact

* Fix indent spacing

* Update copyright years

* Update 23.0.0.1

* Merge main into kirby-patch-kernel, update to 23.0.0.2

* Update to 23.0.0.2

* Fix merge conflict

* Fix merge conflict

* Delete configure-liberty.sh

* Add check for installed features using feature repo url

* Move featureManager tag to features.sh

- And opt-out creating featureManager config when FEATURES_INSTALLED is true

* Remove FEATURES_INSTALLED refs from features.sh

* Rebase and add features.sh to 23.0.0.4

and move configure-liberty.log into /logs

* Add features.sh

* Update file paths and add non-optimal build message

* Update README.md

* Add non-optimal build error message for kernel images only

* Update README.md

* Remove extra env vars

* Update 22.0.0.9

* Revert 22.0.0.8

* Update test-pet-clinic

* Revert removal of deprecated features

* Re-add missing files

* Fix line spacing

* Run installUtility if features.sh was not run, update test-pet-clinic

* Suppress non-optimal build error message on full images

* Suppress non-optimal build error message on full images 2

* Move features.sh changes to 22.0.0.10

* Revert 22.0.0.9 changes

* Re-add missing Dockerfiles

* Move configure-liberty.sh into build stage, re-add missing files

* Move configure-liberty.sh into build stage, re-add missing files

* Add features-installed.sh override in full images

* Update comments

* Undo chmod

* Fix folder permission

* Update cleanup of configure-liberty.log artifact

* Fix indent spacing

* Update 23.0.0.1

* Merge main into kirby-patch-kernel, update to 23.0.0.2

* Update to 23.0.0.2

* Fix merge conflict

* Fix merge conflict

* Delete configure-liberty.sh

* Add check for installed features using feature repo url

* Revert test-pet-clinic test

* Remove redundant sessioncache-features.xml copy

* Use short URL for building an app image doc

* Support deprecated add-on features in configure.sh only

* Output features.sh warning in both full and kernel

* Fix spacing

* Delete extraneous XML config

* Update configure.sh to match OL ci.docker

* Update hazelcast-sessioncache-full.xml

* Move features-installed.sh into helpers/build/internal

* Revert sessioncache XML naming and use *-config.xml with features.sh

* Update features-installed.sh to check /log/features.log

* Update test-pet-clinic

* Update test-pet-clinic

* Remove configure-liberty.sh

* Update test apps

Author: kabicin

README.md

@@ -31,15 +31,18 @@ Your application image template should follow a pattern similar to:
 ```dockerfile
 FROM icr.io/appcafe/websphere-liberty:kernel-java8-openj9-ubi
 
-# Add my app and config
-COPY --chown=1001:0  Sample1.war /config/dropins/
+# Add Liberty server configuration including all necessary features
 COPY --chown=1001:0  server.xml /config/
 
+# This script will add the requested XML snippets to enable Liberty features and grow image to be fit-for-purpose using featureUtility. 
+# Only available in 'kernel'. The 'full' tag already includes all features for convenience.
+RUN features.sh
+
 # Add interim fixes (optional)
 COPY --chown=1001:0  interim-fixes /opt/ibm/fixes/
 
-# Default setting for the verbose option
-ARG VERBOSE=false
+# Add app
+COPY --chown=1001:0  Sample1.war /config/dropins/
 
 # This script will add the requested XML snippets, grow image to be fit-for-purpose and apply interim fixes
 RUN configure.sh
@@ -275,7 +278,7 @@ ARG VERBOSE=false
 RUN configure.sh
 ```
 
-Note: This feature requires a `curl ` command to be in the container image.
+Note: This feature requires a `curl` command to be in the container image.
 Some base images do not provide `curl`. You can add it before calling `confiure.sh` this way:
 
 ```dockerfile

ga/22.0.0.12/full/Dockerfile.ubi.ibmjava8

@@ -24,7 +24,6 @@ RUN if [ ! -z $REPOSITORIES_PROPERTIES ]; then mkdir /opt/ibm/wlp/etc/ \
   && rm -rf /output/workarea /output/logs \
   && find /opt/ibm/wlp ! -perm -g=rw -print0 | xargs -r -0 chmod g+rw
 
-
 COPY --chown=1001:0 server.xml /config/
 
 # Create a new SCC layer

ga/22.0.0.12/kernel/Dockerfile.ubi.ibmjava8

@@ -30,7 +30,7 @@ LABEL org.opencontainers.image.authors="Leo Christy Jesuraj, Arthur De Magalhaes
       name="IBM WebSphere Liberty" \
       version="22.0.0.12" \
       summary="Image for WebSphere Liberty with IBM's Java and Red Hat's UBI 8" \
-      description="This image contains the WebSphere Liberty runtime with IBM's Java and Red Hat's UBI 8 as the base OS.  For more information on this image please see https://github.com/WASdev/ci.docker#building-an-application-image"
+      description="This image contains the WebSphere Liberty runtime with IBM's Java and Red Hat's UBI 8 as the base OS.  For more information on this image please see https://ibm.biz/wl-app-image-template"
 
 # Install WebSphere Liberty
 ENV LIBERTY_VERSION 22.0.0_12
@@ -115,7 +115,7 @@ RUN if [ "$OPENJ9_SCC" = "true" ]; then populate_scc.sh; fi \
     && chown -R 1001:0 /opt/ibm/wlp/output \
     && chmod -R g+rwx /opt/ibm/wlp/output
 
-#These settings are needed so that we can run as a different user than 1001 after server warmup
+# These settings are needed so that we can run as a different user than 1001 after server warmup
 ENV RANDFILE=/tmp/.rnd \
     IBM_JAVA_OPTIONS="-Xshareclasses:name=liberty,readonly,nonfatal,cacheDir=/output/.classCache/ -Dosgi.checkConfiguration=false ${IBM_JAVA_OPTIONS}"
 

ga/22.0.0.12/kernel/Dockerfile.ubi.openjdk11

@@ -30,7 +30,7 @@ LABEL org.opencontainers.image.authors="Leo Christy Jesuraj, Arthur De Magalhaes
       name="IBM WebSphere Liberty" \
       version="22.0.0.12" \
       summary="Image for WebSphere Liberty with IBM Semeru Runtime Open Edition OpenJDK with OpenJ9 and Red Hat's UBI 8" \
-      description="This image contains the WebSphere Liberty runtime with IBM Semeru Runtime Open Edition OpenJDK with OpenJ9 and Red Hat's UBI 8 as the base OS.  For more information on this image please see https://github.com/WASdev/ci.docker#building-an-application-image"
+      description="This image contains the WebSphere Liberty runtime with IBM Semeru Runtime Open Edition OpenJDK with OpenJ9 and Red Hat's UBI 8 as the base OS.  For more information on this image please see https://ibm.biz/wl-app-image-template"
 
 # Install WebSphere Liberty
 ENV LIBERTY_VERSION 22.0.0_12
@@ -116,7 +116,7 @@ RUN if [ "$OPENJ9_SCC" = "true" ]; then populate_scc.sh; fi \
     && chown -R 1001:0 /opt/ibm/wlp/output \
     && chmod -R g+rwx /opt/ibm/wlp/output
 
-#These settings are needed so that we can run as a different user than 1001 after server warmup
+# These settings are needed so that we can run as a different user than 1001 after server warmup
 ENV RANDFILE=/tmp/.rnd \
     OPENJ9_JAVA_OPTIONS="-XX:+IgnoreUnrecognizedVMOptions -XX:+IdleTuningGcOnIdle -Xshareclasses:name=openj9_system_scc,cacheDir=/opt/java/.scc,readonly,nonFatal -Dosgi.checkConfiguration=false"
 

ga/22.0.0.12/kernel/Dockerfile.ubi.openjdk17

@@ -30,7 +30,7 @@ LABEL org.opencontainers.image.authors="Leo Christy Jesuraj, Chris Potter, Melis
       name="IBM WebSphere Liberty" \
       version="22.0.0.12" \
       summary="Image for WebSphere Liberty with IBM Semeru Runtime Open Edition OpenJDK with OpenJ9 and Red Hat's UBI 8" \
-      description="This image contains the WebSphere Liberty runtime with IBM Semeru Runtime Open Edition OpenJDK with OpenJ9 and Red Hat's UBI 8 as the base OS.  For more information on this image please see https://github.com/WASdev/ci.docker#building-an-application-image"
+      description="This image contains the WebSphere Liberty runtime with IBM Semeru Runtime Open Edition OpenJDK with OpenJ9 and Red Hat's UBI 8 as the base OS.  For more information on this image please see https://ibm.biz/wl-app-image-template"
 
 # Install WebSphere Liberty
 ENV LIBERTY_VERSION 22.0.0_12
@@ -116,7 +116,7 @@ RUN if [ "$OPENJ9_SCC" = "true" ]; then populate_scc.sh; fi \
     && chown -R 1001:0 /opt/ibm/wlp/output \
     && chmod -R g+rwx /opt/ibm/wlp/output
 
-#These settings are needed so that we can run as a different user than 1001 after server warmup
+# These settings are needed so that we can run as a different user than 1001 after server warmup
 ENV RANDFILE=/tmp/.rnd \
     OPENJ9_JAVA_OPTIONS="-XX:+IgnoreUnrecognizedVMOptions -XX:+IdleTuningGcOnIdle -Xshareclasses:name=openj9_system_scc,cacheDir=/opt/java/.scc,readonly,nonFatal -Dosgi.checkConfiguration=false"
 

ga/22.0.0.12/kernel/Dockerfile.ubi.openjdk8

@@ -30,7 +30,7 @@ LABEL org.opencontainers.image.authors="Leo Christy Jesuraj, Arthur De Magalhaes
       name="IBM WebSphere Liberty" \
       version="22.0.0.12" \
       summary="Image for WebSphere Liberty with IBM Semeru Runtime Open Edition OpenJDK with OpenJ9 and Red Hat's UBI 8" \
-      description="This image contains the WebSphere Liberty runtime with IBM Semeru Runtime Open Edition OpenJDK with OpenJ9 and Red Hat's UBI 8 as the base OS.  For more information on this image please see https://github.com/WASdev/ci.docker#building-an-application-image"
+      description="This image contains the WebSphere Liberty runtime with IBM Semeru Runtime Open Edition OpenJDK with OpenJ9 and Red Hat's UBI 8 as the base OS.  For more information on this image please see https://ibm.biz/wl-app-image-template"
 
 # Install WebSphere Liberty
 ENV LIBERTY_VERSION 22.0.0_12
@@ -116,7 +116,7 @@ RUN if [ "$OPENJ9_SCC" = "true" ]; then populate_scc.sh; fi \
     && chown -R 1001:0 /opt/ibm/wlp/output \
     && chmod -R g+rwx /opt/ibm/wlp/output
 
-#These settings are needed so that we can run as a different user than 1001 after server warmup
+# These settings are needed so that we can run as a different user than 1001 after server warmup
 ENV RANDFILE=/tmp/.rnd \
     OPENJ9_JAVA_OPTIONS="-XX:+IgnoreUnrecognizedVMOptions -XX:+IdleTuningGcOnIdle -Xshareclasses:name=openj9_system_scc,cacheDir=/opt/java/.scc,readonly,nonFatal -Dosgi.checkConfiguration=false"
 

ga/22.0.0.12/kernel/Dockerfile.ubuntu.ibmjava8

@@ -26,7 +26,7 @@ LABEL org.opencontainers.image.authors="Leo Christy Jesuraj, Arthur De Magalhaes
       org.opencontainers.image.documentation="https://www.ibm.com/support/knowledgecenter/SSAW57_liberty/com.ibm.websphere.wlp.nd.multiplatform.doc/ae/cwlp_about.html" \
       org.opencontainers.image.version="22.0.0.12" \
       org.opencontainers.image.revision="cl221220221107-1900" \
-      org.opencontainers.image.description="This image contains the WebSphere Liberty runtime with IBM's Java and Ubuntu as the base OS.  For more information on this image please see https://github.com/WASdev/ci.docker#building-an-application-image" \
+      org.opencontainers.image.description="This image contains the WebSphere Liberty runtime with IBM's Java and Ubuntu as the base OS.  For more information on this image please see https://ibm.biz/wl-app-image-template" \
       org.opencontainers.image.title="IBM WebSphere Liberty"
 
 # Install WebSphere Liberty
@@ -114,7 +114,7 @@ RUN if [ "$OPENJ9_SCC" = "true" ]; then populate_scc.sh; fi \
     && chown -R 1001:0 /opt/ibm/wlp/output \
     && chmod -R g+rwx /opt/ibm/wlp/output
 
-#These settings are needed so that we can run as a different user than 1001 after server warmup
+# These settings are needed so that we can run as a different user than 1001 after server warmup
 ENV RANDFILE=/tmp/.rnd \
     IBM_JAVA_OPTIONS="-Xshareclasses:name=liberty,readonly,nonfatal,cacheDir=/output/.classCache/ -Dosgi.checkConfiguration=false ${IBM_JAVA_OPTIONS}"
 

ga/22.0.0.12/kernel/Dockerfile.ubuntu.openjdk11

@@ -26,7 +26,7 @@ LABEL org.opencontainers.image.authors="Arthur De Magalhaes, Chris Potter, Chris
       org.opencontainers.image.documentation="https://www.ibm.com/support/knowledgecenter/SSAW57_liberty/com.ibm.websphere.wlp.nd.multiplatform.doc/ae/cwlp_about.html" \
       org.opencontainers.image.version="22.0.0.12" \
       org.opencontainers.image.revision="cl221220221107-1900" \
-      org.opencontainers.image.description="This image contains the WebSphere Liberty runtime with IBM Semeru Runtime Open Edition OpenJDK with OpenJ9 and Ubuntu as the base OS.  For more information on this image please see https://github.com/WASdev/ci.docker#building-an-application-image" \
+      org.opencontainers.image.description="This image contains the WebSphere Liberty runtime with IBM Semeru Runtime Open Edition OpenJDK with OpenJ9 and Ubuntu as the base OS.  For more information on this image please see https://ibm.biz/wl-app-image-template" \
       org.opencontainers.image.title="IBM WebSphere Liberty"
 
 # Install WebSphere Liberty
@@ -114,7 +114,7 @@ RUN if [ "$OPENJ9_SCC" = "true" ]; then populate_scc.sh; fi \
     && chown -R 1001:0 /opt/ibm/wlp/output \
     && chmod -R g+rwx /opt/ibm/wlp/output
 
-#These settings are needed so that we can run as a different user than 1001 after server warmup
+# These settings are needed so that we can run as a different user than 1001 after server warmup
 ENV RANDFILE=/tmp/.rnd \
     OPENJ9_JAVA_OPTIONS="-XX:+IgnoreUnrecognizedVMOptions -XX:+IdleTuningGcOnIdle -Xshareclasses:name=openj9_system_scc,cacheDir=/opt/java/.scc,readonly,nonFatal -Dosgi.checkConfiguration=false"
 

ga/22.0.0.12/kernel/Dockerfile.ubuntu.openjdk17

@@ -26,7 +26,7 @@ LABEL org.opencontainers.image.authors="Chris Potter, Christy Jesuraj, Melissa L
       org.opencontainers.image.documentation="https://www.ibm.com/support/knowledgecenter/SSAW57_liberty/com.ibm.websphere.wlp.nd.multiplatform.doc/ae/cwlp_about.html" \
       org.opencontainers.image.version="22.0.0.12" \
       org.opencontainers.image.revision="cl221220221107-1900" \
-      org.opencontainers.image.description="This image contains the WebSphere Liberty runtime with IBM Semeru Runtime Open Edition OpenJDK with OpenJ9 and Ubuntu as the base OS.  For more information on this image please see https://github.com/WASdev/ci.docker#building-an-application-image" \
+      org.opencontainers.image.description="This image contains the WebSphere Liberty runtime with IBM Semeru Runtime Open Edition OpenJDK with OpenJ9 and Ubuntu as the base OS.  For more information on this image please see https://ibm.biz/wl-app-image-template" \
       org.opencontainers.image.title="IBM WebSphere Liberty"
 
 # Install WebSphere Liberty
@@ -114,7 +114,7 @@ RUN if [ "$OPENJ9_SCC" = "true" ]; then populate_scc.sh; fi \
     && chown -R 1001:0 /opt/ibm/wlp/output \
     && chmod -R g+rwx /opt/ibm/wlp/output
 
-#These settings are needed so that we can run as a different user than 1001 after server warmup
+# These settings are needed so that we can run as a different user than 1001 after server warmup
 ENV RANDFILE=/tmp/.rnd \
     OPENJ9_JAVA_OPTIONS="-XX:+IgnoreUnrecognizedVMOptions -XX:+IdleTuningGcOnIdle -Xshareclasses:name=openj9_system_scc,cacheDir=/opt/java/.scc,readonly,nonFatal -Dosgi.checkConfiguration=false"
 

ga/22.0.0.12/kernel/helpers/build/configuration_snippets/hazelcast-sessioncache-config.xml

@@ -0,0 +1,8 @@
+<server>
+  <httpSessionCache libraryRef="HazelcastLib">
+    <properties hazelcast.config.location="file:${shared.config.dir}/hazelcast/hazelcast.xml"/>
+  </httpSessionCache>
+  <library id="HazelcastLib">
+    <fileset dir="${shared.resource.dir}/hazelcast"/>
+  </library>
+</server>