fix: Fix issues relate to connection (#74)

# Description

- STUN/TURN servers will reset on new version release
- Fix the issue where wrong target will cause server to crash

Fixes #73 

## Type of change

Please delete options that are not relevant.

- [x] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update

## Checklist

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] Any dependent changes have been merged and published in downstream
modules

Author: WCY-dt

CHANGELOG.md

@@ -2,11 +2,21 @@
 
 All notable changes to this project will be documented in this file.
 
+## [3.1.18] - 2025-03-12
+
+### Changed
+
+- STUN/TURN servers will reset on new version release
+
+### Fixed
+
+- Fix the issue where wrong target will cause server to crash
+
 ## [3.1.17] - 2025-03-11
 
 ### Fixed
 
-- Fixed the issue where auto download is disabled in certain browsers
+- Fix the issue where auto download is disabled in certain browsers
 
 ## [3.1.16] - 2025-02-14
 

SECURITY.md

@@ -6,8 +6,8 @@ We release patches for security vulnerabilities in the following versions:
 
 | Part   | Version | Supported          |
 | ------ | ------- | ------------------ |
-| Server | 3.0.x   | :white_check_mark: |
-| Server | < 3.0   | :x:                |
+| Server | 3.1.x   | :white_check_mark: |
+| Server | < 3.1   | :x:                |
 | Client | 3.1.x   | :white_check_mark: |
 | Client | < 3.1   | :x:                |
 

client/package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "client",
-  "version": "3.1.17",
+  "version": "3.1.18",
   "private": true,
   "type": "module",
   "scripts": {

client/package.json

@@ -4,38 +4,19 @@ export const defaultMaxConnectionNumber: number = 10
 
 export const defaultIceServers: IceServer[] = [
   {
-    urls: 'stun:stun.l.google.com:19302',
-  },
-  {
-    urls: 'stun:stun.l.google.com:5349',
-  },
-  {
-    urls: 'stun:stun1.l.google.com:3478',
-  },
-  {
-    urls: 'stun:stun1.l.google.com:5349',
-  },
-  {
-    urls: 'stun:stun2.l.google.com:19302',
-  },
-  {
-    urls: 'stun:stun2.l.google.com:5349',
-  },
-  {
-    urls: 'stun:stun3.l.google.com:3478',
-  },
-  {
-    urls: 'stun:stun3.l.google.com:5349',
+    urls: 'turn:103.124.107.241:3478',
+    username: 'easytransfer',
+    credential: 'sharesimplyandstayanonymous',
   },
   {
-    urls: 'stun:stun4.l.google.com:19302',
+    urls: 'stun:stun.relay.metered.ca:80',
   },
   {
-    urls: 'stun:stun4.l.google.com:5349',
+    urls: 'turn:global.relay.metered.ca:80',
+    username: 'cf841207b56ebddc17948dde',
+    credential: '0dGvvEm7eq2UaqlW',
   },
   {
-    urls: 'turn:103.124.107.241:3478',
-    username: 'easytransfer',
-    credential: 'sharesimplyandstayanonymous',
+    urls: 'stun:stun.l.google.com:19302',
   },
 ]

client/src/const.ts

@@ -65,6 +65,12 @@ export const useConnectStore = defineStore('connect', () => {
   }
 
   function handleServerMsg() {
+    socket?.on('error', (error: string) => {
+      console.error(`[ERROR] ${error}`)
+      isConnecting.value = false
+      isConnectSuccess.value = false
+    })
+
     socket?.on('success', (id: string) => {
       clientId.value = id
       registered.value = true

client/src/stores/connect.ts

@@ -50,27 +50,31 @@ export const useSettingStore = defineStore('setting', () => {
   })
 
   // maxConnectionNumber
+  const maxConnectionNumberStorageName =
+    'maxConnectionNumber-' + (process.package_version as string)
   const maxConnectionNumber: Ref<number> = ref(defaultMaxConnectionNumber)
 
-  if (localStorage.getItem('maxConnectionNumber')) {
+  if (localStorage.getItem(maxConnectionNumberStorageName)) {
     maxConnectionNumber.value = JSON.parse(
-      localStorage.getItem('maxConnectionNumber') as string,
+      localStorage.getItem(maxConnectionNumberStorageName) as string,
     )
   }
 
   watch(maxConnectionNumber, () => {
     localStorage.setItem(
-      'maxConnectionNumber',
+      maxConnectionNumberStorageName,
       JSON.stringify(maxConnectionNumber.value),
     )
   })
 
   // iceServers
+  const iceServersStorageName =
+    'iceServers-' + (process.package_version as string)
   const iceServers: Ref<IceServer[]> = ref(defaultIceServers)
 
-  if (localStorage.getItem('iceServers')) {
+  if (localStorage.getItem(iceServersStorageName)) {
     const existingIceServers = JSON.parse(
-      localStorage.getItem('iceServers') as string,
+      localStorage.getItem(iceServersStorageName) as string,
     )
     const newIceServers = [...iceServers.value, ...existingIceServers]
     const uniqueIceServers = Array.from(
@@ -80,7 +84,10 @@ export const useSettingStore = defineStore('setting', () => {
   }
 
   watch(iceServers, () => {
-    localStorage.setItem('iceServers', JSON.stringify(iceServers.value))
+    localStorage.setItem(
+      iceServersStorageName,
+      JSON.stringify(iceServers.value),
+    )
   })
 
   return {

client/src/stores/setting.ts

@@ -1,6 +1,6 @@
 {
   "name": "file-transfer-server",
-  "version": "3.0.2",
+  "version": "3.1.0",
   "description": "Server for file transfer",
   "main": "dist/server.js",
   "type": "module",

package-lock.json

@@ -55,7 +55,17 @@ io.on("connection", (socket: Socket) => {
     "offer",
     (sdp: RTCSessionDescriptionInit, srcId: string, targetId: string) => {
       console.log("[offer] ", srcId, " --> ", targetId);
-      clients[targetId].emit("offer", sdp, srcId, maxConnectionNumbers[srcId]);
+      try {
+        clients[targetId].emit(
+          "offer",
+          sdp,
+          srcId,
+          maxConnectionNumbers[srcId],
+        );
+      } catch (error) {
+        console.error("[error] ", error);
+        clients[srcId].emit("error", "Target client not found");
+      }
     },
   );