UI/improve batch and synthesis interface #978
Conversation
- Add InfoBar descriptions for batch task types to help users understand each mode (transcribe, subtitle, trans+sub, full process) - Remove redundant video file selector button from synthesis command bar (already available via browse button and drag-drop) - Update soft/hard subtitle InfoBar descriptions for clarity Co-Authored-By: Claude Opus 4.5 <[email protected]>
…ations - Updated configuration to include a new option for enabling subtitle styles. - Added signals for style changes and render mode updates in the signal bus. - Integrated style and render mode controls in the video synthesis interface, allowing users to toggle styles and select rendering modes. - Adjusted task factory to conditionally apply styles based on user settings. These changes improve the flexibility and user experience of subtitle rendering in the application.
- Introduced a base downloader class and specific implementations for aria2c and requests. - Enhanced the file download thread to select the appropriate downloader based on availability. - Added progress tracking and cancellation capabilities for downloads. - Improved error handling and logging during the download process. These changes significantly enhance the file downloading functionality, providing users with a more robust and flexible experience.
… resource links - Changed links in the README to point to updated documentation locations. - Revised instructions for LLM API configuration and translation settings for better user guidance. - Updated testing results and quick start instructions to reflect recent changes in model usage and installation scripts. - Enhanced the structure of the project directory description for better understanding. - Corrected references to cookie configuration and subtitle test results for consistency across documentation. These updates aim to enhance user experience and provide clearer guidance on using the application effectively.
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| mode_text = self.renderModeCard.comboBox.currentText() | ||
| mode = SubtitleRenderModeEnum(mode_text) | ||
| cfg.set(cfg.subtitle_render_mode, mode) | ||
| signalBus.subtitle_render_mode_changed.emit(mode_text) |
There was a problem hiding this comment.
Render mode change triggers duplicate UI updates
Medium Severity
When the render mode is changed locally in subtitle_style_interface.py, the UI update methods _updateVisibleGroups(), _refreshStyleList(), and updatePreview() are called twice. onRenderModeChanged() emits subtitle_render_mode_changed signal AND directly calls these methods. The emitted signal then triggers on_render_mode_changed_external() on the same object, which calls the same three methods again. This causes redundant CPU work and potential UI flickering, especially since updatePreview() likely performs expensive rendering operations.
Additional Locations (1)
| # 视频质量信号 | ||
| video_quality_changed = pyqtSignal(str) | ||
| # 使用样式信号 | ||
| use_subtitle_style_changed = pyqtSignal(bool) |
There was a problem hiding this comment.
Signal defined and connected but never emitted
Low Severity
The use_subtitle_style_changed signal is defined in signal_bus.py and connected to on_use_style_changed handler in video_synthesis_interface.py, but the signal is never emitted anywhere in the codebase. The handler on_use_style_changed is therefore dead code that will never be invoked. When the use style toggle is changed in on_use_style_action_triggered, only the config value is set directly without emitting the signal.
Note
使用样式toggle and render mode dropdown; syncs render mode across views; auto-disables style when using soft subtitles; centralizes control enable/disable logic.UseSubtitleStylesetting and related signals; increases defaultMaxWordCountCJKto 28; renames LLM provider toOpenAI 兼容.BaseDownloaderwithAria2DownloaderandRequestsDownloaderfallback, progress reporting, and cancel support.ffmpegis missing; startup scripts now surface FFmpeg requirement (aria2 warning removed).gemini-3/doubao; LLM split retries reduced to 2 with clearer guidance.legacy-docs/site, updates setup scripts/paths, cookie and config docs, model suggestions, and project structure.Risk: Medium — UI flow changes for synthesis, new downloader logic, and stricter FFmpeg dependency could affect runtime behavior.
Written by Cursor Bugbot for commit 6bd4666. This will update automatically on new commits. Configure here.