Skip to content

docs(tradable): explain component check #858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Clarity-89 wants to merge 6 commits into
base: master
Choose a base branch
from
Open

docs(tradable): explain component check #858

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
691bad4
fix(tradable): use component check instead of blanket-blocking Prime …
Clarity-89 Feb 12, 2026
de4f204
Merge branch 'master' into fix/tradable-status
Clarity-89 Feb 12, 2026
65ee608
fix(tradable): fix JSDoc types and remove Wraith test
Clarity-89 Feb 12, 2026
5cd37ba
revert(tradable): restore original logic, add JSDoc explaining semantics
Clarity-89 Feb 13, 2026
1485abe
fix(tradable): add valid JSDoc @param and @returns
Clarity-89 Feb 13, 2026
dbf675b
Merge branch 'master' into fix/tradable-status
Clarity-89 Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions build/tradable.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,22 @@ const builtUntradable = [
'Launcher',
'Sniper',
];
/**
* Gate built Prime items (Warframes, weapons) from being marked tradable.
* Built Prime items are not directly tradable -- only their individual
* components/parts are (e.g. Loki Prime Blueprint). Components get their
* own tradable flag set independently during parsing.
*
* To determine if a Prime set is tradable, check item.components for
* parts with tradable: true.
*
* Item-specific tradability overrides live in config/overrides.json
* (keyed by uniqueName) and are applied by parser.mjs applyOverrides()
* after this check runs.
*
* @param {module:warframe-items.Item} item Item to check
* @returns {boolean}
*/
const tradableConditions = (item) => !(builtUntradable.includes(item.type) && item.name.match(/Prime/gi));

const tradableArcanes = [
Expand Down
Loading