fix: default to Varzia when trader name is undefined (#688)

Author: SlayerOrnstein

lib/WorldState.ts

@@ -463,7 +463,7 @@ export class WorldState {
 
     this.steelPath = new SteelPathOffering(deps);
 
-    [this.vaultTrader] = parseArray(VoidTrader, data.PrimeVaultTraders, deps);
+    [this.vaultTrader] = parseArray(VoidTrader, data.PrimeVaultTraders, {...deps, character: 'Varzia'});
 
     [this.archonHunt] = parseArray(Sortie, data.LiteSorties, deps);
 

lib/models/VoidTrader.ts

@@ -49,7 +49,7 @@ export default class VoidTrader extends WorldstateObject {
    * The initial start date
    */
   initialStart: Date;
-  
+
   /**
    * Whether it's completed or not
    */
@@ -61,15 +61,16 @@ export default class VoidTrader extends WorldstateObject {
   schedule: VoidTraderSchedule[];
 
   /**
-   * @param data        The Void trader data
+   * @param data        The trader data
    * @param deps        The dependencies object
    * @param deps.locale Locale to use for translations
+   * @param deps.character   The trader name
    */
-  constructor(data: RawVoidTrader, { locale = 'en' }: Dependency = { locale: 'en' }) {
+  constructor(data: RawVoidTrader, { locale = 'en', character }: Dependency = { locale: 'en' }) {
     super(data);
     insist({ ...data }, 'Activation', 'Expiry');
 
-    this.character = data.Character ? data.Character.replace("Baro'Ki Teel", "Baro Ki'Teer") : '';
+    this.character = data.Character ? data.Character.replace("Baro'Ki Teel", "Baro Ki'Teer") : character ?? '';
     this.location = node(data.Node, locale);
     this.inventory = data.Manifest ? data.Manifest.map((i) => new VoidTraderItem(i, { locale })) : [];
     this.psId = `${this.id}${this.inventory.length}`;

lib/supporting/Dependency.ts

@@ -19,7 +19,7 @@ export default interface Dependency {
   /**
    * Generic logger to use if needed
    */
-  logger?: {debug: (message: string) => void};
+  logger?: { debug: (message: string) => void };
 
   /**
    * Sentint Data for parsing
@@ -30,4 +30,9 @@ export default interface Dependency {
    * Sortie data for parsing
    */
   sortieData?: SortieData;
+
+  /**
+   * Character name for traders
+   */
+  character?: string;
 }