Better to use array_key_exists

jtsternberg · jtsternberg · commit 3a7a2a2d704a · 2014-09-25T16:50:42.000-04:00
diff --git a/lib/class-wp-json-authentication-oauth1.php b/lib/class-wp-json-authentication-oauth1.php
@@ -65,7 +65,8 @@ public function retrieve_authorization_headers() {
 
 		if ( ! $auth_headers && function_exists( 'apache_request_headers' ) ) {
 			$all_headers = apache_request_headers();
-			$auth_headers = isset( $all_headers['Authorization'] ) ? $all_headers['Authorization'] : false;
+
+			$auth_headers = array_key_exists( 'Authorization', $all_headers ) ? $all_headers['Authorization'] : false;
 		}
 
 		return $auth_headers;

Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,8 @@ public function retrieve_authorization_headers() {`
`65`	`65`
`66`	`66`	`if ( ! $auth_headers && function_exists( 'apache_request_headers' ) ) {`
`67`	`67`	`$all_headers = apache_request_headers();`
`68`		`- $auth_headers = isset( $all_headers['Authorization'] ) ? $all_headers['Authorization'] : false;`
	`68`	`+`
	`69`	`+ $auth_headers = array_key_exists( 'Authorization', $all_headers ) ? $all_headers['Authorization'] : false;`
`69`	`70`	`}`
`70`	`71`
`71`	`72`	`return $auth_headers;`