Merge pull request #655 from AustinShalit/pmd-test

PMD for tests

Author: AustinShalit

.travis.yml

@@ -30,7 +30,7 @@ install:
   - '[ "${TRAVIS_PULL_REQUEST}" = "false" ] && ./gradlew :ui:jfxNative --stacktrace || ./gradlew --stacktrace '
 
 script:
-  - ./gradlew checkstyleMain checkstyleTest pmdMain jacocoTestReport jacocoRootReport test --stacktrace -Pheadless=true -PlogTests
+  - ./gradlew checkstyleMain checkstyleTest pmdMain pmdTest jacocoTestReport jacocoRootReport test --stacktrace -Pheadless=true -PlogTests
 
 after_success:
   - if [[ "$TRAVIS_OS_NAME" != "osx" ]]; then codecov         ; fi

appveyor.yml

@@ -6,7 +6,7 @@ build_script:
 
 # to run your custom scripts instead of automatic tests
 test_script:
-  - gradlew.bat checkstyleMain checkstyleTest pmdMain jacocoTestReport jacocoRootReport test --stacktrace -Pheadless=true -PlogTests
+  - gradlew.bat checkstyleMain checkstyleTest pmdMain pmdTest jacocoTestReport jacocoRootReport test --stacktrace -Pheadless=true -PlogTests
 
 platform:
   - x64

core/src/test/java/edu/wpi/grip/core/AddOperation.java

@@ -22,9 +22,9 @@
 public class AddOperation implements Operation {
   public static final OperationDescription DESCRIPTION = OperationDescription
       .builder().name("OpenCV Add").summary("Compute the per-pixel sum of two images.").build();
-  private SocketHint<Mat> aHint = SocketHints.Inputs.createMatSocketHint("a", false);
-  private SocketHint<Mat> bHint = SocketHints.Inputs.createMatSocketHint("b", false);
-  private SocketHint<Mat> sumHint = SocketHints.Inputs.createMatSocketHint("sum", true);
+  private final SocketHint<Mat> aHint = SocketHints.Inputs.createMatSocketHint("a", false);
+  private final SocketHint<Mat> bHint = SocketHints.Inputs.createMatSocketHint("b", false);
+  private final SocketHint<Mat> sumHint = SocketHints.Inputs.createMatSocketHint("sum", true);
 
   private InputSocket<Mat> a;
   private InputSocket<Mat> b;

core/src/test/java/edu/wpi/grip/core/AdditionOperation.java

@@ -15,13 +15,13 @@ public class AdditionOperation implements Operation {
           .name("Add")
           .summary("Compute the sum of two doubles")
           .build();
-  private SocketHint<Number> aHint = SocketHints.createNumberSocketHint("a", 0.0);
-  private SocketHint<Number> bHint = SocketHints.createNumberSocketHint("b", 0.0);
-  private SocketHint<Number> cHint = SocketHints.Outputs.createNumberSocketHint("c", 0.0);
+  private final SocketHint<Number> aHint = SocketHints.createNumberSocketHint("a", 0.0);
+  private final SocketHint<Number> bHint = SocketHints.createNumberSocketHint("b", 0.0);
+  private final SocketHint<Number> cHint = SocketHints.Outputs.createNumberSocketHint("c", 0.0);
 
-  private InputSocket<Number> a;
-  private InputSocket<Number> b;
-  private OutputSocket<Number> c;
+  private final InputSocket<Number> a;
+  private final InputSocket<Number> b;
+  private final OutputSocket<Number> c;
 
   public AdditionOperation(InputSocket.Factory isf, OutputSocket.Factory osf) {
     a = isf.create(aHint);

core/src/test/java/edu/wpi/grip/core/ConnectionTest.java

@@ -19,8 +19,6 @@ public class ConnectionTest {
   private static final Number testValue = Double.valueOf(12345.6789);
 
   private EventBus eventBus;
-  private SocketHint<Number> fooHint;
-  private SocketHint<Number> barHint;
 
   private OutputSocket<Number> foo;
   private InputSocket<Number> bar;
@@ -29,8 +27,8 @@ public class ConnectionTest {
   public void setUp() {
     eventBus = new EventBus();
 
-    fooHint = SocketHints.createNumberSocketHint("foo", 0.0);
-    barHint = SocketHints.createNumberSocketHint("bar", 0.0);
+    SocketHint<Number> fooHint = SocketHints.createNumberSocketHint("foo", 0.0);
+    SocketHint<Number> barHint = SocketHints.createNumberSocketHint("bar", 0.0);
 
     InputSocket.Factory isf = new MockInputSocketFactory(eventBus);
     OutputSocket.Factory osf = new MockOutputSocketFactory(eventBus);

core/src/test/java/edu/wpi/grip/core/CoreSanityTest.java

@@ -14,6 +14,7 @@
 
 import java.util.Arrays;
 
+@SuppressWarnings("PMD.TestClassWithoutTestCases")
 public class CoreSanityTest extends AbstractPackageSanityTests {
 
   public CoreSanityTest() {

core/src/test/java/edu/wpi/grip/core/ManualPipelineRunner.java

@@ -21,6 +21,7 @@ public PipelineRunner startAsync() {
     return this;
   }
 
+  @SuppressWarnings("PMD.UselessOverridingMethod")
   public void runPipeline() {
     super.runPipeline();
   }

core/src/test/java/edu/wpi/grip/core/MockOperation.java

@@ -27,6 +27,6 @@ public List<OutputSocket> getOutputSockets() {
 
   @Override
   public void perform() {
-
+    // This operation does nothing because it is a mock.
   }
 }

core/src/test/java/edu/wpi/grip/core/MockSource.java

@@ -37,6 +37,6 @@ public Properties getProperties() {
 
   @Override
   public void initialize() throws IOException {
-
+    // This source has no init because it is just a mock.
   }
 }

core/src/test/java/edu/wpi/grip/core/StepTest.java

@@ -19,7 +19,7 @@
 public class StepTest {
   private EventBus eventBus;
   private OperationMetaData additionMeta;
-  private GripCoreTestModule testModule = new GripCoreTestModule();
+  private final GripCoreTestModule testModule = new GripCoreTestModule();
 
   @Before
   public void setUp() {