Remove JavaFX from core

Author: AustinShalit

core/src/main/java/edu/wpi/grip/core/serialization/Project.java

@@ -22,8 +22,6 @@
 import java.io.Writer;
 import java.nio.charset.StandardCharsets;
 import java.util.Optional;
-import javafx.beans.property.SimpleBooleanProperty;
-import javafx.beans.value.ChangeListener;
 import javax.inject.Inject;
 import javax.inject.Singleton;
 
@@ -39,7 +37,7 @@ public class Project {
   @Inject
   private PipelineRunner pipelineRunner;
   private Optional<File> file = Optional.empty();
-  private final SimpleBooleanProperty saveIsDirty = new SimpleBooleanProperty(false);
+  private boolean saveIsDirty = false;
 
   @Inject
   public void initialize(StepConverter stepConverter,
@@ -113,7 +111,7 @@ void open(Reader reader) {
     this.pipeline.clear();
     this.xstream.fromXML(reader);
     pipelineRunner.startAsync();
-    saveIsDirty.set(false);
+    saveIsDirty = false;
   }
 
   /**
@@ -129,27 +127,19 @@ public void save(File file) throws IOException {
 
   public void save(Writer writer) {
     this.xstream.toXML(this.pipeline, writer);
-    saveIsDirty.set(false);
+    saveIsDirty = false;
   }
 
   public boolean isSaveDirty() {
-    return saveIsDirty.get();
-  }
-
-  public void addDirtyListener(ChangeListener<Boolean> changeListener) {
-    saveIsDirty.addListener(changeListener);
-  }
-
-  public void removeDirtyListener(ChangeListener<Boolean> changeListener) {
-    saveIsDirty.removeListener(changeListener);
+    return saveIsDirty;
   }
 
   @Subscribe
   public void onDirtiesSaveEvent(DirtiesSaveEvent dirtySaveEvent) {
     // Only update the flag the save isn't already dirty
     // We don't need to be redundantly checking if the event dirties the save
-    if (!saveIsDirty.get() && dirtySaveEvent.doesDirtySave()) {
-      saveIsDirty.set(true);
+    if (!saveIsDirty && dirtySaveEvent.doesDirtySave()) {
+      saveIsDirty = true;
     }
   }
 }

ui/src/main/java/edu/wpi/grip/ui/Main.java

@@ -3,6 +3,7 @@
 import edu.wpi.grip.core.GripCoreModule;
 import edu.wpi.grip.core.GripFileModule;
 import edu.wpi.grip.core.PipelineRunner;
+import edu.wpi.grip.core.events.DirtiesSaveEvent;
 import edu.wpi.grip.core.events.UnexpectedThrowableEvent;
 import edu.wpi.grip.core.http.GripServer;
 import edu.wpi.grip.core.http.HttpPipelineSwitcher;
@@ -31,6 +32,7 @@
 import javafx.application.Application;
 import javafx.application.Platform;
 import javafx.application.Preloader;
+import javafx.beans.property.SimpleBooleanProperty;
 import javafx.fxml.FXMLLoader;
 import javafx.scene.Parent;
 import javafx.scene.Scene;
@@ -61,6 +63,7 @@ public class Main extends Application {
   @Inject private HttpPipelineSwitcher pipelineSwitcher;
   private Parent root;
   private boolean headless;
+  private final SimpleBooleanProperty dirty = new SimpleBooleanProperty(false);
 
   public static void main(String[] args) {
     launch(args);
@@ -124,7 +127,7 @@ public void start(Stage stage) throws IOException {
       cvOperations.addOperations();
       notifyPreloader(new Preloader.ProgressNotification(0.9));
 
-      project.addDirtyListener((observable, oldValue, newValue) -> {
+      dirty.addListener((observable, oldValue, newValue) -> {
         if (newValue) {
           stage.setTitle(MAIN_TITLE + " | Edited");
         } else {
@@ -148,6 +151,13 @@ public void stop() {
     SafeShutdown.flagStopping();
   }
 
+  @Subscribe
+  public void onDirtiesSaveEvent(DirtiesSaveEvent dirtySaveEvent) {
+    if (dirty.get() != dirtySaveEvent.doesDirtySave()) {
+      dirty.set(dirtySaveEvent.doesDirtySave());
+    }
+  }
+
   @Subscribe
   @SuppressWarnings("PMD.AvoidCatchingThrowable")
   public final void onUnexpectedThrowableEvent(UnexpectedThrowableEvent event) {