Block (non-Javadoc) and System.out.println using checkstyle (#617)

* Block (non-Javadoc) using checkstyle

* Add System.*.print checking

* Update PipelineRunnerTest.java

Author: AustinShalit

build.gradle

@@ -98,6 +98,9 @@ allprojects {
     checkstyle {
         configFile = new File(rootDir, "checkstyle.xml")
         toolVersion = '6.19'
+        if (project.hasProperty("ignoreCheckstyle")) {
+            ignoreFailures = true
+        }
     }
 
     tasks.withType(Checkstyle) {

checkstyle.xml

@@ -235,5 +235,9 @@
             <property name="commentFormat" value=".*"/>
         </module>
         <module name="CommentsIndentation"/>
+        <module name="Regexp">
+            <property name="format" value="\(non\-Javadoc\)|System\..*\.print"/>
+            <property name="illegalPattern" value="true"/>
+        </module>
     </module>
 </module>

core/src/test/java/edu/wpi/grip/core/PipelineRunnerTest.java

@@ -14,9 +14,7 @@
 import com.google.common.eventbus.Subscribe;
 import com.google.common.util.concurrent.MoreExecutors;
 import com.google.common.util.concurrent.Service;
-
 import net.jodah.concurrentunit.Waiter;
-
 import org.junit.After;
 import org.junit.Before;
 import org.junit.Test;
@@ -27,6 +25,8 @@
 import java.util.List;
 import java.util.concurrent.TimeUnit;
 import java.util.concurrent.TimeoutException;
+import java.util.logging.Level;
+import java.util.logging.Logger;
 
 import static com.google.common.truth.Truth.assertThat;
 import static junit.framework.Assert.assertNull;
@@ -37,6 +37,8 @@
 @RunWith(Enclosed.class)
 public class PipelineRunnerTest {
 
+  private static final Logger logger = Logger.getLogger(PipelineRunnerTest.class.getName());
+
   interface SimpleOperation extends Operation {
     OperationDescription DESCRIPTION = OperationDescription.builder()
         .name("Simple Operation")
@@ -383,10 +385,9 @@ public synchronized void failed(Service.State from, Throwable failure) {
       this.failure = failure;
     }
 
-    @SuppressWarnings("PMD.SystemPrintln")
     public synchronized void throwIfProblemPresent() throws Throwable {
       if (failedFrom != null || failure != null) {
-        System.err.println("Failed from state " + failedFrom);
+        logger.log(Level.SEVERE, "Failed from state " + failedFrom);
         throw failure;
       }
     }

core/src/test/java/edu/wpi/grip/core/operations/opencv/AddOperationTest.java

@@ -64,15 +64,10 @@ public void testAddMatrixOfOnesToMatrixOfTwosEqualsMatrixOfThrees() {
     a.setValue(new Mat(2, sz, opencv_core.CV_8U, Scalar.all(1)));
     b.setValue(new Mat(2, sz, opencv_core.CV_8U, Scalar.all(2)));
 
-    //When
-    long startTime = System.currentTimeMillis();
     for (int i = 0; i < 1000; i++) {
       addition.perform();
     }
-    long endTime = System.currentTimeMillis();
-    System.out.println("Run time: " + (endTime - startTime));
 
-    //Then
     Mat expectedResult = new Mat(2, sz, opencv_core.CV_8U, Scalar.all(3));
     assertTrue(isMatEqual((Mat) c.getValue().get(), expectedResult));
   }