Skip to content

Checkstyle plugin #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 12 commits into from
Closed

Checkstyle plugin #274

wants to merge 12 commits into from

Conversation

@AustinShalit
Copy link
Member

@AustinShalit AustinShalit commented Jan 5, 2016

I added the checkstyle plugin. This should help solve #261.

@AustinShalit
Add checkstyle plugin
c38f215 
Add checkstyle plugin and configure for Google Java Style
@JLLeitschuh
Copy link
Member

JLLeitschuh commented Jan 5, 2016

Can you make it so that intellij automatically imports the stylesheet when you use ./gradlew idea
Perhaps @JacisNonsense might know more about that.
Also, make sure that all of the existing project files pass the style check.

@JLLeitschuh
Copy link
Member

JLLeitschuh commented Jan 5, 2016

Also, do we want to make this something to make ./gradlew check fail? If so then the task check needs to depend upon checkstyle.

JLLeitschuh
JLLeitschuh reviewed Jan 5, 2016
View reviewed changes
build.gradle Outdated
Copy link
Member

@JLLeitschuh JLLeitschuh Jan 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you want this here. Not entirely sure.

Copy link
Member Author

@AustinShalit AustinShalit Jan 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. I fixed this.

@ThomasJClark
Copy link
Contributor

ThomasJClark commented Jan 5, 2016

How do we run checkstyle? I can't find it under gradle tasks

@AustinShalit
Copy link
Member Author

AustinShalit commented Jan 5, 2016

I have been running it by running:

./gradlew :ui:check

This PR is failing right now for some reason. Will check it out later.

@AustinShalit
Copy link
Member Author

AustinShalit commented Jan 5, 2016

We should not merge this until after the V1.0.0 release.

@JaciBrunning
Copy link
Member

JaciBrunning commented Jan 5, 2016

I'll take a look at IntelliJ integration when I get the chance

@JLLeitschuh JLLeitschuh added this to the v1.0.1 milestone Jan 5, 2016
@JLLeitschuh
Copy link
Member

JLLeitschuh commented Jan 5, 2016

I agree, this should wait until after the kickoff release.

@AustinShalit AustinShalit force-pushed the AustinShalit-CheckStyle branch from cf3921f to 2fd83b2 Compare January 8, 2016 18:33
@AustinShalit AustinShalit force-pushed the AustinShalit-CheckStyle branch from 7e00bd9 to 633dc13 Compare January 8, 2016 20:24
@AustinShalit AustinShalit force-pushed the AustinShalit-CheckStyle branch from 633dc13 to 515c3cf Compare January 8, 2016 20:39
JaciBrunning
JaciBrunning reviewed Jan 20, 2016
View reviewed changes
build.gradle
Copy link
Member

@JaciBrunning JaciBrunning Jan 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe check.dependsOn build? This should work unless there is a circular task dependency

Copy link
Member

@JLLeitschuh JLLeitschuh Jan 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check.dependsOn build jacocoTestReport

@JLLeitschuh JLLeitschuh modified the milestones: v1.2.0, Future Jan 28, 2016
@AustinShalit
Copy link
Member Author

AustinShalit commented Apr 23, 2016

I am going to close this PR because Codacy now handles style checking.

@JLLeitschuh
Copy link
Member

JLLeitschuh commented Apr 26, 2016

I should configure that at some point.

@AustinShalit
Copy link
Member Author

AustinShalit commented Apr 27, 2016

I have a configuration that I can send you if you do not want to start with a blank slate. You can view the issues it generates here: https://www.codacy.com/app/austinshalit/GRIP/dashboard

@JLLeitschuh
Copy link
Member

JLLeitschuh commented May 10, 2016

Yea, if you could send me the config that would be great.

@AustinShalit AustinShalit deleted the AustinShalit-CheckStyle branch August 7, 2016 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

waiting for response

Projects

None yet

Milestone

Future

Development

Successfully merging this pull request may close these issues.

4 participants

@AustinShalit @JLLeitschuh @ThomasJClark @JaciBrunning