Skip to content

Commit 5759104

Browse files
committed
Only toggle fields required property if it's supposed to be required.
1 parent 0c6f0da commit 5759104

File tree

3 files changed

+13
-5
lines changed

3 files changed

+13
-5
lines changed

assets/js/src/wp-user-manager.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -182,9 +182,11 @@ jQuery( function( $ ) {
182182
var rules = $(this).data('condition');
183183
var validRule = self.validateRules(rules);
184184
$(this).toggle( validRule );
185-
$(this).find("input").prop("required", validRule);
186-
$(this).find("select").prop("required", validRule);
187-
$(this).find("textarea").prop("required", validRule);
185+
if ( $(this).find('.field').hasClass('required-field') ) {
186+
$( this ).find( "input" ).prop( "required", validRule );
187+
$( this ).find( "select" ).prop( "required", validRule );
188+
$( this ).find( "textarea" ).prop( "required", validRule );
189+
}
188190
});
189191
}
190192

assets/js/wp-user-manager.js

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,13 @@ jQuery( function( $ ) {
183183
this.validateFields = function(){
184184
form.find('fieldset[data-condition]').each(function(){
185185
var rules = $(this).data('condition');
186-
$(this).toggle( self.validateRules(rules) );
186+
var validRule = self.validateRules(rules);
187+
$(this).toggle( validRule );
188+
if ( $(this).find('.field').hasClass('required-field') ) {
189+
$( this ).find( "input" ).prop( "required", validRule );
190+
$( this ).find( "select" ).prop( "required", validRule );
191+
$( this ).find( "textarea" ).prop( "required", validRule );
192+
}
187193
});
188194
}
189195

assets/js/wp-user-manager.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)