HTML now not broken in error messages in forms, fixes #298

polevaultweb · polevaultweb · commit a7564349c8bc · 2022-08-12T21:51:00.000+01:00
diff --git a/includes/abstracts/abstract-wpum-form.php b/includes/abstracts/abstract-wpum-form.php
@@ -139,7 +139,7 @@ public function show_errors() {
 		$errors = apply_filters( 'wpum_form_errors', $this->errors, $this->form_name );
 		foreach ( $errors as $error ) {
 			WPUM()->templates
-			->set_template_data( [ 'message' => esc_html__( $error, 'wp-user-manager' ) ] )
+			->set_template_data( [ 'message' => $error ] )
 			->get_template_part( 'messages/general', 'error' );
 		}
 	}
diff --git a/templates/messages/general-error.php b/templates/messages/general-error.php
@@ -14,9 +14,11 @@
  */
 
 // Exit if accessed directly
-if ( ! defined( 'ABSPATH' ) ) exit;
+if ( ! defined( 'ABSPATH' ) ) {
+	exit;
+}
 
 ?>
 <div class="wpum-message error">
-	<p><?php echo $data->message; ?></p>
+	<p><?php echo wp_kses_post( $data->message ); ?></p>
 </div>

Original file line number	Diff line number	Diff line change
`@@ -139,7 +139,7 @@ public function show_errors() {`
`139`	`139`	`$errors = apply_filters( 'wpum_form_errors', $this->errors, $this->form_name );`
`140`	`140`	`foreach ( $errors as $error ) {`
`141`	`141`	`WPUM()->templates`
`142`		`- ->set_template_data( [ 'message' => esc_html__( $error, 'wp-user-manager' ) ] )`
	`142`	`+ ->set_template_data( [ 'message' => $error ] )`
`143`	`143`	`->get_template_part( 'messages/general', 'error' );`
`144`	`144`	`}`
`145`	`145`	`}`