Remove contained_by and all lookups for supported lookups.

Author: WaVEV

django_mongodb_backend/fields/embedded_model_array.py

@@ -92,8 +92,6 @@ class _EmbeddedModelArrayOutputField(ArrayField):
         "gte",
         "lt",
         "lte",
-        "all",
-        "contained_by",
     }
 
     def get_lookup(self, name):
@@ -205,25 +203,6 @@ class EmbeddedModelArrayFieldLessThanOrEqual(
     pass
 
 
-@_EmbeddedModelArrayOutputField.register_lookup
-class EmbeddedModelArrayFieldAll(
-    EmbeddedModelArrayFieldBuiltinLookup, Lookup, ArrayAggregationSubqueryMixin
-):
-    lookup_name = "all"
-    get_db_prep_lookup_value_is_iterable = False
-
-    def as_mql(self, compiler, connection):
-        lhs_mql = process_lhs(self, compiler, connection)
-        values = process_rhs(self, compiler, connection)
-        return {
-            "$and": [
-                {"$ne": [lhs_mql, None]},
-                {"$ne": [values, None]},
-                {"$setIsSubset": [values, lhs_mql]},
-            ]
-        }
-
-
 class KeyTransform(Transform):
     def __init__(self, key_name, array_field, *args, **kwargs):
         super().__init__(*args, **kwargs)

tests/model_fields_/test_embedded_model_array.py

@@ -187,17 +187,6 @@ def test_filter_unsupported_lookups(self):
                 self.assertCountEqual(MuseumExhibit.objects.filter(**kwargs), [])
                 self.assertIn(f"'field': '{lookup}'", captured_queries[0]["sql"])
 
-    def test_all_filter(self):
-        self.assertCountEqual(
-            MuseumExhibit.objects.filter(sections__section_number__all=[1, 2]), [self.wonders]
-        )
-
-    def test_contained_by(self):
-        self.assertCountEqual(
-            MuseumExhibit.objects.filter(sections__section_number__contained_by=[1, 2, 3]),
-            [self.egypt, self.new_descoveries, self.wonders, self.lost_empires],
-        )
-
     def test_len_filter(self):
         self.assertCountEqual(MuseumExhibit.objects.filter(sections__len=10), [])
         self.assertCountEqual(
@@ -310,9 +299,8 @@ def test_foreign_field_exact(self):
         self.assertCountEqual(qs, [self.egypt_tour, self.wonders_tour])
 
     def test_foreign_field_with_slice(self):
-        # Only wonders exhibit has exactly two sections, and this slice matches first two
-        qs = Tour.objects.filter(exhibit__sections__0_2__section_number__all=[1, 2])
-        self.assertEqual(list(qs), [self.wonders_tour])
+        qs = Tour.objects.filter(exhibit__sections__0_2__section_number__in=[1, 2])
+        self.assertCountEqual(qs, [self.wonders_tour, self.egypt_tour])
 
     def test_subquery_section_number_lt(self):
         subq = ExhibitAudit.objects.filter(
@@ -323,13 +311,6 @@ def test_subquery_section_number_lt(self):
             [self.egypt, self.wonders, self.new_descoveries],
         )
 
-    def test_check_all_subquery(self):
-        subquery = ExhibitAudit.objects.filter(reviewed=True).values_list(
-            "related_section_number", flat=True
-        )
-        result = MuseumExhibit.objects.filter(sections__section_number__all=subquery)
-        self.assertCountEqual(result, [self.wonders])
-
     def test_check_in_subquery(self):
         subquery = ExhibitAudit.objects.filter(reviewed=True).values_list(
             "related_section_number", flat=True