Drop search index if atlas is supported

Author: WaVEV

django_mongodb_backend/schema.py

@@ -290,13 +290,8 @@ def remove_index(self, model, index):
         if index.contains_expressions:
             return
         if isinstance(index, SearchIndex | VectorSearchIndex):
-            # Drop the index if it exists, particularly if it may not have been created previously
-            # due to lack of Atlas search support, but now the database supports it.
-            constraints = self.connection.introspection.get_constraints(
-                cursor=None,
-                table_name=model._meta.db_table,
-            )
-            if self.connection.features.supports_atlas_search and index.name in constraints:
+            # Drop the index if it is supported.
+            if self.connection.features.supports_atlas_search:
                 self.get_collection(model._meta.db_table).drop_search_index(index.name)
         else:
             self.get_collection(model._meta.db_table).drop_index(index.name)

tests/indexes_/test_atlas_indexes.py

@@ -1,5 +1,3 @@
-from unittest import mock
-
 from django.db import connection
 from django.test import TestCase, skipIfDBFeature, skipUnlessDBFeature
 
@@ -8,10 +6,7 @@
 from .models import Article
 
 
-class SearchIndexTests(TestCase):
-    # Tests for creating, validating, and removing search indexes using Django's schema editor.
-    available_apps = None
-
+class TestMixin:
     def assertAddRemoveIndex(self, editor, model, index):
         editor.add_index(index=index, model=model)
         self.assertIn(
@@ -30,6 +25,10 @@ def assertAddRemoveIndex(self, editor, model, index):
             ),
         )
 
+
+class SearchIndexTests(TestMixin, TestCase):
+    """Tests for creating, validating, and removing search indexes using Django's schema editor."""
+
     @skipUnlessDBFeature("supports_atlas_search")
     def test_simple(self):
         with connection.schema_editor() as editor:
@@ -40,17 +39,6 @@ def test_simple(self):
             editor.add_index(index=index, model=Article)
             self.assertAddRemoveIndex(editor, Article, index)
 
-    def test_drop_non_existing_index(self):
-        with connection.schema_editor() as editor:
-            index = SearchIndex(
-                name="recent_article_idx",
-                fields=["number"],
-            )
-            editor.get_collection = mock.MagicMock()
-            editor.remove_index(index=index, model=Article)
-            # Verify that the collection was not accessed
-            editor.get_collection.assert_not_called()
-
     @skipIfDBFeature("supports_atlas_search")
     def test_index_not_created(self):
         with connection.schema_editor() as editor:
@@ -110,39 +98,11 @@ def test_multiple_fields(self):
             self.assertAddRemoveIndex(editor, Article, index)
 
 
-class VectorSearchIndexTests(TestCase):
-    # Tests for creating, validating, and removing vector search indexes
-    # using Django's schema editor.
-    available_apps = None
-
-    def assertAddRemoveIndex(self, editor, model, index):
-        editor.add_index(index=index, model=model)
-        self.assertIn(
-            index.name,
-            connection.introspection.get_constraints(
-                cursor=None,
-                table_name=model._meta.db_table,
-            ),
-        )
-        editor.remove_index(index=index, model=model)
-        self.assertNotIn(
-            index.name,
-            connection.introspection.get_constraints(
-                cursor=None,
-                table_name=model._meta.db_table,
-            ),
-        )
-
-    def test_drop_non_existing_index(self):
-        with connection.schema_editor() as editor:
-            index = SearchIndex(
-                name="recent_article_idx",
-                fields=["number"],
-            )
-            editor.get_collection = mock.MagicMock()
-            editor.remove_index(index=index, model=Article)
-            # Verify that the collection was not accessed
-            editor.get_collection.assert_not_called()
+class VectorSearchIndexTests(TestMixin, TestCase):
+    """
+    Tests for creating, validating, and removing vector search indexes
+    using Django's schema editor.
+    """
 
     @skipUnlessDBFeature("supports_atlas_search")
     def test_deconstruct_default_similarity(self):