fix(runtime): close PROJ-1 stability gaps and align user_logs schema parity (#10)

- Fixes a PROJ-1 runtime stability issue in `tag_subscription` user listing by resolving the listing user safely from view context and guarding edit-link checks.
- Adds additive migration `20260218221000_ensure_user_logs_table_exists` to ensure `user_logs` exists with foreign key to `users`.
- Aligns migration DDL with canonical schema by using `ENGINE=InnoDB DEFAULT CHARSET=utf8`.
- Uses `SHOW TABLES LIKE ?` for efficient table-existence checks.
- Updates `db/schema.sql` and `db/table_schema/production/user_logs.php` to keep migrated and schema-based installs consistent.
- Addresses Copilot feedback for schema parity and migration query behavior.

Author: Wachhund

app/views/tag_subscription/_user_listing.php

@@ -1,11 +1,15 @@
-<?php $has_subscriptions = !empty($user->tag_subscriptions) && $user->tag_subscriptions->size() > 0; ?>
+<?php
+$listingUser = $this->user ?? ($user ?? null);
+$subscriptions = $listingUser ? $listingUser->tag_subscriptions : null;
+$has_subscriptions = $subscriptions && $subscriptions->size() > 0;
+?>
 
 <?php if (!$has_subscriptions) : ?>
   <?= $this->t('sub_none') ?>
 <?php else : ?>
-  <?= $this->tag_subscription_listing($user) ?>
+  <?= $this->tag_subscription_listing($listingUser) ?>
 <?php endif ?>
 
-<?php if (current_user()->id == $user->id) : ?>
+<?php if ($listingUser && current_user()->id == $listingUser->id) : ?>
   (<?= $this->linkTo($this->t('sub_edit'), 'tag_subscription#index') ?>)
 <?php endif ?>

db/migrate/20260218221000_ensure_user_logs_table_exists.php

@@ -0,0 +1,47 @@
+<?php
+class EnsureUserLogsTableExists extends Rails\ActiveRecord\Migration\Base
+{
+    public function up()
+    {
+        if (!$this->tableExists('user_logs')) {
+            $this->execute(<<<SQL
+                CREATE TABLE `user_logs` (
+                  `id` int(11) unsigned NOT NULL AUTO_INCREMENT,
+                  `user_id` int(11) NOT NULL,
+                  `ip_addr` varchar(46) NOT NULL,
+                  `created_at` datetime NOT NULL,
+                  PRIMARY KEY (`id`),
+                  KEY `created_at` (`created_at`),
+                  KEY `user_id` (`user_id`)
+                ) ENGINE=InnoDB DEFAULT CHARSET=utf8
+SQL
+            );
+        }
+
+        if (!$this->foreignKeyExists('user_logs', 'fk_user_logs__user_id')) {
+            $this->execute(
+                "ALTER TABLE `user_logs` ADD CONSTRAINT `fk_user_logs__user_id` FOREIGN KEY (`user_id`) REFERENCES `users` (`id`) ON DELETE CASCADE"
+            );
+        }
+    }
+
+    private function tableExists($tableName)
+    {
+        $stmt = $this->connection->executeSql("SHOW TABLES LIKE ?", $tableName);
+        $row = $stmt->fetch(\PDO::FETCH_NUM);
+
+        return $row !== false;
+    }
+
+    private function foreignKeyExists($tableName, $constraintName)
+    {
+        $stmt = $this->connection->executeSql(
+            "SELECT COUNT(*) AS count_value FROM information_schema.TABLE_CONSTRAINTS WHERE TABLE_SCHEMA = DATABASE() AND TABLE_NAME = ? AND CONSTRAINT_NAME = ? AND CONSTRAINT_TYPE = 'FOREIGN KEY'",
+            $tableName,
+            $constraintName
+        );
+        $row = $stmt->fetch(\PDO::FETCH_ASSOC);
+
+        return $row && (int)$row['count_value'] > 0;
+    }
+}

db/schema.sql

@@ -423,6 +423,16 @@ CREATE TABLE `user_blacklisted_tags` (
   UNIQUE KEY `user_id` (`user_id`)
 ) ENGINE=InnoDB DEFAULT CHARSET=utf8;
 
+CREATE TABLE `user_logs` (
+  `id` int(11) unsigned NOT NULL AUTO_INCREMENT,
+  `user_id` int(11) NOT NULL,
+  `ip_addr` varchar(46) NOT NULL,
+  `created_at` datetime NOT NULL,
+  PRIMARY KEY (`id`),
+  KEY `created_at` (`created_at`),
+  KEY `user_id` (`user_id`)
+) ENGINE=InnoDB DEFAULT CHARSET=utf8;
+
 CREATE TABLE `user_records` (
   `id` bigint(20) NOT NULL AUTO_INCREMENT,
   `user_id` int(11) NOT NULL,
@@ -600,6 +610,9 @@ ALTER TABLE `tag_implications`
 ALTER TABLE `user_blacklisted_tags`
   ADD CONSTRAINT `fk_user_bl_tags__user_id` FOREIGN KEY (`user_id`) REFERENCES `users` (`id`) ON DELETE CASCADE;
 
+ALTER TABLE `user_logs`
+  ADD CONSTRAINT `fk_user_logs__user_id` FOREIGN KEY (`user_id`) REFERENCES `users` (`id`) ON DELETE CASCADE;
+
 ALTER TABLE `user_records`
   ADD CONSTRAINT `fk_user_records__reported_by` FOREIGN KEY (`reported_by`) REFERENCES `users` (`id`) ON DELETE CASCADE,
   ADD CONSTRAINT `fk_user_records__user_id` FOREIGN KEY (`user_id`) REFERENCES `users` (`id`) ON DELETE CASCADE;

db/table_schema/production/user_logs.php

@@ -1,34 +1,34 @@
 <?php
 return array (
-  0 => 
+  0 =>
   array (
-    'id' => 
+    'id' =>
     array (
       'type' => 'int(11) unsigned',
       'default' => NULL,
     ),
-    'user_id' => 
+    'user_id' =>
     array (
       'type' => 'int(11)',
       'default' => NULL,
     ),
-    'ip_addr' => 
+    'ip_addr' =>
     array (
       'type' => 'varchar(46)',
       'default' => NULL,
     ),
-    'created_at' => 
+    'created_at' =>
     array (
       'type' => 'datetime',
       'default' => NULL,
     ),
   ),
-  1 => 
+  1 =>
   array (
-    'pri' => 
+    'pri' =>
     array (
       0 => 'id',
     ),
   ),
 )
-;
+;