fix(WhoIsActivve): remove zero value (qiuwenbaike#1678)

* fix(WhoIsActivve): remove zero value

Author: WaitSpringQW

dist/WhoIsActive/WhoIsActive.js

@@ -10,7 +10,7 @@ const appendLastActiveMarker = async ({usernames, $elements}: {usernames: string
 			continue;
 		}
 
-		const timestamp = (await getTimestamp(username)) ?? '0';
+		const timestamp = await getTimestamp(username);
 
 		if (!timestamp) {
 			continue;

src/WhoIsActive/modules/util/appendLastActiveMarker.ts

@@ -8,7 +8,7 @@ const appendLastActiveMarkerToUserPage = async (username: string) => {
 		return;
 	}
 
-	const timestamp = (await getTimestamp(username)) ?? '0';
+	const timestamp = await getTimestamp(username);
 
 	if (!timestamp) {
 		return;

src/WhoIsActive/modules/util/appendLastActiveMarkerToUserPage.ts

@@ -64,18 +64,28 @@ const getLogEventsTimestamp = async (leuser: string) => {
 	return timestamp;
 };
 
-const getTimestamp = async (username: string) => {
-	let timestamp: string;
+const getTimestamp = async (username: string): Promise<string | undefined> => {
+	let timestamp: string | undefined;
 
-	if (mw.storage.get(OPTIONS.storageKey + username)) {
-		timestamp = mw.storage.get(OPTIONS.storageKey + username) as string;
+	if (mw.storage.getObject(OPTIONS.storageKey + username)) {
+		timestamp = mw.storage.getObject(OPTIONS.storageKey + username) as string;
 	} else {
-		const ucTimestamp = (await getUserContribsTimestamp(username)) ?? '0';
-		const leTimestamp = (await getLogEventsTimestamp(username)) ?? '0';
-		timestamp = Number.parseInt(ucTimestamp, 10) > Number.parseInt(leTimestamp, 10) ? ucTimestamp : leTimestamp;
-
-		// Cache for 10 minutes
-		mw.storage.set(OPTIONS.storageKey + username, timestamp, 10 * 60);
+		const ucTimestamp = await getUserContribsTimestamp(username);
+		const leTimestamp = await getLogEventsTimestamp(username);
+
+		if (ucTimestamp || leTimestamp) {
+			if (ucTimestamp && leTimestamp) {
+				timestamp =
+					Number.parseInt(ucTimestamp, 10) > Number.parseInt(leTimestamp, 10) ? ucTimestamp : leTimestamp;
+			} else {
+				timestamp = ucTimestamp || leTimestamp;
+			}
+
+			// Cache for 10 minutes
+			mw.storage.setObject(OPTIONS.storageKey + username, timestamp, 10 * 60);
+		} else {
+			timestamp = undefined;
+		}
 	}
 
 	return timestamp;