Skip to content

Commit acd9e1b

Browse files
authored
fix(ShortURL): class for link icon (qiuwenbaike#1640)
* fix(ShortURL): class for link icon
1 parent 6456d86 commit acd9e1b

File tree

6 files changed

+32
-29
lines changed

6 files changed

+32
-29
lines changed

dist/ShortURL-pagestyles/ShortURL-pagestyles.css

Lines changed: 9 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/ShortURL/ShortURL.js

Lines changed: 4 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/definition.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
* ScrollUpButton[ResourceLoader|default|dependencies=ext.gadget.i18n,ext.gadget.React,ext.gadget.Tippy,ext.gadget.Util|peers=ScrollUpButton-pagestyles|requiresES6]|ScrollUpButton.js
4848
* ScrollUpButton-pagestyles[ResourceLoader|hidden|requiresES6]|ScrollUpButton-pagestyles.css
4949
* SearchShortcuts[ResourceLoader|dependencies=ext.gadget.Util|requiresES6]|SearchShortcuts.js
50-
* ShortURL[ResourceLoader|dependencies=ext.gadget.Clipboard,ext.gadget.i18n,ext.gadget.React,ext.gadget.Tippy,ext.gadget.Toastify,ext.gadget.Util,mediawiki.api,mediawiki.util,mediawiki.widgets,oojs-ui-windows|peers=ShortURL-pagestyles|requiresES6]|ShortURL.js
50+
* ShortURL[ResourceLoader|dependencies=ext.gadget.Clipboard,ext.gadget.i18n,ext.gadget.React,ext.gadget.Tippy,ext.gadget.Toastify,ext.gadget.Util,mediawiki.api,mediawiki.util,mediawiki.widgets,oojs-ui-windows,oojs-ui.styles.icons-editing-core|peers=ShortURL-pagestyles|requiresES6]|ShortURL.js
5151
* ShortURL-pagestyles[ResourceLoader|hidden|requiresES6]|ShortURL-pagestyles.css
5252
* SmoothTOC[ResourceLoader|default|dependencies=ext.gadget.Util|skins=gongbi,vector,vector-2022|requiresES6]|SmoothTOC.js
5353
* TextSpacing[ResourceLoader|dependencies=ext.gadget.Util|requiresES6]|TextSpacing.js|TextSpacing.css

src/ShortURL-pagestyles/ShortURL-pagestyles.less

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -8,18 +8,6 @@
88
text-indent: -9999px;
99
user-select: none;
1010

11-
.skin-gongbi & {
12-
vertical-align: sub;
13-
}
14-
15-
.citizen-body-header--sticky &,
16-
.ve-init-mw-desktopArticleTarget-originalContent & {
17-
display: none;
18-
}
19-
}
20-
21-
.gadget-short-link__icon,
22-
.mw-ui-icon-wikimedia-shortlink {
2311
&::before {
2412
background-image: data-uri('./images/link.svg');
2513
background-image: linear-gradient(transparent, transparent), data-uri('./images/link.svg');
@@ -32,4 +20,13 @@
3220
content: '';
3321
opacity: 0.6;
3422
}
23+
24+
.skin-gongbi & {
25+
vertical-align: sub;
26+
}
27+
28+
.citizen-body-header--sticky &,
29+
.ve-init-mw-desktopArticleTarget-originalContent & {
30+
display: none;
31+
}
3532
}

src/ShortURL/definition.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@
1313
"mediawiki.api",
1414
"mediawiki.util",
1515
"mediawiki.widgets",
16-
"oojs-ui-windows"
16+
"oojs-ui-windows",
17+
"oojs-ui.styles.icons-editing-core"
1718
],
1819
"peers": ["ShortURL-pagestyles"]
1920
}

src/ShortURL/modules/addLink.tsx

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,10 +83,15 @@ const addLink = (link: string, permaLink: string): void => {
8383
});
8484

8585
const isCitizen: boolean = skin === 'citizen';
86-
if (isCitizen && !$(portletLink).find('.mw-ui-icon-wikimedia-shortlink').length) {
86+
if (isCitizen && !$(portletLink).find('#mw-ui-icon-wikimedia-shortlink').length) {
8787
$(portletLink)
8888
.find('a')
89-
.prepend(<span class="citizen-ui-icon mw-ui-icon-wikimedia-shortlink" />);
89+
.prepend(
90+
<span
91+
id="mw-ui-icon-wikimedia-shortlink"
92+
className={['citizen-ui-icon', 'mw-ui-icon-link', 'mw-ui-icon-wikimedia-link']}
93+
/>
94+
);
9095
}
9196
}
9297

0 commit comments

Comments
 (0)